Fix negative starts in Slice and add no-op Expand for consts#21542
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Feb 28, 2022
Merged
Fix negative starts in Slice and add no-op Expand for consts#21542opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
alalek
reviewed
Feb 25, 2022
Comment on lines
+65
to
+75
| range.start = std::min(std::max(range.start, -n), n - 1); | ||
| range.start = (n + range.start) % n; | ||
|
|
||
| range.end = std::min(std::max(range.end, -n - 1), n); | ||
| bool neg = range.end < 0; | ||
| range.end = (n + 1 + range.end) % (n + 1); | ||
| if (neg) | ||
| { | ||
| range.end = (range.end + n) % (n + 1); | ||
| } |
Member
There was a problem hiding this comment.
Why do we have different expressions for the .start and the .end?
What is the difference between them? What is the difference against Python slicing?
Member
Author
There was a problem hiding this comment.
There should be no difference from python slicing.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with extra: opencv/opencv_extra#956
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.