Tracking API: added DaSiamRPN tracker#20036
Merged
alalek merged 5 commits intoopencv:masterfrom May 31, 2021
Merged
Conversation
alalek
reviewed
May 11, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Overall looks good!
After initial testing it makes sense to replace dedicated C++/Python samples.
samples/python/tracker.py
Outdated
| elif trackerAlgorithm == 'dasiamrpn': | ||
| tracker = cv.TrackerDaSiamRPN_create() | ||
| else: | ||
| sys.exit("Tracker is not recognized. Please use one of three available: mil, goturn, dasiamrpn.") |
Member
There was a problem hiding this comment.
It makes sense to dump trackerAlgorithm value here.
Contributor
Author
|
@alalek could you please check why models for tests haven't been downloaded? |
Member
|
alalek
reviewed
May 31, 2021
Comment on lines
+28
to
+29
| backend = 0; | ||
| target = 0; |
Member
There was a problem hiding this comment.
Prefer to avoid magic numbers:
#ifdef HAVE_OPENCV_DNN
backend = DNN_BACKEND_DEFAULT;
target = DNN_TARGET_CPU;
#else
backend = -1; // invalid value
target = -1; // invalid value
#endif
alalek
approved these changes
May 31, 2021
This was referenced Jun 4, 2021
Merged
This was referenced Jun 23, 2021
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
Tracking API: added DaSiamRPN tracker * added dasiamrpn tracker * dasiamrpn: add test, rewrite sample * change python samples * fix tests * fix params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with extra: opencv/opencv_extra#874
This PR moves DaSiamRPN tracker to video/tracking.hpp and allows to run tracker.py sample with specified tracking algorithm
relates #19078 #16554