Add DaSiamRPN tracker sample of c++ version by zihaomu · Pull Request #19078 · opencv/opencv

zihaomu · 2020-12-11T02:46:24Z

Hi, This is DaSiamRPN tracker with C++ version. The model used in this example is the same as PR18033.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Xforce_builders_only=docs,linux,win64

ieliz · 2020-12-11T12:43:22Z

samples/dnn/dasiamrpn_tracker.cpp

+    Box targetBox = {0,0,0,0};
+    int scoreSize = (instanceSize-exemplarSize)/totalStride+1;
+
+    std::vector<float> initBox= {334.02, 128.36, 438.19, 188.78, 396.39, 260.83, 292.23, 200.41};


As I see here, you are trying to reproduce the original version of the tracker from https://github.com/foolwood/DaSiamRPN/ .
Maybe it is gonna be better to use as an example our version from
https://github.com/opencv/opencv/blob/master/samples/dnn/dasiamrpn_tracker.py ?

Thank you for pointing this out, the new code has added the mouse to select the initial box.

ieliz · 2020-12-11T12:50:24Z

@alalek, for now, as I see it, C++ version is placed here samples/dnn/dasiamrpn_tracker.cpp .
Can we choose a more suitable place for the C++ version or we should wait for the PR: opencv/opencv_contrib#2753 ?

alalek

Thank you for contribution!

samples/dnn/dasiamrpn_tracker.cpp

alalek

Well done!

samples/dnn/dasiamrpn_tracker.cpp

alalek · 2020-12-24T06:03:49Z

samples/dnn/dasiamrpn_tracker.cpp

+    VideoCapture cap;
+    Mat image;
+
+    bool openSuccess = parser.has("input") ? cap.open(parser.get<String>("input")) : cap.open(0);


Please use samples::findFileOrKeep() helper for VideoCapture input source (to support GStreamer pipelines or URLs)

Thanks. In the new version, I have used samples::findFileOrKeep().

samples/dnn/dasiamrpn_tracker.cpp

alalek · 2020-12-24T06:41:25Z

samples/dnn/dasiamrpn_tracker.cpp

+    Mat image;
+
+    bool openSuccess = parser.has("input") ? cap.open(parser.get<String>("input")) : cap.open(0);
+    CV_Assert(openSuccess);


It is better to print the message with video file name instead of just CV_Assert()

Thanks, fixed.

alalek · 2021-01-06T23:13:30Z

samples/dnn/dasiamrpn_tracker.cpp

+    siamRPN.setPreferableBackend(5);
+    siamRPN.setPreferableTarget(DNN_TARGET_CUDA);


5

Avoid magic numbers.

DNN_TARGET_CUDA

Please make this as sample command-line parameter. See here

BTW, There are multiple networks used.

Thanks, fixed.

alalek · 2021-01-06T23:14:20Z

samples/dnn/dasiamrpn_tracker.cpp

+    CommandLineParser parser(argc, argv, keys);
+
+   if (argc == 1 || parser.has("help"))
+   {
+       parser.printMessage();
+       return 0;
+   }
+
+    std::string inputName = parser.get<String>("input");


fix indentation (4 spaces)

Thanks, fixed

alalek · 2021-01-06T23:18:12Z

samples/dnn/dasiamrpn_tracker.cpp

+                for(int j = 0; j < *(p+3); j++)
+                {
+                    index[0] = n, index[1] = k, index[2] = i, index[3] = j;
+                    src.at<float>(index) = fmax(src.at<float>(index), (float)(1.0/src.at<float>(index)));


.at() is evaluated 3 times here.

Use this code instead:

float& v = src.at<float>(index); v = fmax(v, 1.0f / v);

Thank you for your careful review. I have used your comment in new version.

alalek · 2021-01-06T23:23:08Z

samples/dnn/dasiamrpn_tracker.cpp

+        img(Rect(int(xMin), int(yMin), int(xMax - xMin + 1), int(yMax - yMin + 1))).copyTo(zCrop);
+    } else
+    {
+        copyMakeBorder(img, img, topPad, bottomPad, leftPad, rightPad, BORDER_CONSTANT, avgChans );


img, img

Don't use in-place parameters with non-inplace processing.
It has significant performance penalty.

img is passed as reference here (non-const). Function name (get*) says nothing about modification of passed image.

Thanks, fixed.

samples/dnn/dasiamrpn_tracker.cpp

asmorkalov · 2021-01-20T09:52:40Z

samples/dnn/dasiamrpn_tracker.cpp

+    siamRPN.setPreferableBackend(backend);
+    siamRPN.setPreferableTarget(target);
+    siamKernelR1.setPreferableBackend(backend);
+    siamKernelR1.setPreferableTarget(target);
+    siamKernelCL1.setPreferableBackend(backend);
+    siamKernelCL1.setPreferableTarget(target);


I propose to set parameters before object selection and print actual used backend to console. Not all target-backend combinations are valid and user can get this information on start.

Thank you for pointing out this. I will fix it soon.

I added 2 commits which include this fix.
Please fetch latest changes from the branch in your fork.

asmorkalov · 2021-01-20T09:58:22Z

samples/dnn/dasiamrpn_tracker.cpp

+    return anchors;
+}
+
+Mat getSubwindow(Mat &img, const Rect2f &targetBox, float originalSize, Scalar avgChans)


I propose to rename the function to copySubwindow to stress that it's not ROI, but deep copy.

This name is similar to .py sample.

Thank you for reviewing my code, Should I change this in .cpp file, @alalek @asmorkalov ?

I believe we can merge PR in its current state (when CI pass checks).

asmorkalov · 2021-01-20T09:58:42Z

samples/dnn/dasiamrpn_tracker.cpp

+    yMax = yMax + topPad;
+    yMin = yMin + topPad;
+
+    if(topPad == 0 && bottomPad ==0 && leftPad == 0 && rightPad == 0)


bottomPad ==0 space is missing.

applied clang-format

asmorkalov · 2021-01-20T10:56:08Z

samples/dnn/dasiamrpn_tracker.cpp

+    // Parse command line arguments.
+    CommandLineParser parser(argc, argv, keys);
+
+    if (argc == 1 || parser.has("help"))


It looks strange. All parameters have default values and I expect that sample should work by default with camera 0, if all models are there.

asmorkalov · 2021-01-20T10:57:49Z

The sample works for me on Ubuntu 18.04.

- exclude "keys" variable

alalek

Added commits with coding style and UX fixes.

alalek · 2021-01-24T01:11:47Z

samples/dnn/dasiamrpn_tracker.cpp

+    return anchors;
+}
+
+Mat getSubwindow(Mat &img, const Rect2f &targetBox, float originalSize, Scalar avgChans)


This name is similar to .py sample.

alalek · 2021-01-24T01:15:43Z

samples/dnn/dasiamrpn_tracker.cpp

+    yMax = yMax + topPad;
+    yMin = yMin + topPad;
+
+    if(topPad == 0 && bottomPad ==0 && leftPad == 0 && rightPad == 0)


applied clang-format

…_plus Add DaSiamRPN tracker sample of c++ version * add sample dasiamrpn_tracker of c++ version. * samples(dasiamrpn_tracker.cpp): apply clang-format - exclude "keys" variable * samples(dasiamrpn_tracker.cpp): coding style and UX fixes

ieliz reviewed Dec 11, 2020

View reviewed changes

alalek reviewed Dec 14, 2020

View reviewed changes

samples/dnn/dasiamrpn_tracker.cpp Outdated Show resolved Hide resolved

samples/dnn/dasiamrpn_tracker.cpp Outdated Show resolved Hide resolved

samples/dnn/dasiamrpn_tracker.cpp Outdated Show resolved Hide resolved

samples/dnn/dasiamrpn_tracker.cpp Outdated Show resolved Hide resolved

zihaomu requested a review from alalek December 22, 2020 12:22

alalek reviewed Dec 24, 2020

View reviewed changes

zihaomu requested a review from alalek December 29, 2020 02:21

alalek reviewed Jan 6, 2021

View reviewed changes

zihaomu force-pushed the dasiamrpn_tracker_c_plus_plus branch from 9e3a3a2 to f751c9c Compare January 7, 2021 15:43

zihaomu requested a review from alalek January 8, 2021 07:04

zihaomu force-pushed the dasiamrpn_tracker_c_plus_plus branch from f751c9c to c25d8c2 Compare January 16, 2021 13:11

add sample dasiamrpn_tracker of c++ version.

31c8767

zihaomu force-pushed the dasiamrpn_tracker_c_plus_plus branch from c25d8c2 to 31c8767 Compare January 17, 2021 00:54

asmorkalov reviewed Jan 20, 2021

View reviewed changes

samples(dasiamrpn_tracker.cpp): apply clang-format

5baa261

- exclude "keys" variable

alalek reviewed Jan 24, 2021

View reviewed changes

samples(dasiamrpn_tracker.cpp): coding style and UX fixes

49df83f

alalek approved these changes Jan 24, 2021

View reviewed changes

alalek merged commit 13a1105 into opencv:master Jan 24, 2021

alalek mentioned this pull request Apr 9, 2021

(5.x) Merge 4.x #19885

Merged

alalek mentioned this pull request Aug 28, 2021

Tracking API: added DaSiamRPN tracker #20036

Merged

		siamRPN.setPreferableBackend(5);
		siamRPN.setPreferableTarget(DNN_TARGET_CUDA);

Uh oh!

Conversation

zihaomu commented Dec 11, 2020 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ieliz commented Dec 11, 2020

Uh oh!

alalek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asmorkalov commented Jan 20, 2021

Uh oh!

alalek left a comment

zihaomu commented Dec 11, 2020 •

edited by alalek

Loading

alalek left a comment •

edited

Loading