Skip to content

Added CALIB_FIX_FOCAL_LENGTH to fisheye calibration#19539

Merged
alalek merged 2 commits intoopencv:masterfrom
asmorkalov:as/calib_fix_focal_length
Mar 3, 2021
Merged

Added CALIB_FIX_FOCAL_LENGTH to fisheye calibration#19539
alalek merged 2 commits intoopencv:masterfrom
asmorkalov:as/calib_fix_focal_length

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Feb 16, 2021

Resolves #13450
Replaces abandoned PR #18306 and adds test

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Bananahemic and others added 2 commits February 16, 2021 11:45
Sometimes you want to calibrate just the principal point of a camera, or just the distortion coefficients. In this case, you can pass the CALIB_FIX_FOCAL_LENGTH flag to keep Fx and Fy
@vpisarev
Copy link
Copy Markdown
Contributor

@asmorkalov, thank you! But please, click checkboxes in the PR description "I agree to contribute ..." etc., probably except for the last checkbox everything else can be "checked".

👍

CALIB_FIX_PRINCIPAL_POINT = 1 << 9,
CALIB_ZERO_DISPARITY = 1 << 10
CALIB_ZERO_DISPARITY = 1 << 10,
CALIB_FIX_FOCAL_LENGTH = 1 << 11
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add/extend bindings tests for constants.
There is some mess with constants with the same name and different values.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalek alalek merged commit e2ca50f into opencv:master Mar 3, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
…ngth

* Added CALIB_FIX_FOCAL_LENGTH to fisheye calibration opencv#13450

Sometimes you want to calibrate just the principal point of a camera, or just the distortion coefficients. In this case, you can pass the CALIB_FIX_FOCAL_LENGTH flag to keep Fx and Fy

* Added test for CALIB_FIX_FOCAL_LENGTH option in fisheye callinration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Fix K1...K4 and FX/FY For Fisheye Calibration

3 participants