Skip to content

Added CALIB_FIX_FOCAL_LENGTH to fisheye calibration #13450#18306

Closed
Bananahavoc wants to merge 1 commit intoopencv:masterfrom
Bananahavoc:master
Closed

Added CALIB_FIX_FOCAL_LENGTH to fisheye calibration #13450#18306
Bananahavoc wants to merge 1 commit intoopencv:masterfrom
Bananahavoc:master

Conversation

@Bananahavoc
Copy link
Copy Markdown

@Bananahavoc Bananahavoc commented Sep 10, 2020

Sometimes you want to calibrate just the principal point of a camera, or just the distortion coefficients. In this case, you can pass the CALIB_FIX_FOCAL_LENGTH flag to keep Fx and Fy

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 10, 2020

@vpisarev please take a look.

@Bananahavoc
Copy link
Copy Markdown
Author

Bananahavoc commented Nov 14, 2020

@vpisarev have you gotten a chance to take a look at this?

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 14, 2020

@BananaHemic Thank you for contribution!

It would be nice if you can add some simple test for added flag value (with checks that implementation preserves focal length values). It would help to ensure that we don't break this functionality in the future.
Something like this.

@asmorkalov asmorkalov added the pr: needs test New functionality requires minimal tests set label Nov 16, 2020
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 26, 2020

@BananaHemic Friendly reminder.

@Bananahavoc
Copy link
Copy Markdown
Author

Bananahavoc commented Nov 27, 2020

I will add tests once I get some time, sorry for the delay

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 20, 2021

@BananaHemic Friendly reminder. Please rebase the PR and fix conflicts.

1 similar comment
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 26, 2021

@BananaHemic Friendly reminder. Please rebase the PR and fix conflicts.

@Bananahavoc
Copy link
Copy Markdown
Author

Bananahavoc commented Jan 26, 2021

I'll do so later this week

Added CALIB_FIX_FOCAL_LENGTH to fisheye calibration opencv#13450
13d8823 
Sometimes you want to calibrate just the principal point of a camera, or just the distortion coefficients. In this case, you can pass the CALIB_FIX_FOCAL_LENGTH flag to keep Fx and Fy
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 10, 2021

@BananaHemic Friendly reminder.

@asmorkalov asmorkalov mentioned this pull request Feb 16, 2021
Merged
6 tasks
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 16, 2021

@BananaHemic As soon as you created the PR from master branch I cannot push new commits to your repository. I cherry-picked your commit and implemented test for the feature in #19539.

@asmorkalov asmorkalov closed this Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vpisarev vpisarev

Labels

category: calib3d feature pr: needs test New functionality requires minimal tests set

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bananahavoc @asmorkalov @alalek @vpisarev