Skip to content

DNN: Add LeakyReLU to TensorFlow Importer#19449

Merged
alalek merged 4 commits intoopencv:3.4from
jebastin-nadar:tf-leakyrelu
Feb 4, 2021
Merged

DNN: Add LeakyReLU to TensorFlow Importer#19449
alalek merged 4 commits intoopencv:3.4from
jebastin-nadar:tf-leakyrelu

Conversation

@jebastin-nadar
Copy link
Copy Markdown
Contributor

@jebastin-nadar jebastin-nadar commented Feb 2, 2021 •
edited by sl-sergei
Loading

resolves #18247

Merge with extra: opencv/opencv_extra#844

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
opencv_extra=tf-leakyrelu
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2021.1.0:20.04
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.1.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@jebastin-nadar jebastin-nadar changed the title add LeakyRelu to tf-importer DNN: Add LeakyReLU to TensorFlow Importer Feb 2, 2021
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Feb 3, 2021

Hi! Can you add a test for this layer?

@asmorkalov asmorkalov added category: dnn pr: needs test New functionality requires minimal tests set labels Feb 3, 2021
@asmorkalov asmorkalov requested a review from sl-sergei February 3, 2021 08:01
sl-sergei
sl-sergei reviewed Feb 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sl-sergei sl-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, please, add test to opencv/opencv_extra repo. See, for example, how
opencv/opencv_extra#825 was added for #18996

@jebastin-nadar
Copy link
Copy Markdown
Contributor Author

jebastin-nadar commented Feb 3, 2021

@dkurt @sl-sergei Sure working on it.

@jebastin-nadar jebastin-nadar mentioned this pull request Feb 3, 2021
Merged
@sl-sergei
Copy link
Copy Markdown
Contributor

sl-sergei commented Feb 3, 2021

@SamFC10 Testing failed for this PR because scripts didn't use your models from opencv_extra. I updated your comment, so buildbot will run tests using your models. Please, push empty commit to this PR to restart tests

@jebastin-nadar
Copy link
Copy Markdown
Contributor Author

jebastin-nadar commented Feb 4, 2021

@sl-sergei Tests failed again due to the same issue. I wonder what's going wrong! I don't think there's any problem with the leakyrelu test as all tests are passed on my local computer.

@asmorkalov asmorkalov removed the pr: needs test New functionality requires minimal tests set label Feb 4, 2021
sl-sergei
sl-sergei approved these changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sl-sergei sl-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍
@SamFC10 Don't look on the failed builds on OpenCV CN machines - the new CI is being integrated in China, probably some bug there.

@sl-sergei
Copy link
Copy Markdown
Contributor

sl-sergei commented Feb 4, 2021

@alalek Please, look at https://pullrequest.opencv.org/buildbot/builders/precommit_custom_mac/builds/1629/steps/cmake/logs/stdio
Is there something wrong with this builder?

@alalek alalek merged commit 09d2ca1 into opencv:3.4 Feb 4, 2021
@jebastin-nadar jebastin-nadar deleted the tf-leakyrelu branch February 5, 2021 04:36
@alalek alalek mentioned this pull request Feb 5, 2021
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sl-sergei sl-sergei sl-sergei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sl-sergei sl-sergei

Labels

category: dnn feature

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

LeakyReLU support in Tensorflow importer in OpenCV DNN module

5 participants

@jebastin-nadar @dkurt @sl-sergei @asmorkalov @alalek