Skip to content

Added TF resize_bilinear behaviour alignment#18996

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
LupusSanctus:am/dnn_bilinear_resize
Dec 8, 2020
Merged

Added TF resize_bilinear behaviour alignment#18996
opencv-pushbot merged 1 commit intoopencv:3.4from
LupusSanctus:am/dnn_bilinear_resize

Conversation

@LupusSanctus
Copy link
Copy Markdown

@LupusSanctus LupusSanctus commented Dec 2, 2020 •
edited by dkurt
Loading

Merge with extra: opencv/opencv_extra#825

Fixes #18721: TF resize bilinear upsampling layer shift

Added half_pixel_centers parameter to cover align_corners=False, half_pixel_centers=True case for TF resize_bilinear.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2021.1.0:20.04
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.1.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@LupusSanctus LupusSanctus mentioned this pull request Dec 2, 2020
Merged
dkurt
dkurt reviewed Dec 3, 2020
View reviewed changes
@LupusSanctus LupusSanctus force-pushed the am/dnn_bilinear_resize branch from 7515325 to 8ff518d Compare December 3, 2020 09:51
dkurt
dkurt reviewed Dec 3, 2020
View reviewed changes
@LupusSanctus LupusSanctus force-pushed the am/dnn_bilinear_resize branch from 8ff518d to 14bb8a8 Compare December 7, 2020 07:53
dkurt
dkurt reviewed Dec 7, 2020
View reviewed changes
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Dec 7, 2020

Take a look at failed test: https://pullrequest.opencv.org/buildbot/builders/precommit_custom_windows/builds/1719. You may skip it for specific backend or implement in initNgraph method

@LupusSanctus LupusSanctus force-pushed the am/dnn_bilinear_resize branch 2 times, most recently from f2447d7 to c16d1da Compare December 7, 2020 11:24
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Dec 7, 2020

@LupusSanctus , please check comments at opencv/opencv_extra#825

dkurt
dkurt approved these changes Dec 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 8, 2020

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

Also please make similar steps for opencv_extra's PR.

@LupusSanctus LupusSanctus force-pushed the am/dnn_bilinear_resize branch from c16d1da to a82c50e Compare December 8, 2020 19:56
@LupusSanctus LupusSanctus changed the base branch from master to 3.4 December 8, 2020 19:57
@LupusSanctus
Copy link
Copy Markdown
Author

LupusSanctus commented Dec 8, 2020

@alalek, the commit was rebased onto 3.4 branch.

@opencv-pushbot opencv-pushbot merged commit d8107a5 into opencv:3.4 Dec 8, 2020
@alalek alalek mentioned this pull request Dec 9, 2020
Merged
@YashasSamaga YashasSamaga mentioned this pull request Dec 27, 2020
Merged
6 tasks
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
savuor pushed a commit to nickyu-zhu/opencv that referenced this pull request Oct 27, 2023
Added data for TF resize_bilinear layer test
3ca9ea9 
Test data for OpenCV PR opencv#18996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn feature

Projects

None yet

Milestone

3.4.13

Development

Successfully merging this pull request may close these issues.

Bilinear upsampling layer shift

4 participants

@LupusSanctus @dkurt @alalek @opencv-pushbot