Not sure why the build failed... I only modified the Docs which built with the following warnings:

Couple of the warnings stem from half of this enum disapearing:
enum { CALIB_CB_ADAPTIVE_THRESH = 1, CALIB_CB_NORMALIZE_IMAGE = 2, CALIB_CB_FILTER_QUADS = 4, CALIB_CB_FAST_CHECK = 8, CALIB_CB_EXHAUSTIVE = 16, CALIB_CB_ACCURACY = 32, CALIB_CB_LARGER = 64, CALIB_CB_MARKER = 128 };
I assume running git rebase -i --onto upstream/3.4 upstream/master produced this result?

what the failed

Save current work and perform step-by-step small updates. There are too many changes on Diff page.

OK, so... code has been rebuilt locally a few times now and code builds fine with OpenCV master. The build issues seen here stem from the rebase (git rebase -i --onto upstream/3.4 upstream/master), where enums and parameters have changed to reflect what's shown below in 3.4.

In Master:
//! type of the robust estimation algorithm enum { LMEDS = 4, //!< least-median of squares algorithm RANSAC = 8, //!< RANSAC algorithm RHO = 16, //!< RHO algorithm USAC_DEFAULT = 32, //!< USAC algorithm, default settings USAC_PARALLEL = 33, //!< USAC, parallel version USAC_FM_8PTS = 34, //!< USAC, fundamental matrix 8 points USAC_FAST = 35, //!< USAC, fast settings USAC_ACCURATE = 36, //!< USAC, accurate settings USAC_PROSAC = 37, //!< USAC, sorted points, runs PROSAC USAC_MAGSAC = 38 //!< USAC, runs MAGSAC++ };

In 3.4:
//! type of the robust estimation algorithm enum { LMEDS = 4, //!< least-median of squares algorithm RANSAC = 8, //!< RANSAC algorithm RHO = 16 //!< RHO algorithm };

The question therefore is should I be rebasing to merge with 3.4? and if yes, how do I approach this? I've identified one USAC function declaration which appears without reference (see below), but thus far my attempts at a build without this header has only produced further errors downstream.

CV_EXPORTS_W Mat findEssentialMat( InputArray points1, InputArray points2, InputArray cameraMatrix1, InputArray cameraMatrix2, InputArray dist_coeff1, InputArray dist_coeff2, OutputArray mask, const UsacParams &params);

Need to create 2 PRs:

• keep this PR for 3.4: common changes and specific for 3.4 version
• separate PR for master: specific changes for master version (not necessary to duplicate "common" changes from 3.4 - they will be automatically merged during regular "Merge 3.4" process)

Need to create 2 PRs

If there's no way to merge my current working alterations in master into 3.4 without painstakingly re-editing calid3d.hpp's 3467 lines then I'm not sure I have the time to complete this task.

Alternatively, I've pushed my latest rebase revision which compiles locally for 3.4. Though functional, it reintroduces documentation for findChessboardCornersSB() which is currently omitted from 3.4. Is this latest commit something which would be acceptable? It can be tweaked, but if everything can be done in 3.4 then that would be ideal. No need to identify un-applied changes to redo in master.

@alalek how do you get the opencv-pushbot to rebuilt everything not just the docs? Docs are fine, just have warnings

findChessboardCornersSB()

should be removed from this patch (because it goes to 3.4 branch).
Look on "Files changed" tab on PR page and check for unrelated/unwanted changes.

rebuilt everything

I reduced testing scope (PR is under active development, so full scope is not really necessary).
Let fix docs and linux builders first.

@IanMaquignaz Do you have any progress with the patch?

@asmorkalov I have not had a chance to work on this since my last push. That being said, to accomplish the changes suggested by alalek, I need to create a fresh branch and restart.

I may have some time next week.

See new PR #19089

The patch is replaced with more focused PRs for 3.4 and master .