Skip to content

Minimum change to address issue #18837#18849

Merged
alalek merged 2 commits intoopencv:3.4from
IanMaquignaz:fix_findFundamentalMat_parameters
Nov 19, 2020
Merged

Minimum change to address issue #18837#18849
alalek merged 2 commits intoopencv:3.4from
IanMaquignaz:fix_findFundamentalMat_parameters

Conversation

@IanMaquignaz
Copy link
Copy Markdown
Contributor

@IanMaquignaz IanMaquignaz commented Nov 18, 2020 •
edited by alalek
Loading

Fixes #18837

Demo page for this patch.

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@IanMaquignaz IanMaquignaz mentioned this pull request Nov 18, 2020
Closed
5 tasks
@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 18, 2020

Demo page for this patch.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 18, 2020

@IanMaquignaz Please use @ref as it was recommended in the ticket. With @ref doxygen checks symbols in code and reports error, if code changes.

@IanMaquignaz
Copy link
Copy Markdown
Contributor Author

IanMaquignaz commented Nov 18, 2020

@asmorkalov @ref has been applied. Let me know if I did it correctly.

If yes, I believe this change could be applied to Rodriges(), findEssentialMat(), estimateAffine3D(), findHomography(), solvePnp() and possible more. Want me to apply this change here?

@asmorkalov asmorkalov self-requested a review November 18, 2020 20:33
@asmorkalov asmorkalov self-assigned this Nov 18, 2020
asmorkalov
asmorkalov approved these changes Nov 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IanMaquignaz
Copy link
Copy Markdown
Contributor Author

IanMaquignaz commented Nov 18, 2020 •
edited
Loading

👍

@asmorkalov Does that mean "yes, the use of @ref is correct" or "yes change is correct and go ahead and add those other changes to this pull request"?

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 19, 2020

@IanMaquignaz @ref works. You can see that doxygen adds link to enum description. There are another places in the header files, where enum keys are mentioned without reference. You can fix them all.

@alalek alalek merged commit bb067c7 into opencv:3.4 Nov 19, 2020
@IanMaquignaz IanMaquignaz deleted the fix_findFundamentalMat_parameters branch November 19, 2020 22:14
@IanMaquignaz
Copy link
Copy Markdown
Contributor Author

IanMaquignaz commented Nov 20, 2020

@asmorkalov see #18872

@alalek alalek mentioned this pull request Nov 20, 2020
Merged
IanMaquignaz added a commit to IanMaquignaz/opencv that referenced this pull request Nov 21, 2020
@IanMaquignaz
Merge pull request opencv#18849 from IanMaquignaz:fix_findFundamental…
46375a4 
…Mat_parameters

Minimum change to address issue opencv#18837
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: calib3d category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.13

Development

Successfully merging this pull request may close these issues.

3 participants

@IanMaquignaz @alalek @asmorkalov