Added '@ref' to 3.4 Camera Calibration and 3D Reconstruction documentation#19089
Conversation
|
Build has one warning: There is no option for |
| CALIB_FIX_INTRINSIC = 1 << 8, | ||
| CALIB_FIX_PRINCIPAL_POINT = 1 << 9 | ||
| CALIB_FIX_PRINCIPAL_POINT = 1 << 9, | ||
| CALIB_ZERO_DISPARITY = 0x00400 |
There was a problem hiding this comment.
Fixes issue where fisheye::CALIB_ZERO_DISPARITY does not exit
There was a problem hiding this comment.
= 0x00400
= cv::CALIB_ZERO_DISPARITY
to ensure that the same value is used anywhere (implementation still uses cv::CALIB_ZERO_DISPARITY internally).
There was a problem hiding this comment.
That shows up weird in the docs.
Just testing this before pushing:
TEST_F(fisheyeTest, stereoRectify)
{
// For consistency purposes
CV_Assert(cv::CALIB_ZERO_DISPARITY == cv::fisheye::CALIB_ZERO_DISPARITY)
Is that ok? or is it better to have explicit docs
There was a problem hiding this comment.
I believe check is ok here. But please use CV_StaticAssert() for that (in C++11 it is compilation error)
|
I removed the |
asmorkalov
left a comment
There was a problem hiding this comment.
Looks good to me. Please squash commits and we can merge the patch then.
…fisheye::CALIB_ZERO_DISPARITY == cv::CALIB_ZERO_DISPARITY == 0x400 == 1 << 10. Fisheye test has been updated to use new enum cv::fisheye::CALIB_ZERO_DISPARITY and included CV_StaticAssert(...) to ensure cv::CALIB_ZERO_DISPARITY == cv::fisheye::CALIB_ZERO_DISPARITY.
a897378 to
085a131
Compare
|
done @asmorkalov |
| @param cameraMatrix Input/output 3x3 floating-point camera intrinsic matrix | ||
| \f$\cameramatrix{A}\f$ . If CV\_CALIB\_USE\_INTRINSIC\_GUESS | ||
| and/or CALIB_FIX_ASPECT_RATIO are specified, some or all of fx, fy, cx, cy must be | ||
| \f$\cameramatrix{A}\f$ . If @ref CV_CALIB_USE_INTRINSIC_GUESS |
|
Updated missed references in master #19230 |
Added '@ref' to enumerations to enable doxygen checks in Camera Calibration and 3D Reconstruction documentation.
Replaces #18872
Notes:
@refto enumerations in@codeblocks.Observations (not addressed)
CALIB_FIX_INTRINSIC Fix cameraMatrix? and distCoeffs? so that only R, T, E, and F matrices are estimated.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.