fixed the ordering of contour convex hull points#16594
Merged
alalek merged 7 commits intoopencv:3.4from Feb 21, 2020
Merged
Conversation
alalek
reviewed
Feb 18, 2020
Member
alalek
left a comment
There was a problem hiding this comment.
Tests should be simple and clear as much as possible.
| Mat canvas_gray(Size(60*scale, 45*scale), CV_8U, Scalar::all(0)); | ||
| fillConvexPoly(canvas_gray, contour_.ptr<Point>(), npoints, Scalar(255, 255, 255)); | ||
|
|
||
| #if 1 // try to eliminate the self-intersection in one way or another |
Member
There was a problem hiding this comment.
Why do we not test input "as is"?
Why do we need these hacks with preparation of input before calling of testing functions?
Why is original input considered as invalid and it requires such processing?
Suggested input comes from somewhere and should be processed in its original form - instead of drawing, dilating and finding contours.
Contributor
Author
There was a problem hiding this comment.
ok, I added the code to test the original contour
… the original contour as well
…n convexHull and convexityDetects on the original contour, without any manipulations. the rest of the test stays the same
jshiwam
pushed a commit
to jshiwam/opencv
that referenced
this pull request
Feb 22, 2020
fixed the ordering of contour convex hull points * partially fixed the issue opencv#4539 * fixed warnings and test failures * fixed integer overflow (issue opencv#14521) * added comment to force buildbot to re-run * extended the test for the issue 4539. Check the expected behaviour on the original contour as well * added comment; fixed typo, renamed another variable for a little better clarity * added yet another part to the test for issue opencv#4539, where we run convexHull and convexityDetects on the original contour, without any manipulations. the rest of the test stays the same
jshiwam
added a commit
to jshiwam/opencv
that referenced
this pull request
Feb 22, 2020
…m added dnn: don't require setInput in .dump() dnn: auto network dump through parameter Improved GStreamer documentation. improved documentation for imread() videoio/MSMF: refactored format handling and selection, property reading and writing dnn(test): skip failed ngraph tests add cuda 10 support 3.4 docs for 3.4 branch Resolve opencv#14566 Merge pull request opencv#16445 from atinfinity:fixed-typo * fixed typo * add compatibility code to handle migration Enable Mask R-CNN with Inference Engine. Full coverage with nGraph intrin: fixed int64->double conversion for AVX-512 Merge pull request opencv#16608 from vpisarev:fix_mac_ocl_tests * fixed several problems when running tests on Mac: * OCL_pyrUp * OCL_flip * some basic UMat tests * histogram badarg test (out of range access) * retained the storepix fix in ocl_flip only for 16U/16S datatype, where the OpenCL compiler on Mac generates incorrect code * moved deletion of ACCESS_FAST flag to non-SVM branch (where SVM is shared virtual memory (in OpenCL 2.x), not support vector machine) * force OpenCL to use read/write for GPU<=>CPU memory transfers on machines with discrete video only on Macs. On Windows/Linux the drivers are seemingly smart enough to implement map/unmap properly (and maybe more efficiently than explicit read/write) Merge pull request opencv#16594 from vpisarev:hull_ordering_fix fixed the ordering of contour convex hull points * partially fixed the issue opencv#4539 * fixed warnings and test failures * fixed integer overflow (issue opencv#14521) * added comment to force buildbot to re-run * extended the test for the issue 4539. Check the expected behaviour on the original contour as well * added comment; fixed typo, renamed another variable for a little better clarity * added yet another part to the test for issue opencv#4539, where we run convexHull and convexityDetects on the original contour, without any manipulations. the rest of the test stays the same
Merged
bommo1
reviewed
Jul 14, 2020
| increasing_idx = !(hcurr < hnext); | ||
| else if( increasing_idx != (hcurr < hnext)) | ||
| { | ||
| CV_Error(Error::StsBadArg, |
Contributor
There was a problem hiding this comment.
This change sometimes breaks the ERFilter.
https://github.com/opencv/opencv_contrib/blob/master/modules/text/src/erfilter.cpp#L2837
Member
There was a problem hiding this comment.
Please provide complete minimal reproducer and fill an issue in opencv_contrib.
6 tasks
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #14521.
Partially fixes the issue #4539.