Merged
Conversation
dkurt
reviewed
Jan 27, 2020
| <opencv_storage> | ||
| <charuco_dict>0</charuco_dict> | ||
| <charuco_square_lenght>200</charuco_square_lenght> | ||
| <charuco_square_length>200</charuco_square_length> |
Member
There was a problem hiding this comment.
not sure about changing a config file because it can lead to incompatibility issues
Member
There was a problem hiding this comment.
I believe this compatibility code can handle migration:
if (readFromNode(reader["charuco_square_lenght"], mCapParams.charucoSquareLength))
std::cout << "DEPRECATION: Parameter 'charuco_square_lenght' has been deprecated (typo). Use 'charuco_square_length' instead." << std::endl;
readFromNode(reader["charuco_square_length"], mCapParams.charucoSquareLength);
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
@asmorkalov Sorry for the late reply. I'll try to do this weekend.
Merged
jshiwam
pushed a commit
to jshiwam/opencv
that referenced
this pull request
Feb 22, 2020
* fixed typo * add compatibility code to handle migration
jshiwam
added a commit
to jshiwam/opencv
that referenced
this pull request
Feb 22, 2020
…m added dnn: don't require setInput in .dump() dnn: auto network dump through parameter Improved GStreamer documentation. improved documentation for imread() videoio/MSMF: refactored format handling and selection, property reading and writing dnn(test): skip failed ngraph tests add cuda 10 support 3.4 docs for 3.4 branch Resolve opencv#14566 Merge pull request opencv#16445 from atinfinity:fixed-typo * fixed typo * add compatibility code to handle migration Enable Mask R-CNN with Inference Engine. Full coverage with nGraph intrin: fixed int64->double conversion for AVX-512 Merge pull request opencv#16608 from vpisarev:fix_mac_ocl_tests * fixed several problems when running tests on Mac: * OCL_pyrUp * OCL_flip * some basic UMat tests * histogram badarg test (out of range access) * retained the storepix fix in ocl_flip only for 16U/16S datatype, where the OpenCL compiler on Mac generates incorrect code * moved deletion of ACCESS_FAST flag to non-SVM branch (where SVM is shared virtual memory (in OpenCL 2.x), not support vector machine) * force OpenCL to use read/write for GPU<=>CPU memory transfers on machines with discrete video only on Macs. On Windows/Linux the drivers are seemingly smart enough to implement map/unmap properly (and maybe more efficiently than explicit read/write) Merge pull request opencv#16594 from vpisarev:hull_ordering_fix fixed the ordering of contour convex hull points * partially fixed the issue opencv#4539 * fixed warnings and test failures * fixed integer overflow (issue opencv#14521) * added comment to force buildbot to re-run * extended the test for the issue 4539. Check the expected behaviour on the original contour as well * added comment; fixed typo, renamed another variable for a little better clarity * added yet another part to the test for issue opencv#4539, where we run convexHull and convexityDetects on the original contour, without any manipulations. the rest of the test stays the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
I fixed the following typo in opencv.
lenght->lengthLenght->Length