Conversation
|
👍 /cc @hannesa2 |
| * Current OpenCV Library version | ||
| */ | ||
| public static final String OPENCV_VERSION = BuildConfig.VERSION_NAME; | ||
| public static final String OPENCV_VERSION = "@OPENCV_VERSION_MAJOR@.@OPENCV_VERSION_MINOR@.@OPENCV_VERSION_PATCH@"; |
There was a problem hiding this comment.
With you suggestion #16222 (comment) we do now https://github.com/hannesa2/owncloud-android/blob/70b27be1ade7f30b0e1e8e699ec6a61b09949aaf/owncloudApp/build.gradle#L263-L266 a calculation
which we don't do here. So it differs !
That's why I tried to go into the direction of a single point of truth, instead to set this value on various places.
In an ideal world you would take the git tag name like https://github.com/hannesa2/owncloud-android/blob/70b27be1ade7f30b0e1e8e699ec6a61b09949aaf/owncloudApp/build.gradle#L263-L266
The main problem is javadoc and not the usage of state of the art BuildConfig
There was a problem hiding this comment.
Not sure that I understand you correctly.
OPENCV_VERSION ("4.2.0") != package version code (40020000)
Yes, Javadoc generation can be migrated on Gradle (for Android only? because we still have normal "desktop" Java with "Ant"): https://docs.gradle.org/current/dsl/org.gradle.api.tasks.javadoc.Javadoc.html
(unfortunatelly we don't have extra time for this task right now)
partially reverts #16222
Javadoc doesn't know about Gradle and its scripts.
Should fix nightly builds: http://pullrequest.opencv.org/buildbot/builders/master_pack-android