Android move version info to Gradle style#16222
Merged
alalek merged 4 commits intoopencv:masterfrom Jan 3, 2020
Merged
Conversation
4284057 to
b46635d
Compare
Member
You may check "build sdk" logs here: http://pullrequest.opencv.org/buildbot/builders/master_pack-android (11032 build is from 4.2.0 release) |
4a92af3 to
7687b6a
Compare
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
Android move version info to Gradle style * move version info to Gradle style * Use VERSION_NAME in loader * apply review suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
Currently you set Android version info in
AndroidManifest.xml, but this is an old relict from Eclipse time. The Gradle way is to have this info inbuild.gradleBtw, how you provide the Android release is very confusing at least to me. I was not able to test my pull request properly. To be honest, I would like a out-of-the-box running Android project within this repo and no
build.gradle.infiles and so on. Then we could much easier contribute to the Android part.