Skip to content

remove Eclipse relicts in Android sample#16349

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
hannesa2:RemoveEclipseRelicts
Jan 16, 2020
Merged

remove Eclipse relicts in Android sample#16349
opencv-pushbot merged 1 commit intoopencv:masterfrom
hannesa2:RemoveEclipseRelicts

Conversation

@hannesa2
Copy link
Copy Markdown
Contributor

@hannesa2 hannesa2 commented Jan 15, 2020

It removes more Eclipse relicts used by previous Android samples. With recent Gradle sample they are pointless

@alalek
Copy link
Copy Markdown
Member

alalek commented Jan 15, 2020

samples/java/eclipse/HelloCV

This is not Android stuff.
Eclipse IDE is not dead.

android_test

Android tests are not ported on Gradle yet.

BTW, Nightly Android pack builds are broken (since Jan 4, perhaps by #16222): http://pullrequest.opencv.org/buildbot/builders/master_pack-android

@hannesa2 hannesa2 force-pushed the RemoveEclipseRelicts branch from 819241e to afc8dd5 Compare January 15, 2020 06:20
@hannesa2
Copy link
Copy Markdown
Contributor Author

hannesa2 commented Jan 15, 2020

samples/java/eclipse/HelloCV

android_test

@alalek you are right, I reverted these files 👍

BTW, Nightly Android pack builds are broken (since Jan 4, perhaps by #16222): http://pullrequest.opencv.org/buildbot/builders/master_pack-android

I did a look, but unfortunately I don't understand the issue

Constructing Javadoc information...
/build/master_pack-android/build/OpenCV-android-sdk/sdk/java/src/org/opencv/android/CameraGLSurfaceView.java:3: error: cannot find symbol
import org.opencv.R;
                 ^
  symbol:   class R
  location: package org.opencv
/build/master_pack-android/build/OpenCV-android-sdk/sdk/java/src/org/opencv/android/CameraBridgeViewBase.java:5: error: cannot find symbol
import org.opencv.BuildConfig;
                 ^
  symbol:   class BuildConfig
  location: package org.opencv
/build/master_pack-android/build/OpenCV-android-sdk/sdk/java/src/org/opencv/android/CameraBridgeViewBase.java:6: error: cannot find symbol
import org.opencv.R;
                 ^

and this

Generating /build/master_pack-android/build/OpenCV-android-sdk/sdk/java/javadoc/org/opencv/android/OpenCVLoader.html...
error: cannot find symbol

  symbol:   variable BuildConfig
  location: class OpenCVLoader

Maybe you have a hint or know how to get rid of it ? My knowledge about Javadoc is just rudimentary

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 15, 2020

".R" is Java class generated from resources. Eclipse did it on the go, when you edit resources. The step should be handled by Gradle in some point, but I cannot give you ready recipe for this.

opencv-pushbot pushed a commit that referenced this pull request Jan 16, 2020
@alalek
Merge pull request #16349 from hannesa2:RemoveEclipseRelicts
c30af72
@opencv-pushbot opencv-pushbot merged commit afc8dd5 into opencv:master Jan 16, 2020
@hannesa2 hannesa2 deleted the RemoveEclipseRelicts branch January 17, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: samples platform: android

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hannesa2 @alalek @asmorkalov @opencv-pushbot