Fix swapped channels in BGR* conversion utility function#16265
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jan 5, 2020
Merged
Fix swapped channels in BGR* conversion utility function#16265opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
Member
|
As a bugfix this patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
- some of `icvCvt_BGR*` functions have R with B channels swapped what leads to the wrong conversion - renames misleading `rgb` variable name to `bgr` - swap back the conversion coefficients, `cB` should be the first Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Contributor
Author
|
@alalek - done |
opencv-pushbot
pushed a commit
that referenced
this pull request
Jan 5, 2020
Merged
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Apr 10, 2020
….1.0, FFmpeg to 4.2.2 - bumps up OpenCV to the latest version 4.3.0 - conda build is not updated as prebuild OpenCV (4.2.0 at most) binaries don't have bug opencv/opencv#16265 fixed - updates docs regarding libturbo-jpeg and OpenCV version - bumps libturbo-jpeg to 2.0.4 (2.0.3 for conda due to availability) - bumps libtiff to 4.1.0 - bumps FFmpeg to 4.2.2 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
added a commit
to NVIDIA/DALI
that referenced
this pull request
Apr 14, 2020
….1.0, FFmpeg to 4.2.2 (#1783) - bumps up OpenCV to the latest version 4.3.0 - conda build is not updated as prebuild OpenCV (4.2.0 at most) binaries don't have bug opencv/opencv#16265 fixed - updates docs regarding libturbo-jpeg and OpenCV version - bumps libturbo-jpeg to 2.0.4 (2.0.3 for conda due to availability) - bumps libtiff to 4.1.0 - bumps FFmpeg to 4.2.2 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #16215
This pull request changes
icvCvt_BGR*functions have R with B channelsswapped what leads to the wrong conversion
rgbvariable name tobgrcBshould be the firstSigned-off-by: Janusz Lisiecki jlisiecki@nvidia.com