Skip to content

Bump up OpenCV version to 4.3.0, libturbo-jpeg to 2.0.4, libtiff to 4.1.0, FFmpeg to 4.2.2#1783

Merged
JanuszL merged 1 commit intoNVIDIA:masterfrom
JanuszL:bump_opencv
Apr 14, 2020
Merged

Bump up OpenCV version to 4.3.0, libturbo-jpeg to 2.0.4, libtiff to 4.1.0, FFmpeg to 4.2.2#1783
JanuszL merged 1 commit intoNVIDIA:masterfrom
JanuszL:bump_opencv

Conversation

@JanuszL
Copy link
Copy Markdown
Contributor

@JanuszL JanuszL commented Mar 2, 2020 •
edited
Loading

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

  • It fixes a bug with the wrong version of required libturbo-jpeg in docs
  • It adds new feature needed because of we want to have latest OpenCV, libtiff, libturbo-jpeg and FFmpeg

What happened in this PR?

  • What solution was applied:
    bumps up OpenCV, libturbo-jpeg, libtiff and FFmpeg to the latest version
    updates docs regarding libturbo-jepeg, libtiff, OpenCV and FFmpeg version
  • Affected modules and functionalities:
    compilation of deps for x86, aarch64-linux and aarch64-qnx
  • Key points relevant for the review:
    NA
  • Validation and testing:
    test build in CI
  • Documentation (including examples):
    compilation doc is updated

JIRA TASK: [NA]

@JanuszL JanuszL changed the title Code Issues 108 Pull requests 15 Actions Projects 2 Wiki Security Insights [WIP]Bump up OpenCV version to 4.1.2 [WIP]Bump up OpenCV version to 4.1.2 Mar 2, 2020
@JanuszL JanuszL changed the title [WIP]Bump up OpenCV version to 4.1.2 [WIP]Bump up OpenCV version to 4.3.0 Apr 9, 2020
@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 9, 2020

CI MESSAGE: [1244048]: BUILD STARTED

@JanuszL JanuszL changed the title [WIP]Bump up OpenCV version to 4.3.0 [WIP] Bump up OpenCV version to 4.3.0, libturbo-jpeg to 2.0.4, libtiff to 4.1.0, FFmpeg to 4.2.2 Apr 9, 2020
@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 9, 2020

CI MESSAGE: [1244170]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 9, 2020

CI MESSAGE: [1244170]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 9, 2020

CI MESSAGE: [1244266]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 9, 2020

CI MESSAGE: [1244266]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 9, 2020

CI MESSAGE: [1244336]: BUILD STARTED

@JanuszL JanuszL changed the title [WIP] Bump up OpenCV version to 4.3.0, libturbo-jpeg to 2.0.4, libtiff to 4.1.0, FFmpeg to 4.2.2 Bump up OpenCV version to 4.3.0, libturbo-jpeg to 2.0.4, libtiff to 4.1.0, FFmpeg to 4.2.2 Apr 9, 2020
@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 9, 2020

CI MESSAGE: [1244336]: BUILD PASSED

jantonguirao
jantonguirao approved these changes Apr 10, 2020
View reviewed changes
conda/recipe/meta.yaml Outdated
Copy link
Copy Markdown
Contributor

@jantonguirao jantonguirao Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for it to be 2.0.3 here are 2.0.4 in the Dockerfile?

Copy link
Copy Markdown
Contributor Author

@JanuszL JanuszL Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I can try to push conda for update upstream libjpeg-turbo.

Copy link
Copy Markdown
Contributor Author

@JanuszL JanuszL Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have attempted to fix their build - conda-forge/libjpeg-turbo-feedstock#16.

klecki
klecki reviewed Apr 10, 2020
View reviewed changes
docs/compilation.rst Outdated
Comment on lines 83 to 84
Copy link
Copy Markdown
Contributor

@klecki klecki Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should also be udpated to 4.2.2

Copy link
Copy Markdown
Contributor Author

@JanuszL JanuszL Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@JanuszL
Bump up OpenCV version to 4.3.0, libturbo-jpeg to 2.0.4, libtiff to 4…
111e378 
….1.0, FFmpeg to 4.2.2

- bumps up OpenCV to the latest version 4.3.0
- conda build is not updated as prebuild OpenCV (4.2.0 at most) binaries
  don't have bug opencv/opencv#16265 fixed
- updates docs regarding libturbo-jpeg and OpenCV version
- bumps libturbo-jpeg to 2.0.4 (2.0.3 for conda due to availability)
- bumps libtiff to 4.1.0
- bumps FFmpeg to 4.2.2

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 10, 2020

CI MESSAGE: [1246766]: BUILD STARTED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 10, 2020

CI MESSAGE: [1246766]: BUILD FAILED

@dali-automaton
Copy link
Copy Markdown
Collaborator

dali-automaton commented Apr 11, 2020

CI MESSAGE: [1246766]: BUILD PASSED

@JanuszL JanuszL merged commit 469746e into NVIDIA:master Apr 14, 2020
@JanuszL JanuszL deleted the bump_opencv branch April 14, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@klecki klecki klecki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JanuszL @dali-automaton @jantonguirao @klecki