Skip to content

Segmentation module#15082

Merged
alalek merged 6 commits intoopencv:masterfrom
dvd42:segmentation-module
Aug 13, 2019
Merged

Segmentation module#15082
alalek merged 6 commits intoopencv:masterfrom
dvd42:segmentation-module

Conversation

@dvd42
Copy link
Copy Markdown
Contributor

@dvd42 dvd42 commented Jul 18, 2019 •
edited by dkurt
Loading

Adds a Segmentation module to the new high level DL API currently in l-bat's fork

Merge with extra: opencv/opencv_extra#655

opencv_extra=segmentation-module_data
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r2.0:16.04
build_image:Custom Win=openvino-2019r2.0
build_image:Custom Mac=openvino-2019r2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

This was referenced Jul 18, 2019
Merged
Closed
dkurt
dkurt reviewed Jul 23, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 23, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 23, 2019
View reviewed changes
@dvd42 dvd42 force-pushed the segmentation-module branch 2 times, most recently from 54b53bd to 25edad7 Compare July 26, 2019 14:58
@dvd42 dvd42 mentioned this pull request Jul 30, 2019
Merged
@mshabunin mshabunin added the GSoC label Jul 30, 2019
@dvd42 dvd42 force-pushed the segmentation-module branch from d3467e3 to e89af43 Compare July 30, 2019 13:36
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 31, 2019

@dvd42, please rebase this branch with current master.

@dvd42
Copy link
Copy Markdown
Contributor Author

dvd42 commented Jul 31, 2019

@dkurt, done. I am guessing I should do the same for #15081 and #15189, right?

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 31, 2019

@dvd42, Yes. Please avoid "merge" commits - squash commits into one.

dkurt
dkurt reviewed Jul 31, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 31, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 31, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 31, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 31, 2019
View reviewed changes
@dvd42 dvd42 force-pushed the segmentation-module branch from a5d1a4f to 5358ab7 Compare July 31, 2019 08:06
@dvd42
Copy link
Copy Markdown
Contributor Author

dvd42 commented Jul 31, 2019

@dkurt, done

dkurt
dkurt reviewed Aug 1, 2019
View reviewed changes
@dvd42 dvd42 force-pushed the segmentation-module branch 2 times, most recently from e513e8a to 98ff328 Compare August 4, 2019 15:38
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Aug 5, 2019

@dvd42, Can you please squash all the commits into a single one?

@dvd42 dvd42 force-pushed the segmentation-module branch from 98ff328 to def58b5 Compare August 5, 2019 07:02
@dvd42
Copy link
Copy Markdown
Contributor Author

dvd42 commented Aug 5, 2019

@dkurt, done

@dvd42 dvd42 force-pushed the segmentation-module branch from 6df63c9 to 87a9d7e Compare August 6, 2019 13:56
dkurt
dkurt reviewed Aug 7, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 7, 2019
View reviewed changes
@dvd42 dvd42 force-pushed the segmentation-module branch 8 times, most recently from 2b86137 to 38ed410 Compare August 9, 2019 14:56
dkurt
dkurt reviewed Aug 9, 2019
View reviewed changes
@dvd42 dvd42 force-pushed the segmentation-module branch 2 times, most recently from 37ad312 to 417039b Compare August 10, 2019 12:11
dkurt
dkurt reviewed Aug 10, 2019
View reviewed changes
@dvd42 dvd42 force-pushed the segmentation-module branch from 7adfe42 to 019d050 Compare August 10, 2019 12:27
@dvd42 dvd42 force-pushed the segmentation-module branch from 49c40bb to 64e4fae Compare August 10, 2019 13:56
dkurt
dkurt approved these changes Aug 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good. There were only warning on Mac builder which is not connected to this PR: https://pullrequest.opencv.org/buildbot/builders/precommit_custom_mac/builds/197

/build/precommit_custom_mac/opencv/modules/core/test/test_ptr.cpp:167:12: warning: explicitly assigning value of variable of type 'Ptr<opencv_test::(anonymous namespace)::(anonymous namespace)::Reporter>' to itself [-Wself-assign-overloaded]

@dkurt dkurt self-assigned this Aug 13, 2019
@alalek alalek merged commit f7f2438 into opencv:master Aug 13, 2019
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@dvd42
Merge pull request opencv#15082 from dvd42:segmentation-module
710971d 
Segmentation module (opencv#15082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn feature GSoC

Projects

None yet

Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@dvd42 @dkurt @mshabunin @alalek