Skip to content

Add high level API#14780

Merged
mshabunin merged 26 commits intoopencv:masterfrom
l-bat:high_level_API
Jul 30, 2019
Merged

Add high level API#14780
mshabunin merged 26 commits intoopencv:masterfrom
l-bat:high_level_API

Conversation

@l-bat
Copy link
Copy Markdown
Contributor

@l-bat l-bat commented Jun 11, 2019

Related: #14580

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r1:16.04
build_image:Custom Win=openvino-2019r1
build_image:Custom Mac=openvino-2019r1

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

@l-bat l-bat force-pushed the high_level_API branch 2 times, most recently from e04b835 to 5406979 Compare June 11, 2019 11:37
@dkurt dkurt added this to the 4.x milestone Jun 28, 2019
@bhack
Copy link
Copy Markdown

bhack commented Jul 15, 2019

When do you plan to merge this? There is a new PR that needs these changes.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 15, 2019

@bhack, We decided to merge it after coming release. This PR contains major changes and it's better to debug it between two OpenCV versions.

You can rebase your branch with these changes and refer this PR.

@bhack
Copy link
Copy Markdown

bhack commented Jul 16, 2019

If you can push this branch in Opencv the student could open a PR on this branch.

@dvd42
Copy link
Copy Markdown
Contributor

dvd42 commented Jul 17, 2019

Yes, as @bhack said, I would like to open a PR that depends on this one. I have added a generation and segmentation module to the API and It would be great if I could get the PRs reviewed as soon as possible so I can adapt/fix them if necessary

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 17, 2019

@dvd42, @bhack, there is no technical problem to do that:

git remote add l-bat https://github.com/l-bat/opencv
git fetch l-bat high_level_API
git checkout high_level_API
git rebase high_level_API your_branch
git push your_fork your_branch

@bhack
Copy link
Copy Markdown

bhack commented Jul 17, 2019

Is not that the case. The scope was to open a github PR with the minimal diff here. If not Diego will need to open on l-bat github fork but probably nobody will review there.

@mshabunin
Copy link
Copy Markdown
Contributor

@bhack , @dkurt meant that Diego can make changes on top of commits from this PR and include it in theirs PR to the main repository (opencv/opencv). After this PR is merged, these commits will be hidden from Diego's PR.

Now:
  #14780 - commitA, commitB
  #<new PR> - commitA, commitB, commitX

After #14780 is merged:
  #14780 - closed
  #<new PR> - commitX

We can help with rebasing if you have any troubles.

@bhack
Copy link
Copy Markdown

bhack commented Jul 17, 2019

Yes I know but I meant can you review also if the PR has comittA and commitB in the diff and it is not so clean?
If you can push the branch in this repo it could be easier to review cause the diff will be minimized.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 17, 2019

@bhack, Yes, it's not a problem to review the changes.

This was referenced Jul 18, 2019
@dvd42
Copy link
Copy Markdown
Contributor

dvd42 commented Jul 18, 2019

I created 2 PRs, from my fork against opencv/master adding a generation and segmentation module

Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great job! Let's merge it.

@dvd42 dvd42 mentioned this pull request Jul 30, 2019
@dvd42
Copy link
Copy Markdown
Contributor

dvd42 commented Jul 30, 2019

I created 1 PR for this module, from my fork against opencv/master adding a keypoints module. This module raises the problem that G-API is trying to fix by integrating detection and landmarking into one pipeline. Maybe we could do something similar for this high-level API, by concatenating modules?

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 30, 2019

@dvd42, Maybe yes but not now. We need to solve current issue first.

@mshabunin mshabunin assigned mshabunin and unassigned dkurt Jul 30, 2019
@mshabunin mshabunin merged commit 778f42a into opencv:master Jul 30, 2019
dvd42 pushed a commit to dvd42/opencv that referenced this pull request Aug 6, 2019
* Add high level API

* Fix Model

* Add DetectionModel

* Add ClassificationModel

* Fix classify

* Add python test

* Fix pytest

* Fix comments to review

* Fix detect

* Fix docs

* Modify DetectionOutput postprocessing

* Fix test

* Extract ref boxes

* Fix draw rect

* fix test

* Add rect wrap

* Fix wrap

* Fix detect

* Fix Rect wrap

* Fix OCL_FP16

* Fix MyriadX

* Fix nms

* Fix NMS

* Fix coords
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
* Add high level API

* Fix Model

* Add DetectionModel

* Add ClassificationModel

* Fix classify

* Add python test

* Fix pytest

* Fix comments to review

* Fix detect

* Fix docs

* Modify DetectionOutput postprocessing

* Fix test

* Extract ref boxes

* Fix draw rect

* fix test

* Add rect wrap

* Fix wrap

* Fix detect

* Fix Rect wrap

* Fix OCL_FP16

* Fix MyriadX

* Fix nms

* Fix NMS

* Fix coords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants