Conversation
e04b835 to
5406979
Compare
|
When do you plan to merge this? There is a new PR that needs these changes. |
|
@bhack, We decided to merge it after coming release. This PR contains major changes and it's better to debug it between two OpenCV versions. You can rebase your branch with these changes and refer this PR. |
|
If you can push this branch in Opencv the student could open a PR on this branch. |
|
Yes, as @bhack said, I would like to open a PR that depends on this one. I have added a generation and segmentation module to the API and It would be great if I could get the PRs reviewed as soon as possible so I can adapt/fix them if necessary |
|
Is not that the case. The scope was to open a github PR with the minimal diff here. If not Diego will need to open on l-bat github fork but probably nobody will review there. |
|
@bhack , @dkurt meant that Diego can make changes on top of commits from this PR and include it in theirs PR to the main repository (opencv/opencv). After this PR is merged, these commits will be hidden from Diego's PR. We can help with rebasing if you have any troubles. |
|
Yes I know but I meant can you review also if the PR has comittA and commitB in the diff and it is not so clean? |
|
@bhack, Yes, it's not a problem to review the changes. |
|
I created 2 PRs, from my fork against opencv/master adding a generation and segmentation module |
|
@dvd42, Maybe yes but not now. We need to solve current issue first. |
* Add high level API * Fix Model * Add DetectionModel * Add ClassificationModel * Fix classify * Add python test * Fix pytest * Fix comments to review * Fix detect * Fix docs * Modify DetectionOutput postprocessing * Fix test * Extract ref boxes * Fix draw rect * fix test * Add rect wrap * Fix wrap * Fix detect * Fix Rect wrap * Fix OCL_FP16 * Fix MyriadX * Fix nms * Fix NMS * Fix coords
* Add high level API * Fix Model * Add DetectionModel * Add ClassificationModel * Fix classify * Add python test * Fix pytest * Fix comments to review * Fix detect * Fix docs * Modify DetectionOutput postprocessing * Fix test * Extract ref boxes * Fix draw rect * fix test * Add rect wrap * Fix wrap * Fix detect * Fix Rect wrap * Fix OCL_FP16 * Fix MyriadX * Fix nms * Fix NMS * Fix coords
Related: #14580