Skip to content

Support ONNX "ReduceMean" Layer#15032

Merged
alalek merged 7 commits intoopencv:3.4from
l-bat:reduce_mean
Jul 19, 2019
Merged

Support ONNX "ReduceMean" Layer#15032
alalek merged 7 commits intoopencv:3.4from
l-bat:reduce_mean

Conversation

@l-bat
Copy link
Copy Markdown
Contributor

@l-bat l-bat commented Jul 12, 2019 •
edited by alalek
Loading

Related: #14812
Merge with extra: opencv/opencv_extra#634

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r1:16.04
build_image:Custom Win=openvino-2019r1
build_image:Custom Mac=openvino-2019r1

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-2
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

@l-bat l-bat force-pushed the reduce_mean branch 2 times, most recently from 661116e to c7d2c46 Compare July 16, 2019 09:29
dkurt
dkurt reviewed Jul 16, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 16, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 16, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 17, 2019
View reviewed changes
dkurt
dkurt reviewed Jul 17, 2019
View reviewed changes
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 18, 2019

May I ask you to check failed test with Myriad? https://pullrequest.opencv.org/buildbot/builders/precommit_custom_linux/builds/2379. We can skip it now or try to fix if it's possible.

[ RUN      ] Test_TensorFlow_layers.Split/1, where GetParam() = DLIE/MYRIAD
/build/precommit_custom_linux/3.4/opencv/modules/dnn/test/test_common.impl.hpp:63: Failure
Expected: (normL1) <= (l1), actual: 0.29697 vs 0.004
/build/precommit_custom_linux/3.4/opencv/modules/dnn/test/test_common.impl.hpp:66: Failure
Expected: (normInf) <= (lInf), actual: 1.20457 vs 0.02

dkurt
dkurt approved these changes Jul 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done! Thanks!

@dkurt dkurt self-assigned this Jul 19, 2019
@alalek alalek merged commit 781f4d4 into opencv:3.4 Jul 19, 2019
This was referenced Jul 19, 2019
Closed
Closed
@alalek alalek mentioned this pull request Jul 21, 2019
Merged
dvd42 pushed a commit to dvd42/opencv that referenced this pull request Aug 6, 2019
@l-bat @dvd42
Merge pull request opencv#15032 from l-bat:reduce_mean
7bf26a0 
* Added support for the ONNX "ReduceMean" Layer. (as this is the same as the GlobalAveragePool)

* Add ReduceMean test

* Fix ONNX importer

* Fix ReduceMean

* Add assert

* Split test

* Fix split test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn feature

Projects

None yet

Milestone

3.4.7

Development

Successfully merging this pull request may close these issues.

4 participants

@l-bat @dkurt @alalek @Aeroxander