Skip to content

Add support for ONNX "ReduceMean" Layer#14812

Closed
Aeroxander wants to merge 2 commits intoopencv:masterfrom
Aeroxander:master
Closed

Add support for ONNX "ReduceMean" Layer#14812
Aeroxander wants to merge 2 commits intoopencv:masterfrom
Aeroxander:master

Conversation

@Aeroxander
Copy link
Copy Markdown

resolves #14768

This pull request changes

Support for the ONNX ReduceMean Layer.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jun 15, 2019

@Aeroxander, Can you please add some test for it? You may check #14697 with opencv/opencv_extra#615 for reference.

Please also replace base branch to 3.4

@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 15, 2019

Merge branch 'master' of https://github.com/opencv/opencv

Please avoid "merge" commits from the patch. Use git rebasing on the top of target branch instead.
Merge commits over-complicates patch, make review complex and may break GitHub reviewing tool.

They may break rebasing onto a current maintenance branch - "3.4".

@Aeroxander
Copy link
Copy Markdown
Author

Got it, will solve both issues as soon as I can, it might take a while cause I'm in a hurry of also adding other missing layers.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 19, 2019

We merged this PR as a part of #15032. Thanks!

@dkurt dkurt closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Mean layer (Can't create layer "34" of type "ReduceMean")

3 participants