G-API: clean up accuracy tests#14945
Merged
alalek merged 16 commits intoopencv:masterfrom Jul 16, 2019
Merged
Conversation
Update the way compile args function is created Fix instantiation suffix print function
Member
Author
dmatveev
reviewed
Jul 2, 2019
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
Do we have a follow-up task on testing the output data allocation in our JIRA?
Member
Author
|
@dmatveev please see updated version Regarding:
-- I plan to add it to JIRA and do separately |
Member
Author
rgarnov
reviewed
Jul 9, 2019
Member
Author
|
@dmatveev please look into this |
Member
Author
dmatveev
reviewed
Jul 11, 2019
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
Nice, but some system-sensitive stuff like desc() can be improved.
Thanks!
dmatveev
reviewed
Jul 15, 2019
Member
Author
|
@dmatveev updated, please look |
Contributor
|
Thanks! |
Member
Author
|
@alalek I believe this PR is done, please merge |
Member
Author
|
Thanks! |
dvd42
pushed a commit
to dvd42/opencv
that referenced
this pull request
Aug 6, 2019
G-API: clean up accuracy tests (opencv#14945) * Delete createOutputMatrices flag Update the way compile args function is created Fix instantiation suffix print function * Update comment (NB) * Make printable comparison functions * Use defines instead of objects for compile args * Remove custom printers, use operator<< overload * Remove SAME_TYPE and use -1 instead * Delete createOutputMatrices flag in new tests * Fix GetParam() printed values * Update Resize tests: use CompareF object * Address code review feedback * Add default cases for operator<< overloads * change throw to GAPI_Assert
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
G-API: clean up accuracy tests (opencv#14945) * Delete createOutputMatrices flag Update the way compile args function is created Fix instantiation suffix print function * Update comment (NB) * Make printable comparison functions * Use defines instead of objects for compile args * Remove custom printers, use operator<< overload * Remove SAME_TYPE and use -1 instead * Delete createOutputMatrices flag in new tests * Fix GetParam() printed values * Update Resize tests: use CompareF object * Address code review feedback * Add default cases for operator<< overloads * change throw to GAPI_Assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest
operator<<overloading:CV_8Uprinted as "CV_8U" instead of "0"NormTypes::NORM_INFprinted as "NORM_INF"AbsTolerance(1)printed as "AbsTolerance(1)" instead of "compare_f"