G-API: Add output allocation tests for backends#15012
Merged
alalek merged 7 commits intoopencv:masterfrom Jul 16, 2019
Merged
Conversation
Member
Author
|
@dmatveev please see the initial version. I see some failures locally with certain tests, so let's discuss the actual working scenarios separately |
Contributor
|
@andrey-golubev please align it with the team first, not me. My usefulness for things like this is highly overrated :) |
dmatveev
reviewed
Jul 15, 2019
Contributor
dmatveev
left a comment
There was a problem hiding this comment.
👍
Cases are nice, all we need is to fix wording probably (and make checks more illustrative)
Update test names Add illustrative "expect (non-)empty" checks Rename mat "copy" to mat reference Add more pointer checks
Member
Author
|
Thanks! |
dvd42
pushed a commit
to dvd42/opencv
that referenced
this pull request
Aug 6, 2019
G-API: Add output allocation tests for backends (opencv#15012) * Add output tests for backends * Fix large size test: output is in fact reallocated * Use cv::Mat copies for reallocation tracking * Separate LargeSizeWithCorrectSubmatrix test * Rename backed output allocation tests * Address code review feedback Update test names Add illustrative "expect (non-)empty" checks Rename mat "copy" to mat reference Add more pointer checks * Add illustrative checks
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
G-API: Add output allocation tests for backends (opencv#15012) * Add output tests for backends * Fix large size test: output is in fact reallocated * Use cv::Mat copies for reallocation tracking * Separate LargeSizeWithCorrectSubmatrix test * Rename backed output allocation tests * Address code review feedback Update test names Add illustrative "expect (non-)empty" checks Rename mat "copy" to mat reference Add more pointer checks * Add illustrative checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest
adds tests for output allocation for all backends