Avoid using v_signmask universal intrinsic and mark it as deprecated#14916
Merged
alalek merged 2 commits intoopencv:3.4from Jul 1, 2019
Merged
Avoid using v_signmask universal intrinsic and mark it as deprecated#14916alalek merged 2 commits intoopencv:3.4from
alalek merged 2 commits intoopencv:3.4from
Conversation
6428a30 to
682890f
Compare
682890f to
cdc3a68
Compare
alalek
reviewed
Jun 28, 2019
| int idx = v_heading_zeros(r); // idx = 2 | ||
| @endcode | ||
| */ | ||
| template <typename _Tp, int n> inline int v_find_negative(const v_reg<_Tp, n>& a) |
Member
There was a problem hiding this comment.
What is about these names?
v_find_non_zero()v_scan_non_zero()v_scan_forward()v_scan()
| inline int v_find_negative(const v_float32x4& a) { return trailingZeros32(v_signmask(a)); } | ||
| #if CV_SIMD128_64F | ||
| inline int v_find_negative(const v_int64x2& a) { return trailingZeros32(v_signmask(a)); } | ||
| inline int v_find_negative(const v_uint64x2& a) { return trailingZeros32(v_signmask(a)); } |
Member
There was a problem hiding this comment.
It is strange that CV_SIMD128_64F blocks int64 / uint64 processing.
7330d59 to
5218736
Compare
5218736 to
d0c8520
Compare
Merged
AhiyaHiya
added a commit
to AhiyaHiya/opencv
that referenced
this pull request
Jul 7, 2019
* master: (74 commits) Merge pull request opencv#14917 from rgarnov:gapi_planar_kernels Fixed initUndistortRectifyMap AVX2 implementation Merge pull request opencv#14959 from dvd42:onnx_clip videoio: eliminate build warnings (clang) ts: runtime check for misused 'optional' test data files 3rdparty(itt): support AARCH64 tensroflow support maxpoolgrad Fix blob detector insertion sort Fix crash, add assert and test Merge pull request opencv#14946 from andrey-golubev:obj_not_ref re-enable CPU_BASELINE=FP16 on Armv7 platform Merge pull request opencv#14828 from armenpoghosov:parmen_RANSACPointSetRegistrator_getSubset_disaster_cleanup Merge pull request opencv#14916 from terfendail:wsignmask_deprecated core: evaluate CV_Error() parameters during static scans dnn: fix build with Vulkan Merge pull request opencv#14936 from StefanBruens:crosscorr_cleanup Explicitly default operator= for Vec<T, n> Fix JS sample of dnn 3rdparty: TBB version 2018u1 => 2019u8 cmake: support rpath-link linker option ...
Contributor
|
Why are we deprecating v_signmask? It's a useful instruction. I don't agree changing the flags to a char array is the best here. |
Member
|
There is "wide universal intrinsics (w.u.i.)" API over SIMD128 / SIMD256 / SIMD512 (depends on current compilation flags). So we are trying to unify APIs if possible (however it doesn't work well for reductions). v_signmask() in case of SIMD512 doesn't fit well into 32-bit int (u8 x 64 elements). |
Contributor
|
BTW, IMO v_signmask should return an 'unsigned int' and not an 'int' |
arnaudbrejeon
pushed a commit
to arnaudbrejeon/opencv
that referenced
this pull request
Jan 23, 2020
* Avoid using v_signmask universal intrinsic and mark it as deprecated * Renamed v_find_negative to v_scan_forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
Avoid using v_signmask universal intrinsic and mark it as deprecated