Parmen ransac point set registrator get subset disaster cleanup#14828
Merged
alalek merged 3 commits intoopencv:3.4from Jul 1, 2019
Merged
Conversation
Contributor
Author
|
Nobody wants to review? |
Member
|
Looks good to me. This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
3e03afe to
ae34374
Compare
alalek
approved these changes
Jul 1, 2019
Merged
AhiyaHiya
added a commit
to AhiyaHiya/opencv
that referenced
this pull request
Jul 7, 2019
* master: (74 commits) Merge pull request opencv#14917 from rgarnov:gapi_planar_kernels Fixed initUndistortRectifyMap AVX2 implementation Merge pull request opencv#14959 from dvd42:onnx_clip videoio: eliminate build warnings (clang) ts: runtime check for misused 'optional' test data files 3rdparty(itt): support AARCH64 tensroflow support maxpoolgrad Fix blob detector insertion sort Fix crash, add assert and test Merge pull request opencv#14946 from andrey-golubev:obj_not_ref re-enable CPU_BASELINE=FP16 on Armv7 platform Merge pull request opencv#14828 from armenpoghosov:parmen_RANSACPointSetRegistrator_getSubset_disaster_cleanup Merge pull request opencv#14916 from terfendail:wsignmask_deprecated core: evaluate CV_Error() parameters during static scans dnn: fix build with Vulkan Merge pull request opencv#14936 from StefanBruens:crosscorr_cleanup Explicitly default operator= for Vec<T, n> Fix JS sample of dnn 3rdparty: TBB version 2018u1 => 2019u8 cmake: support rpath-link linker option ...
arnaudbrejeon
pushed a commit
to arnaudbrejeon/opencv
that referenced
this pull request
Jan 23, 2020
…SetRegistrator_getSubset_disaster_cleanup Parmen ransac point set registrator get subset disaster cleanup (opencv#14828)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
does not resolve any issue - just cleans up the code
This pullrequest changes
getSubset function code contains a lot of nonsense like:
iters < maxAttempt in inner loop
if( i == modelPoints && !cb ... in inner loop
and needs some cleanup :)