Restored function to rescale pixel values before imshow#13264
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Nov 28, 2018
Merged
Restored function to rescale pixel values before imshow#13264opencv-pushbot merged 1 commit intoopencv:masterfrom
opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
berak
reviewed
Nov 24, 2018
modules/highgui/src/precomp.hpp
Outdated
| cv::convertScaleAbs(src, tmp, 256.); | ||
| break; | ||
| } | ||
| cv::cvtColor(tmp, dst, cv::COLOR_BGR2RGB, dst.channels()); |
Contributor
There was a problem hiding this comment.
unfortunately, windows needs BGR pixel order
a8283d6 to
b4c7e4e
Compare
3abc684 to
db1c8b3
Compare
Contributor
Author
|
I've added BGR image and verified all 4 backends (GTK and Qt on Linux, Mac, Win) visually. Separated trackbar test and disabled it on Mac: callback does not get called in the test while sample apps work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #13216
related #13184
This pullrequest changes
imshow