highgui: Qt - restore convertscale semantics#13184
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Nov 16, 2018
Merged
highgui: Qt - restore convertscale semantics#13184opencv-pushbot merged 1 commit intoopencv:masterfrom
opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
mshabunin
reviewed
Nov 16, 2018
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
Probably we will need to make similar changes in other places (e.g. window_w32.cpp or window_cocoa.mm).
Can we extend highgui test to catch other similar issues?
alalek
approved these changes
Nov 16, 2018
dan-masek
reviewed
Nov 20, 2018
| int src_depth = src.depth(); | ||
| double scale = src_depth <= CV_8S ? 1 : src_depth <= CV_32S ? 1./256 : 255; | ||
| double shift = src_depth == CV_8S || src_depth == CV_16S ? 128 : 0; | ||
| cv::convertScaleAbs(src, tmp, scale, shift); |
Contributor
There was a problem hiding this comment.
Shouldn't this just be called when scaling/shifting/conversion actually needs to be done? AFAICT in such cases the function still processes the whole image, which seems wasteful when unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broken in 11eafca