Replace 'base image' with 'base layer'#312
Replace 'base image' with 'base layer'#312coolljt0725 wants to merge 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: Lei Jitang <leijitang@huawei.com>
|
can we link to the part of layer.md where we actually define base layer? |
|
agree with @jonboulle |
|
On Wed, Sep 14, 2016 at 04:34:51AM -0700, Jonathan Boulle wrote:
Which part of layer.md is that? The definition seems to be spread |
|
https://github.com/opencontainers/image-spec/blob/master/layer.md#initial-root-filesystem The document does need a rework for clarity |
|
On Thu, Sep 15, 2016 at 09:54:26AM -0700, Jonathan Boulle wrote:
It just was (#255 ;), and I'm fairly happy with the current layout. There's nothing special about layers[0] vs. the other layers. We just |
|
@wking I'm lost, can you just put up an alternative PR to this one with your suggestion please? my point is that "The array MUST have the base layer at index 0." currently has just about no meaning. |
|
On Fri, Sep 16, 2016 at 09:34:48AM -0700, Jonathan Boulle wrote:
Done with #318.
Agreed, and I also agree with your “we should allow empty layers[] |
|
I think this is being better addressed in #318 |
We doesn't define a `base image`, use `base layer` is correct. This issue first being addressed in pr opencontainers#312, and then being addressed in pr opencontainers#318, and then in pr opencontainers#407, but landing opencontainers#407 has a long way to go. We could addressed this first to avoid confusing. Signed-off-by: Lei Jitang <leijitang@huawei.com>
Signed-off-by: Lei Jitang leijitang@huawei.com
base imagehere is misleading, we should usebase layer