image: manifest.go: remove empty layers check#308
Closed
runcom wants to merge 1 commit intoopencontainers:masterfrom
Closed
image: manifest.go: remove empty layers check#308runcom wants to merge 1 commit intoopencontainers:masterfrom
runcom wants to merge 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Contributor
|
5fd27f2 looks good to me.
|
Contributor
|
Actually, we probably want to also drop “one or more” [1,2], although |
This was referenced Sep 14, 2016
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a discrepancy between
oci-image-tool, internal schema tests (https://github.com/opencontainers/image-spec/blob/master/schema/manifest_test.go#L51) and the spec itself (https://github.com/opencontainers/image-spec/blob/master/manifest.md#image-manifest-property-descriptions). Schema tests and the spec don't require a not empty layers array whileoci-image-toolis erroring out on an empty layers array.Signed-off-by: Antonio Murdaca runcom@redhat.com