*: rename serialization.md -> config.md by vbatts · Pull Request #305 · opencontainers/image-spec

vbatts · 2016-09-13T19:15:42Z

Closes: #283

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

jonboulle · 2016-09-13T19:16:38Z

schema/spec_test.go

@@ -42,7 +42,7 @@ func TestValidateManifest(t *testing.T) {
 }

 func TestValidateSerialization(t *testing.T) {


stevvooe · 2016-09-13T19:18:56Z

LGTM

Thanks!

stevvooe · 2016-09-13T20:22:40Z

@vbatts Looks like there are some whitespace problems.

vbatts · 2016-09-13T21:09:24Z

fixed. Not sure why newer git is not detecting these. It's a bit frustrating. :-\

wking · 2016-09-13T21:09:40Z

image-layout.md

 The OCI Image Layout is a slash separated layout of OCI content-addressable blobs and [location-addressable](https://en.wikipedia.org/wiki/Content-addressable_storage#Content-addressed_vs._location-addressed) references (refs).
 This layout MAY be used in a variety of different transport mechanisms: archive formats (e.g. tar, zip), shared filesystem environments (e.g. nfs), or networked file fetching (e.g. http, ftp, rsync).
-Given an image layout a tool can convert a given ref into a runnable OCI Image Format by finding an appropriate manifest from the manifest list, unpacking the filesystem serializations in the correct order, and then converting the image configuration into an OCI Runtime config.json.
+Given an image layout a tool can convert a given ref into a runnable OCI Image Format by finding an appropriate manifest from the manifest list, unpacking the [filesystem layers](./layer.md) in the correct order, and then converting the image configuration into an OCI Runtime config.json.


No need for ./, just use [filesystem layers](layer.md).

we've been through this. This is for explicit relative path. It's not a rule, but many tools rely on such to determine that it is a relative path.

On Tue, Sep 13, 2016 at 02:12:47PM -0700, Vincent Batts wrote:

-Given an image layout a tool can convert a given ref into a runnable OCI Image Format by finding an appropriate manifest from the manifest list, unpacking the filesystem serializations in the correct order, and then converting the image configuration into an OCI Runtime config.json.
+Given an image layout a tool can convert a given ref into a runnable OCI Image Format by finding an appropriate manifest from the manifest list, unpacking the filesystem layers in the correct order, and then converting the image configuration into an OCI Runtime config.json.

we've been through this. This is for explicit relative path. It's
not a rule, but many tools rely on such to determine that it is a
relative path.

Can you point to such a tool? If we want to require explicit ./,
we'll want a new PR to update many existing links.

go build

On Tue, Sep 13, 2016 at 5:23 PM W. Trevor King notifications@github.com
wrote:

In image-layout.md
#305 (comment)
:

@@ -2,7 +2,7 @@

The OCI Image Layout is a slash separated layout of OCI content-addressable blobs and location-addressable references (refs).
This layout MAY be used in a variety of different transport mechanisms: archive formats (e.g. tar, zip), shared filesystem environments (e.g. nfs), or networked file fetching (e.g. http, ftp, rsync).
-Given an image layout a tool can convert a given ref into a runnable OCI Image Format by finding an appropriate manifest from the manifest list, unpacking the filesystem serializations in the correct order, and then converting the image configuration into an OCI Runtime config.json.
+Given an image layout a tool can convert a given ref into a runnable OCI Image Format by finding an appropriate manifest from the manifest list, unpacking the filesystem layers in the correct order, and then converting the image configuration into an OCI Runtime config.json.

On Tue, Sep 13, 2016 at 02:12:47PM -0700, Vincent Batts wrote: > -Given an
image layout a tool can convert a given ref into a runnable OCI Image
Format by finding an appropriate manifest from the manifest list, unpacking
the filesystem serializations in the correct order, and then converting the
image configuration into an OCI Runtime config.json. > +Given an image
layout a tool can convert a given ref into a runnable OCI Image Format by
finding an appropriate manifest from the manifest list, unpacking the
filesystem layers in the correct order, and then converting
the image configuration into an OCI Runtime config.json. we've been through
this. This is for explicit relative path. It's not a rule, but many tools
rely on such to determine that it is a relative path.
Can you point to such a tool? If we want to require explicit ./, we'll
want a new PR to update many existing links.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/image-spec/pull/305/files/7457e6cfb9e8a70e0c0823e7b2ffc24d5b0ca3ab#r78647065,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6f8oGVRuL5XudyYAc_obJhwUnV2fks5qpxQ9gaJpZM4J8CpQ
.

On Tue, Sep 13, 2016 at 02:24:45PM -0700, Vincent Batts wrote:

-Given an image layout a tool can convert a given ref into a runnable OCI Image Format by finding an appropriate manifest from the manifest list, unpacking the filesystem serializations in the correct order, and then converting the image configuration into an OCI Runtime config.json.
+Given an image layout a tool can convert a given ref into a runnable OCI Image Format by finding an appropriate manifest from the manifest list, unpacking the filesystem layers in the correct order, and then converting the image configuration into an OCI Runtime config.json.

go build

‘go build’ parses this Markdown?

wking · 2016-09-13T21:10:38Z

manifest.md


    This REQUIRED property references a configuration object for a container, by digest.
-    The referenced configuration object is a JSON blob that the runtime uses to set up the container, see [Image JSON Description](serialization.md#image-json-description).
+    The referenced configuration object is a JSON blob that the runtime uses to set up the container, see [Image JSON Description](config.md#image-json-description).


Now that the files are split, we may want to drop the fragment here. If config.md is so big that you want to link to a subsection as the spec for the format, we should probably trim config.md ;).

wking · 2016-09-13T21:17:05Z

config.md

@@ -61,7 +61,7 @@ This specification uses the following terms:
 Here is an example image JSON file:


Update the title to:

Image Configuration

Closes: opencontainers#283 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

wking · 2016-09-13T21:24:30Z

config.md

 </dl>

-## Image JSON Description
+## Image Configuration


I meant the H1 at the top of this file. This whole file is about that configuration, right?

jonboulle · 2016-09-14T10:12:40Z

LGTM, thank you

stevvooe · 2016-09-14T19:45:47Z

LGTM

This didn't make it into 17c1f00 (*: rename serialization.md -> config.md, 2016-09-13, opencontainers#305), but I think we still want it [1,2,3]. While I was touching headers, I shifted the informative example section down under the normative property definitions, and move the normative whitespace rule up out of the example section. [1]: opencontainers#255 (comment) [2]: opencontainers#305 (comment) [3]: opencontainers#305 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>

This didn't make it into 17c1f000 (*: rename serialization.md -> config.md, 2016-09-13, #305), but I think we still want it [1,2,3]. While I was touching headers, I shifted the informative example section down under the normative property definitions, and move the normative whitespace rule up out of the example section. [1]: opencontainers/image-spec#255 (comment) [2]: opencontainers/image-spec#305 (comment) [3]: opencontainers/image-spec#305 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>

vbatts mentioned this pull request Sep 13, 2016

rename serialization.md to config.md #283

Closed

jonboulle reviewed Sep 13, 2016
View reviewed changes

vbatts force-pushed the rename branch from ef7efda to ee20e57 Compare September 13, 2016 19:47

vbatts force-pushed the rename branch from ee20e57 to 7457e6c Compare September 13, 2016 21:08

wking reviewed Sep 13, 2016
View reviewed changes

wking mentioned this pull request Sep 13, 2016

image: manifest.go: remove empty layers check #308

Closed

wking reviewed Sep 13, 2016
View reviewed changes

vbatts force-pushed the rename branch from 7457e6c to 55fd90e Compare September 13, 2016 21:15

wking reviewed Sep 13, 2016
View reviewed changes

vbatts force-pushed the rename branch 2 times, most recently from 678aac7 to 5f8edee Compare September 13, 2016 21:19

*: rename serialization.md -> config.md

17c1f00

Closes: opencontainers#283 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

vbatts force-pushed the rename branch from 5f8edee to 17c1f00 Compare September 13, 2016 21:21

wking reviewed Sep 13, 2016
View reviewed changes

stevvooe merged commit 55a3d9e into opencontainers:master Sep 14, 2016

wking mentioned this pull request Sep 14, 2016

config: Fix "Serialization" -> "Configuration" in the title #315

Merged

vbatts deleted the rename branch September 19, 2016 15:16

wking mentioned this pull request Sep 22, 2016

manifest: List media types supported by descriptor references #304

Merged

		@@ -42,7 +42,7 @@ func TestValidateManifest(t *testing.T) {
		}

		func TestValidateSerialization(t *testing.T) {

		@@ -61,7 +61,7 @@ This specification uses the following terms:
		Here is an example image JSON file:

Conversation

vbatts commented Sep 13, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevvooe commented Sep 13, 2016 • edited by caniszczyk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevvooe commented Sep 13, 2016

Uh oh!

vbatts commented Sep 13, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Image Configuration

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonboulle commented Sep 14, 2016 • edited by caniszczyk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevvooe commented Sep 14, 2016 • edited by caniszczyk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

stevvooe commented Sep 13, 2016 •

edited by caniszczyk

Loading

jonboulle commented Sep 14, 2016 •

edited by caniszczyk

Loading

stevvooe commented Sep 14, 2016 •

edited by caniszczyk

Loading