fix(mcp): repair OAuth redirect, errors, and unicode schema patterns#91451
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 8, 2026, 8:47 PM ET / 00:47 UTC. Summary PR surface: Source +121, Tests +145. Total +266 across 6 files. Reproducibility: yes. for the PR-introduced defect by source inspection: the fallback writes redirectUrl before the second auth attempt, and runMcpOAuthLogin reads that store value for later unconfigured logins. I did not run the full CLI OAuth flow because this is a read-only review and live credentials are not available. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep the legacy default and explicit oauth.redirectUrl override, retry with localhost in memory, persist localhost only after the retry succeeds, then require redacted live CLI proof or explicit maintainer acceptance before merge. Do we have a high-confidence way to reproduce the issue? Yes for the PR-introduced defect by source inspection: the fallback writes redirectUrl before the second auth attempt, and runMcpOAuthLogin reads that store value for later unconfigured logins. I did not run the full CLI OAuth flow because this is a read-only review and live credentials are not available. Is this the best way to solve the issue? No as written; the PR uses the right owner path, but the redirect store update should be conditional on a successful fallback attempt. The response wrapping and schema-pattern repair are plausible narrow fixes after dependency/source inspection. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 5b76436c452a. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +121, Tests +145. Total +266 across 6 files. View PR surface stats
Security concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Follow-up pushed addressing ClawSweeper review:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Second follow-up (
Tests added/updated:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
PR follow-up status on
@clawsweeper re-review |
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
Fixes openclaw#91433 Co-authored-by: Cursor <cursoragent@cursor.com>
Preserve 127.0.0.1 default, retry DCR with localhost on rejection, fix lint no-new probes, and test body-less OAuth error responses. Co-authored-by: Cursor <cursoragent@cursor.com>
Persist localhost redirect after DCR fallback so --code exchange matches, and read body-less foreign response text before SDK error parsing. Co-authored-by: Cursor <cursoragent@cursor.com>
564eac4 to
967d448
Compare
|
Maintainer fixes and pre-merge proof are complete. Autoreview found and this branch now fixes:
Verification on head
Broad remote proof gap: Crabbox Azure exhausted regional core quota/capacity; Blacksmith fallback is unavailable because the |
…penclaw#91451) * fix(mcp): repair OAuth redirect, errors, and unicode schema patterns Fixes openclaw#91433 Co-authored-by: Cursor <cursoragent@cursor.com> * fix(mcp): address PR review on redirect compat and OAuth errors Preserve 127.0.0.1 default, retry DCR with localhost on rejection, fix lint no-new probes, and test body-less OAuth error responses. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(mcp): preserve OAuth redirect and error body text Persist localhost redirect after DCR fallback so --code exchange matches, and read body-less foreign response text before SDK error parsing. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(mcp): harden OAuth and schema normalization * fix(mcp): persist only successful OAuth fallback * fix(mcp): preserve OAuth retry state --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
…26.6.6) (#1040) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.6.5` → `2026.6.6` | --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.6.6`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#202666) [Compare Source](openclaw/openclaw@v2026.6.5...v2026.6.6) ##### Highlights - Security boundaries are substantially tighter across transcripts, sandbox binds, host environment inheritance, MCP stdio, Codex HTTP access, native search policy, elevated sender checks, deleted-agent ACP bypasses, loopback tools, Discord moderation, and Teams group actions; exec approvals now fail closed on timeout. ([#​91529](openclaw/openclaw#91529), [#​91618](openclaw/openclaw#91618), [#​91615](openclaw/openclaw#91615), [#​91619](openclaw/openclaw#91619), [#​91741](openclaw/openclaw#91741), [#​91745](openclaw/openclaw#91745), [#​91746](openclaw/openclaw#91746), [#​91748](openclaw/openclaw#91748), [#​91749](openclaw/openclaw#91749), [#​91750](openclaw/openclaw#91750), [#​91751](openclaw/openclaw#91751), [#​91752](openclaw/openclaw#91752), [#​91763](openclaw/openclaw#91763), [#​89938](openclaw/openclaw#89938)) Thanks [@​joshavant](https://github.com/joshavant), [@​pgondhi987](https://github.com/pgondhi987), [@​mmaps](https://github.com/mmaps), [@​eleqtrizit](https://github.com/eleqtrizit), [@​shakkernerd](https://github.com/shakkernerd), and [@​drobison00](https://github.com/drobison00). - Telegram delivery is safer and more coherent: account-scoped topics route to the right agent, streamed text survives tool calls, `/compact` works on generic ingress, callback handling uses concrete APIs, draft chunking is shared, durable dispatch dedupe moved into the SDK, and unauthorized DM text stays out of cache and prompt context. ([#​91189](openclaw/openclaw#91189), [#​88682](openclaw/openclaw#88682), [#​89588](openclaw/openclaw#89588), [#​90212](openclaw/openclaw#90212), [#​91876](openclaw/openclaw#91876), [#​91874](openclaw/openclaw#91874), [#​91904](openclaw/openclaw#91904), [#​91478](openclaw/openclaw#91478), [#​91915](openclaw/openclaw#91915)) Thanks [@​codysai001](https://github.com/codysai001), [@​alexzhu0](https://github.com/alexzhu0), [@​joelnishanth](https://github.com/joelnishanth), [@​snowzlm](https://github.com/snowzlm), [@​obviyus](https://github.com/obviyus), and [@​sallyom](https://github.com/sallyom). - iMessage recovery and delivery now cover always-on inbound restart, durable echo markers, block streaming, idle approval discovery, hardened outbound transport, and actionable inbound startup diagnostics. ([#​91335](openclaw/openclaw#91335), [#​91449](openclaw/openclaw#91449), [#​88969](openclaw/openclaw#88969), [#​88530](openclaw/openclaw#88530), [#​91783](openclaw/openclaw#91783), [#​91785](openclaw/openclaw#91785)) Thanks [@​omarshahine](https://github.com/omarshahine), [@​jmissig](https://github.com/jmissig), and [@​colmbrogan](https://github.com/colmbrogan). - Browser and MCP connectivity gained existing-session CDP support, discovered WebSocket validation, default-profile `cdpUrl` handling, safer browser-output boundaries, Streamable HTTP loopback transport, corrected OAuth/SSE authorization handling, and broader schema compatibility. ([#​91422](openclaw/openclaw#91422), [#​89851](openclaw/openclaw#89851), [#​91736](openclaw/openclaw#91736), [#​91747](openclaw/openclaw#91747), [#​91451](openclaw/openclaw#91451), [#​80143](openclaw/openclaw#80143)) Thanks [@​pgondhi987](https://github.com/pgondhi987), [@​anagnorisis2peripeteia](https://github.com/anagnorisis2peripeteia), [@​lifuyue](https://github.com/lifuyue), [@​eleqtrizit](https://github.com/eleqtrizit), [@​LiuwqGit](https://github.com/LiuwqGit), and [@​HemantSudarshan](https://github.com/HemantSudarshan). - Control UI startup and first-reply latency are lower through cached model metadata, removal of the startup catalog wait, lazy slash-command loading, and first-event tracing with slow-reply diagnostics. ([#​91531](openclaw/openclaw#91531), [#​91538](openclaw/openclaw#91538), [#​91568](openclaw/openclaw#91568), [#​91583](openclaw/openclaw#91583), [#​91598](openclaw/openclaw#91598)) - Provider support expands with OpenRouter OAuth onboarding and Claude Fable 5 adaptive thinking, while Codex sessions keep correct compaction ownership, local models skip guardian review, dynamic tool progress normalizes cleanly, and Gemma 4 reasoning replay is preserved. ([#​91830](openclaw/openclaw#91830), [#​91882](openclaw/openclaw#91882), [#​91590](openclaw/openclaw#91590), [#​88630](openclaw/openclaw#88630), [#​88768](openclaw/openclaw#88768), [#​91696](openclaw/openclaw#91696)) Thanks [@​Patrick-Erichsen](https://github.com/Patrick-Erichsen), [@​joshavant](https://github.com/joshavant), [@​bdjben](https://github.com/bdjben), and [@​Coder-Wangyankun](https://github.com/Coder-Wangyankun). ##### Changes - CLI progress: emit Claude CLI commentary progress events and bridge inter-tool commentary into channel progress without exposing internal protocol scaffolding. ([#​89834](openclaw/openclaw#89834), [#​90883](openclaw/openclaw#90883)) Thanks [@​anagnorisis2peripeteia](https://github.com/anagnorisis2peripeteia). - Observability: allow trusted diagnostics channels to capture tool input/output content, add first-assistant-event traces, and warn on slow initial replies. ([#​91256](openclaw/openclaw#91256), [#​91568](openclaw/openclaw#91568), [#​91583](openclaw/openclaw#91583)) Thanks [@​amknight](https://github.com/amknight). - Plugins/ClawHub: dogfood reusable package publishing, let dry runs skip publish approval, allow declared installed trusted hooks, report managed plugin version drift, and warn instead of failing on retired Skill Workshop configuration. ([#​91574](openclaw/openclaw#91574), [#​91591](openclaw/openclaw#91591), [#​90004](openclaw/openclaw#90004), [#​90927](openclaw/openclaw#90927), [#​90838](openclaw/openclaw#90838)) Thanks [@​Patrick-Erichsen](https://github.com/Patrick-Erichsen), [@​brokemac79](https://github.com/brokemac79), and [@​lonexreb](https://github.com/lonexreb). - Memory/providers: move the local llama.cpp runtime into its provider plugin, batch embeddings across files, persist the agent model catalog cache, and keep QMD JSON search one-shot while filtering stale REM recall previews. ([#​91324](openclaw/openclaw#91324), [#​89138](openclaw/openclaw#89138), [#​90457](openclaw/openclaw#90457), [#​91837](openclaw/openclaw#91837), [#​91851](openclaw/openclaw#91851)) Thanks [@​osolmaz](https://github.com/osolmaz), [@​mushuiyu886](https://github.com/mushuiyu886), [@​ai-hpc](https://github.com/ai-hpc), and [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - Channels/mobile: add the QQBot group mention toggle, improve iPad and iPhone control surfaces, and expose the active connection host in the TUI footer. ([#​91423](openclaw/openclaw#91423), [#​91557](openclaw/openclaw#91557), [#​89909](openclaw/openclaw#89909)) Thanks [@​cxyhhhhh](https://github.com/cxyhhhhh), [@​Solvely-Colin](https://github.com/Solvely-Colin), and [@​baskduf](https://github.com/baskduf). - Performance: prewarm TUI runtime plugins, deduplicate plugin auto-enable fanout, trim dense text-delta snapshots, and reuse prepared startup model metadata. ([#​90782](openclaw/openclaw#90782), [#​89978](openclaw/openclaw#89978), [#​91580](openclaw/openclaw#91580), [#​91531](openclaw/openclaw#91531)) Thanks [@​RomneyDa](https://github.com/RomneyDa) and [@​ai-hpc](https://github.com/ai-hpc). ##### Fixes - Agent/session recovery: drop stale approval follow-ups after session rebind, remove drained reply-queue items by identity, recover stale main and visible replies, preserve Codex context-engine compaction ownership, lower the default compaction timeout to 180 seconds while respecting explicit configuration, and keep provider-failure terminal lifecycle state correct. ([#​85679](openclaw/openclaw#85679), [#​91450](openclaw/openclaw#91450), [#​91566](openclaw/openclaw#91566), [#​91840](openclaw/openclaw#91840), [#​91590](openclaw/openclaw#91590), [#​91361](openclaw/openclaw#91361), [#​91895](openclaw/openclaw#91895)) Thanks [@​openperf](https://github.com/openperf), [@​yetval](https://github.com/yetval), [@​joshavant](https://github.com/joshavant), [@​wangmiao0668000666](https://github.com/wangmiao0668000666), and [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - User-visible content boundaries: suppress Codex/Harmony protocol artifacts, neutralize browser and LanceDB memory media directives, redact transcript images, and preserve native `/compact` replies through source suppression. ([#​89151](openclaw/openclaw#89151), [#​91422](openclaw/openclaw#91422), [#​91425](openclaw/openclaw#91425), [#​91529](openclaw/openclaw#91529), [#​90212](openclaw/openclaw#90212)) Thanks [@​joelnishanth](https://github.com/joelnishanth), [@​pgondhi987](https://github.com/pgondhi987), [@​joshavant](https://github.com/joshavant), and [@​snowzlm](https://github.com/snowzlm). - Channel delivery: keep WhatsApp captured replies attached to the successor controller after restart, retry Feishu rate limits, preserve Mattermost thread replies, canonicalize LINE webhook paths, restore Discord reply hydration and runtime timeout exports, and show OpenAI Realtime WebRTC assistant transcripts. ([#​85823](openclaw/openclaw#85823), [#​89659](openclaw/openclaw#89659), [#​91684](openclaw/openclaw#91684), [#​91649](openclaw/openclaw#91649), [#​90263](openclaw/openclaw#90263), [#​91686](openclaw/openclaw#91686), [#​90426](openclaw/openclaw#90426)) Thanks [@​itsuzef](https://github.com/itsuzef), [@​ladygege](https://github.com/ladygege), [@​jacobtomlinson](https://github.com/jacobtomlinson), [@​fuller-stack-dev](https://github.com/fuller-stack-dev), and [@​shushushv](https://github.com/shushushv). - Cron: cancel active task runs cleanly, preserve terminal timeout/cancel state, and recover no-deliver tool warnings instead of silently losing the outcome. ([#​90666](openclaw/openclaw#90666), [#​90678](openclaw/openclaw#90678)) Thanks [@​ai-hpc](https://github.com/ai-hpc). - Gateway/config/auth: share the approval runtime socket token, replace arrays explicitly in `config.patch`, skip the deleted-agent guard only for valid ACP harness sessions, surface headless LaunchAgent state, verify SQLite auth migration before cleanup, and arm QMD startup maintenance. ([#​87105](openclaw/openclaw#87105), [#​91551](openclaw/openclaw#91551), [#​91219](openclaw/openclaw#91219), [#​91614](openclaw/openclaw#91614), [#​91740](openclaw/openclaw#91740), [#​91978](openclaw/openclaw#91978)) Thanks [@​fuller-stack-dev](https://github.com/fuller-stack-dev) and [@​scotthuang](https://github.com/scotthuang). - Providers/Codex: clarify quota errors, restore the Codex synthetic usage line, canonicalize Codex protocol assets, require API-key auth for realtime voice, normalize ACP model refs, preserve Gemma 4 `reasoning_content`, and avoid guardian review for local models. ([#​91390](openclaw/openclaw#91390), [#​91709](openclaw/openclaw#91709), [#​91507](openclaw/openclaw#91507), [#​91567](openclaw/openclaw#91567), [#​88630](openclaw/openclaw#88630), [#​91696](openclaw/openclaw#91696)) Thanks [@​hxy91819](https://github.com/hxy91819), [@​brokemac79](https://github.com/brokemac79), [@​RomneyDa](https://github.com/RomneyDa), [@​joshavant](https://github.com/joshavant), and [@​Coder-Wangyankun](https://github.com/Coder-Wangyankun). - Updates/builds: recover package Gateway restarts after refresh failure, expose plugin convergence repair, fall back to Corepack in PATH-less pnpm environments, seed the correct Docker store packages, and keep ClawHub dry-run and publish paths reusable. ([#​91581](openclaw/openclaw#91581), [#​91599](openclaw/openclaw#91599), [#​91547](openclaw/openclaw#91547), [#​91591](openclaw/openclaw#91591)) Thanks [@​fuller-stack-dev](https://github.com/fuller-stack-dev), [@​sallyom](https://github.com/sallyom), and [@​Patrick-Erichsen](https://github.com/Patrick-Erichsen). - UI: require explicit user intent before opening chat sessions and drain restored chat queues after session switches. ([#​91480](openclaw/openclaw#91480)) Thanks [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - Android: avoid the `dataSync` foreground-service type for persistent nodes. ([#​80082](openclaw/openclaw#80082)) Thanks [@​davelutztx](https://github.com/davelutztx). - Native hooks: bound relay lifetimes so abandoned native hook connections cannot linger indefinitely. ([#​91550](openclaw/openclaw#91550)) Thanks [@​joshavant](https://github.com/joshavant). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/1040
Summary
127.0.0.1OAuth redirect default for upgrade compatibility, and retry dynamic client registration withhttp://localhost:8989/oauth/callbackwhen an authorization server rejects the IP loopback redirect."[object Response]"by normalizing body-less MCP HTTP fetch responses to globalResponseobjects the MCP SDK can read.patternvalues use redundant\:escapes that are invalid under TypeBox's unicode RegExp compile path.Why does this matter now?
Remote streamable-http MCP servers with OAuth (PayPal, Calendly) are currently unusable or fail with opaque errors after login.
What is the intended outcome?
Operators can run
openclaw mcp login/openclaw mcp probeagainst OAuth MCP servers without regex compile crashes, with readable DCR errors, and with a tested localhost fallback for ASes that reject127.0.0.1.What is intentionally out of scope?
What does success look like?
Regression tests cover all three failure modes; maintainers can confirm live OAuth on PayPal/Calendly with the reporter's repro steps.
What should reviewers focus on?
Localhost redirect fallback policy (only after DCR rejection, legacy default preserved) and the conservative JSON Schema pattern repair applied before TypeBox compile.
Linked context
Which issue does this close?
Closes #91433
Which issues, PRs, or discussions are related?
Related #91433 (ClawSweeper review and reporter follow-up confirming localhost fixes Calendly)
Was this requested by a maintainer or owner?
No — community bug report with maintainer review pending.
Real behavior proof (required for external PRs)
Behavior or issue addressed: MCP OAuth regex crash,
[object Response]error masking, Calendly DCR redirect rejectionReal environment tested: Local Node v25.6.0 on Windows checkout (
E:/Projects/openclaw), branchfix/issue-91433-mcp-oauth-regexExact steps or command run after this patch:
node -erepro script for PayPal-like TypeBox pattern compile and body-less OAuth error normalization (copied output below)node scripts/run-vitest.mjs src/agents/mcp-oauth.test.ts -t "legacy loopback|redirect registration|retries MCP"node scripts/run-vitest.mjs src/agents/mcp-http-fetch.test.ts -t "compatible with MCP SDK"pnpm exec oxlinton changed source filesEvidence after fix (screenshot, recording, terminal capture, console output, redacted runtime log, linked artifact, or copied live output):
Copied terminal output from a local Node repro after this patch:
Responseso OAuth error JSON is readable; localhost redirect retry is covered by unit test.openclaw mcp login/probeagainst PayPal or Calendly\:under /u; OAuth errors surfaced as [object Response]) #91433 repro logs (Invalid regular expression: /^https\:\/\//u,[object Response])Tests and validation
Which commands did you run?
node scripts/run-vitest.mjs src/agents/mcp-oauth.test.ts -t "legacy loopback|redirect registration|retries MCP"node scripts/run-vitest.mjs src/agents/mcp-http-fetch.test.ts -t "compatible with MCP SDK"pnpm exec oxlint src/shared/json-schema-defaults.ts src/agents/mcp-oauth.ts src/agents/mcp-http-fetch.tsWhat regression coverage was added or updated?
mcp-oauth.test.ts: legacy default preserved; localhost retry after redirect registration rejectionmcp-http-fetch.test.ts: body-less cross-realm fetch response works with MCP SDKparseErrorResponseagent-bundle-mcp-runtime.test.ts: unicode-invalid JSON Schema pattern compiles and validatesWhat failed before this fix, if known?
Invalid regular expression: /^https\:\/\//u: Invalid escapeInvalid OAuth error response ... "[object Response]"invalid_client_metadatafor127.0.0.1redirect (reporter confirmed localhost works)If no test was added, why not?
N/A — regression tests added for all three fixes.
Risk checklist
Did user-visible behavior change? (
Yes)New localhost redirect retry on DCR rejection; legacy
127.0.0.1default preserved for existing registrations.Did config, environment, or migration behavior change? (
No)Did security, auth, secrets, network, or tool execution behavior change? (
Yes)OAuth redirect registration fallback and MCP HTTP response normalization for OAuth error readability.
What is the highest-risk area?
OAuth redirect fallback after dynamic client registration failure.
How is that risk mitigated?
Legacy default unchanged; localhost used only on explicit DCR redirect rejection without configured override; existing
--oauth-redirect-urloverride remains.Current review state
What is the next action?
Wait for maintainer review. CI is green on head
564eac41ac; request another ClawSweeper re-review after the prior run timed out (Codex ETIMEDOUT).What is still waiting on author, maintainer, CI, or external proof?
564eac41acdid not complete (timeout); no fresh bot verdict yetopenclaw mcp login/probeproof still unavailable in contributor environmentWhich bot or reviewer comments were addressed?
564eac41ac(body-less error text, redirect persistence)check-lint,Real behavior proof,checks-node-agentic-agents-support,checks-node-agentic-agents-core-runtime— pass on latest push