fix: guard QMD session stem fallback by clawsweeper[bot] · Pull Request #86482 · openclaw/openclaw

clawsweeper · 2026-05-25T12:41:49Z

Makes #86327 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-86327
Source PRs: fix: guard QMD session stem fallback #86327
Credit: Source PR: fix: guard QMD session stem fallback #86327
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Co-author credit kept:

@abnershang: Co-authored-by: Abner Shang 75654486+abnershang@users.noreply.github.com

fish notes: model gpt-5.5, reasoning high; reviewed against 554d4c8.

clawsweeper · 2026-05-25T12:44:18Z

Codex review: passed. Reviewed May 25, 2026, 10:31 AM ET / 14:31 UTC.

Summary
This PR changes resolveTranscriptStemToSessionKeys to skip empty or missing sessionId values during QMD slug fallback, adds regression coverage, and adds a changelog entry.

PR surface: Source +1, Tests +17, Docs +1. Total +19 across 3 files.

Reproducibility: yes. from source inspection: current main reaches normalizeQmdSessionStem(entry.sessionId) during QMD slug fallback, and stored session entries can be metadata-only. I did not run tests in this read-only review, but the source PR includes a direct after-fix resolver probe for the same mixed-store case.

Review metrics: none identified.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Next step before merge
No separate repair lane is needed because the automerge-opted replacement PR already contains the narrow fix, regression test, changelog entry, and sufficient proof.

Security
Cleared: The diff only changes resolver control flow, a colocated test, and changelog text; it adds no dependency, workflow, credential, permission, or code-execution surface.

Review details

Best possible solution:

Land the narrow guard with the regression test and changelog once the exact PR head satisfies the automerge checks.

Do we have a high-confidence way to reproduce the issue?

Yes from source inspection: current main reaches normalizeQmdSessionStem(entry.sessionId) during QMD slug fallback, and stored session entries can be metadata-only. I did not run tests in this read-only review, but the source PR includes a direct after-fix resolver probe for the same mixed-store case.

Is this the best way to solve the issue?

Yes. The PR uses the existing optional-string normalizer at the failing point, keeps exact-match behavior intact, and adds a focused regression test without changing config, API shape, or fallback policy.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 489e4153396f.

Label changes

Label justifications:

P2: This is a normal-priority runtime bugfix for QMD session transcript hit resolution with limited blast radius.
rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (terminal): The linked source PR supplies terminal proof for the exact resolver scenario after the patch, including direct output and focused validation commands.
proof: sufficient: Contributor real behavior proof is sufficient. The linked source PR supplies terminal proof for the exact resolver scenario after the patch, including direct output and focused validation commands.

Evidence reviewed

PR surface:

Source +1, Tests +17, Docs +1. Total +19 across 3 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	1	2	1	+1
Tests	1	17	0	+17
Docs	1	1	0	+1
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	3	20	1	+19

What I checked:

Repository policy read: Root AGENTS.md and the scoped src/plugin-sdk/AGENTS.md were read; SDK changes are compatibility-sensitive, need focused evidence, and should stay narrow without broad new public surface. (src/plugin-sdk/AGENTS.md:1, 489e4153396f)
Current main still has the unsafe fallback call: On current main, QMD fallback reaches normalizeQmdSessionStem(entry.sessionId) directly after checking session file matches, so a store entry without a usable sessionId can throw before a later valid entry resolves. (src/plugin-sdk/session-transcript-hit.ts:154, 489e4153396f)
Missing session IDs are a plausible stored shape: The session entry type has a required sessionId, but persisted shape normalization can return an entry with sessionId absent when raw input lacks that field, matching the metadata-only row covered by the PR test. (src/config/sessions/store-entry-shape.ts:37, 489e4153396f)
PR guard is narrowly scoped: The PR head normalizes entry.sessionId with the existing normalizeOptionalString helper and only calls QMD stem normalization when the normalized value is present. (src/plugin-sdk/session-transcript-hit.ts:154, 81478b0ee6cc)
Regression coverage matches the failure mode: The added test builds a mixed store with one metadata-only entry and one valid foo_bar.v1 session, then verifies QMD slug fallback resolves foo-bar-v1 to the valid key. (src/plugin-sdk/session-transcript-hit.test.ts:220, 81478b0ee6cc)
Real behavior proof was supplied through the source PR: The linked source PR body includes a direct resolver probe returning ["agent:main:s1"] after the patch, plus focused test, build, check, whitespace, and Codex review validation output. (src/plugin-sdk/session-transcript-hit.ts:154, b0a69a94bba7)

Likely related people:

@steipete: git blame and git log in this checkout attribute the current session-transcript-hit resolver and test file to commit 033693843c26287d546314620874087c8905be96; history is shallow/grafted, so this is best treated as routing signal rather than full provenance. (role: current-main introducer / recent area contributor; confidence: medium; commits: 033693843c26; files: src/plugin-sdk/session-transcript-hit.ts, src/plugin-sdk/session-transcript-hit.test.ts)
@vignesh07: CONTRIBUTING.md lists Vignesh for Memory (QMD), and this change affects QMD session transcript hit resolution; this is domain-routing evidence rather than line blame. (role: documented QMD area owner; confidence: medium; commits: 033693843c26; files: CONTRIBUTING.md, src/plugin-sdk/session-transcript-hit.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

clawsweeper · 2026-05-25T12:47:45Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=81478b0ee6cc77f4ecf4287524424c91c3bd9bfa)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-25T14:35:44Z
Merge commit: 2e3b59bc5804

What merged:

This PR changes resolveTranscriptStemToSessionKeys to skip empty or missing sessionId values during QMD slug fallback, adds regression coverage, and adds a changelog entry.
PR surface: Source +1, Tests +17, Docs +1. Total +19 across 3 files.
Reproducibility: yes. from source inspection: current main reaches `normalizeQmdSessionStem(entry.sessionId) ... ad-only review, but the source PR includes a direct after-fix resolver probe for the same mixed-store case.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix: guard QMD session stem fallback
PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8632…

The automerge loop is complete.

Automerge progress:

2026-05-25 13:20:57 UTC automerge wait dcf3f9476af7 (waiting) in 20m 32s Run: https://github.com/openclaw/clawsweeper/actions/runs/26401682627 mergeable state is CONFLICTING

2026-05-25 13:19:48 UTC review passed dcf3f9476af7 (structured ClawSweeper verdict: pass (sha=dcf3f9476af74946fb4501193665f5d4ab6b0...)

2026-05-25 13:20:59 UTC repair finished dcf3f9476af7 (pushed) in 20m 34s Run: https://github.com/openclaw/clawsweeper/actions/runs/26401682627 repair_contributor_branch

2026-05-25 13:53:49 UTC review queued dcf3f9476af7 (queued)

2026-05-25 13:55:06 UTC repair queued dcf3f9476af7 (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820

2026-05-25 13:57:38 UTC repair started (running) in 0s Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820 automerge-openclaw-openclaw-86327

2026-05-25 13:57:53 UTC validation plan (passed) in 15s Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820 pnpm check:changed; pnpm lint; pnpm check:test-types

2026-05-25 13:58:05 UTC Codex write preflight (passed) in 28s Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820 danger-full-access

2026-05-25 14:04:52 UTC Codex edit 1 51f4b30320ba (complete) in 7m 14s Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820 exit 0

2026-05-25 14:26:14 UTC validation and review 1 81478b0ee6cc (base moved) in 28m 37s Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820 codex-reconciled

2026-05-25 14:26:24 UTC repair completed 81478b0ee6cc (branch updated) in 28m 47s Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820 initial automerge rebase is delegated to Codex repair

2026-05-25 14:26:24 UTC review queued 81478b0ee6cc (after repair)

2026-05-25 14:35:36 UTC automerge wait 81478b0ee6cc (ready) in 37m 59s Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820 checks and exact-head review are ready

2026-05-25 14:35:37 UTC repair finished 81478b0ee6cc (pushed) in 38m Run: https://github.com/openclaw/clawsweeper/actions/runs/26404091820 repair_contributor_branch

2026-05-25 14:35:32 UTC review passed 81478b0ee6cc (structured ClawSweeper verdict: pass (sha=81478b0ee6cc77f4ecf4287524424c91c3bd9...)

2026-05-25 14:35:46 UTC merged 81478b0ee6cc (merged by ClawSweeper automerge)

clawsweeper · 2026-05-25T12:57:17Z

ClawSweeper PR egg

✨ Hatched: 🥚 common Clockwork Proofling

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

Merged PRs are hatchable.
Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.

Rarity: 🥚 common.
Trait: finds missing screenshots.
Image traits: location workflow harbor; accessory proof snapshot camera; palette moonlit blue and soft silver; mood focused; pose leaning over a miniature review desk; shell soft speckled shell; lighting calm overcast light; background delicate sparkle particles.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Clockwork Proofling in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Co-authored-by: Abner Shang <75654486+abnershang@users.noreply.github.com>

…7 (1)

Summary: - This PR changes `resolveTranscriptStemToSessionKeys` to skip empty or missing `sessionId` values during QMD slug fallback, adds regression coverage, and adds a changelog entry. - PR surface: Source +1, Tests +17, Docs +1. Total +19 across 3 files. - Reproducibility: yes. from source inspection: current main reaches `normalizeQmdSessionStem(entry.sessionId) ... ad-only review, but the source PR includes a direct after-fix resolver probe for the same mixed-store case. Automerge notes: - PR branch already contained follow-up commit before automerge: fix: guard QMD session stem fallback - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8632… Validation: - ClawSweeper review passed for head 81478b0. - Required merge gates passed before the squash merge. Prepared head SHA: 81478b0 Review: openclaw#86482 (comment) Co-authored-by: abnershang <abner.shang@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: Abner Shang <75654486+abnershang@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

clawsweeper Bot mentioned this pull request May 25, 2026

fix: guard QMD session stem fallback #86327

Closed

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 25, 2026

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-86327 branch from 554d4c8 to dcf3f94 Compare May 25, 2026 13:10

abnershang and others added 3 commits May 25, 2026 14:23

fix: guard QMD session stem fallback

3bde6c7

fix: guard QMD session stem fallback

275a1d0

Co-authored-by: Abner Shang <75654486+abnershang@users.noreply.github.com>

fix(clawsweeper): address review for automerge-openclaw-openclaw-8632…

81478b0

…7 (1)

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-86327 branch from dcf3f94 to 81478b0 Compare May 25, 2026 14:26

clawsweeper Bot merged commit 2e3b59b into main May 25, 2026
98 of 99 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-86327 branch May 25, 2026 14:35

github-actions Bot mentioned this pull request May 25, 2026

📡 Upstream Digest — 2026-05-25 16:16 UTC curtismercier/openclaw-mods#944

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: guard QMD session stem fallback#86482

fix: guard QMD session stem fallback#86482
clawsweeper[bot] merged 3 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-86327

clawsweeper Bot commented May 25, 2026

Uh oh!

clawsweeper Bot commented May 25, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 25, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clawsweeper Bot commented May 25, 2026

Uh oh!

clawsweeper Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 25, 2026

Hatch command

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 25, 2026 •

edited

Loading

clawsweeper Bot commented May 25, 2026 •

edited

Loading