fix: guard QMD session stem fallback

abnershang · abnershang · commit b0a69a94bba7 · 2026-05-25T12:34:34.000+08:00
diff --git a/src/plugin-sdk/session-transcript-hit.test.ts b/src/plugin-sdk/session-transcript-hit.test.ts
@@ -217,6 +217,23 @@ describe("resolveTranscriptStemToSessionKeys", () => {
     ).toEqual(["agent:main:s1"]);
   });
 
+  it("ignores store entries without session ids during QMD-slugified fallback", () => {
+    const store: Record<string, SessionEntry> = {
+      "agent:main:non-session": {
+        updatedAt: 1,
+      } as SessionEntry,
+      "agent:main:s1": baseEntry({ sessionId: "foo_bar.v1" }),
+    };
+
+    expect(
+      resolveTranscriptStemToSessionKeys({
+        store,
+        stem: "foo-bar-v1",
+        allowQmdSlugFallback: true,
+      }),
+    ).toEqual(["agent:main:s1"]);
+  });
+
   it("does not use QMD-slugified fallback unless requested", () => {
     const store: Record<string, SessionEntry> = {
       "agent:main:s1": baseEntry({ sessionId: "foo_bar.v1" }),
diff --git a/src/plugin-sdk/session-transcript-hit.ts b/src/plugin-sdk/session-transcript-hit.ts
@@ -151,7 +151,8 @@ export function resolveTranscriptStemToSessionKeys(params: {
           continue;
         }
       }
-      if (normalizeQmdSessionStem(entry.sessionId) === normalizedStem) {
+      const entrySessionId = normalizeOptionalString(entry.sessionId);
+      if (entrySessionId && normalizeQmdSessionStem(entrySessionId) === normalizedStem) {
         matches.push(sessionKey);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,8 @@ export function resolveTranscriptStemToSessionKeys(params: {`
`151`	`151`	`continue;`
`152`	`152`	`}`
`153`	`153`	`}`
`154`		`- if (normalizeQmdSessionStem(entry.sessionId) === normalizedStem) {`
	`154`	`+ const entrySessionId = normalizeOptionalString(entry.sessionId);`
	`155`	`+ if (entrySessionId && normalizeQmdSessionStem(entrySessionId) === normalizedStem) {`
`155`	`156`	`matches.push(sessionKey);`
`156`	`157`	`}`
`157`	`158`	`}`