[codex] Fix Control UI terminal run status recovery#84112
Conversation
|
Codex review: passed. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. Current main has a source-visible path where PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. PR egg Rarity: 🥚 common. What is this egg doing here?
Real behavior proof Mantis proof suggestion Risk before merge Maintainer options:
Next step before merge Security Review detailsBest possible solution: Merge this focused UI status-precedence fix after exact-head checks and maintainer/automerge gates, then close the linked stuck-status bug when it lands. Do we have a high-confidence way to reproduce the issue? Yes. Current main has a source-visible path where Is this the best way to solve the issue? Yes. A shared helper that treats Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 4e60ad721209. |
|
🦞✅ Source: What merged:
Automerge notes:
The automerge loop is complete. Automerge progress:
|
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503add0abb2a07e47224e863cd5f612658aec. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503add0abb2a07e47224e863cd5f612658aec Review: openclaw/openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503add0abb2a07e47224e863cd5f612658aec. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503add0abb2a07e47224e863cd5f612658aec Review: openclaw/openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - Adds shared Control UI session-run active-state handling, applies terminal-status precedence in chat/session rendering and lifecycle recovery, and adds focused regressions plus a changelog entry. - Reproducibility: yes. Current main has a source-visible path where `status: "done"` plus stale `hasActiveRun ... eeps abort/in-progress UI alive, and the linked proof exercises the fixed stale-terminal state in Chromium. Automerge notes: - PR branch already contained follow-up commit before automerge: [codex] Fix Control UI terminal run status recovery Validation: - ClawSweeper review passed for head f9f503a. - Required merge gates passed before the squash merge. Prepared head SHA: f9f503a Review: openclaw#84112 (comment) Co-authored-by: NianJiuZst <3235467914@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Makes #84057 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
ClawSweeper 🐠 replacement reef notes:
Inherited issue-closing references from the source PR:
Closes #84041
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against f9f503a.