Skip to content

scripts: fix ad-hoc signing crashes and bash unbound variable error#70

Merged
steipete merged 1 commit intoopenclaw:mainfrom
petter-b:fix/codesign-adhoc
Jan 1, 2026
Merged

scripts: fix ad-hoc signing crashes and bash unbound variable error#70
steipete merged 1 commit intoopenclaw:mainfrom
petter-b:fix/codesign-adhoc

Conversation

@petter-b
Copy link
Copy Markdown
Contributor

@petter-b petter-b commented Jan 1, 2026

Improves the developer experience when building Clawdis without a valid Apple Developer ID:

  1. Skips --options runtime (Hardened Runtime) when using ad-hoc signing (-). Enforcing Hardened Runtime on ad-hoc signed apps often causes "Abort trap 6" crashes due to Team ID mismatches with embedded frameworks.
  2. Fixes a bash "unbound variable" error in scripts/codesign-mac-app.sh when options_args is empty.

@petter-b
Copy link
Copy Markdown
Contributor Author

petter-b commented Jan 1, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@petter-b petter-b marked this pull request as ready for review January 1, 2026 15:38
@steipete
Copy link
Copy Markdown
Contributor

steipete commented Jan 1, 2026

Thank you Petter, very useful!

@steipete steipete merged commit fe5e58a into openclaw:main Jan 1, 2026
3 of 6 checks passed
@petter-b petter-b deleted the fix/codesign-adhoc branch January 5, 2026 10:11
dgarson referenced this pull request in dgarson/clawdbot Feb 4, 2026
Dulyawat-K added a commit to Dulyawat-K/openclaw that referenced this pull request Feb 4, 2026
- Add Extended Cognitive State endpoint (openclaw#66)
- Add Create Cognitive Event endpoint (openclaw#67)
- Add Create Affect Signal endpoint (openclaw#68)
- Add Patch Current Intent endpoint (openclaw#69)
- Add Get Explanation Hooks endpoint (openclaw#70)
- Update ToC with AERITH Runtime Wiring section

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dalefrieswthat pushed a commit to dalefrieswthat/openclaw that referenced this pull request Feb 25, 2026
songliu0403-rgb pushed a commit to songliu0403-rgb/openclaw that referenced this pull request Feb 26, 2026
heatherstew44-maker pushed a commit to heatherstew44-maker/openclaw that referenced this pull request Mar 8, 2026
add partial/resumable download capability
0x666c6f added a commit to 0x666c6f/openclaw that referenced this pull request Mar 26, 2026
…-up-pr69-review-comments-on-sre-wrapper-path-scope

fix(sre:PLA-838): scope wrapper path injection to SRE agents
0x666c6f added a commit to 0x666c6f/openclaw that referenced this pull request Mar 26, 2026
- Remove dead START_GATEWAY variable from rewards provider test
- Make #platform-monitoring systemPrompt unconditional to prevent
  null regression when channel override excludes it

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0x666c6f added a commit to 0x666c6f/openclaw that referenced this pull request Mar 26, 2026
…-up-pr69-review-comments-on-sre-wrapper-path-scope

fix(sre:PLA-838): address remaining PR openclaw#70 review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants