fix(doctor): make dm.policy migration idempotent#70
Merged
dgarson merged 1 commit intodgarson/forkfrom Feb 23, 2026
Merged
Conversation
dgarson
added a commit
that referenced
this pull request
Feb 22, 2026
- ModelRouter: 7 routing rules, condition pills, strategy presets, route test panel (Quinn) - SessionReplay: session timeline player, playback controls, event kind filters (Wes)
02cf1d4 to
fcb0952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizeLegacyConfigValuesdm alias migration to only act when legacy keys are explicitly present on thedmobjectRoot cause
The migration logic checked legacy values by value/undefined, not explicit key presence. This allowed non-explicit fallback/computed states to be treated as pending legacy migrations and re-reported repeatedly.
Validation
pnpm vitest -c vitest.e2e.config.ts src/commands/doctor-legacy-config.e2e.test.tsNotes