Fix ssh identity handling for remote exec #48924
Merged
sallyom merged 1 commit intoopenclaw:mainfrom Mar 17, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR hardens inline SSH key handling in the sandbox path by normalizing BOM, CRLF line endings, and escaped Key issues found:
Confidence Score: 3/5
Prompt To Fix All With AIThis is a comment left during a code review.
Path: src/agents/sandbox/ssh.ts
Line: 233
Comment:
**Fallback error message loses exit code**
The `|| \`ssh exited with code ${exitCode}\`` fallback is now unreachable dead code because `buildSshFailureMessage` always returns a non-empty string (it falls back to `"ssh exited with a non-zero status"` when stderr is empty). This is a behavioural regression: in the original code, an empty-stderr failure reported `"ssh exited with code 1"` (with the actual code); now it reports the generic string with no exit code.
Fix `buildSshFailureMessage` to take the exit code into account when stderr is empty, or thread the exit code through the fallback properly:
```suggestion
buildSshFailureMessage(stderr.toString("utf8"), exitCode) || `ssh exited with code ${exitCode}`,
```
And update `buildSshFailureMessage` accordingly:
```typescript
function buildSshFailureMessage(stderr: string, exitCode?: number): string {
const trimmed = stderr.trim();
if (
trimmed.includes("error in libcrypto") &&
(trimmed.includes('Load key "') || trimmed.includes("Permission denied (publickey)"))
) {
return `${trimmed}\nSSH sandbox failed to load the configured identity. The private key contents may be malformed (for example CRLF or escaped newlines). Prefer identityFile when possible.`;
}
return trimmed || (exitCode !== undefined ? `ssh exited with code ${exitCode}` : "ssh exited with a non-zero status");
}
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: src/agents/sandbox/ssh.ts
Line: 58
Comment:
**Incomplete string in SSH error pattern match**
The substring `"Permission denied (publickey"` is missing the closing `)`. While SSH's real message (`Permission denied (publickey).`) is still matched because the incomplete literal is a valid prefix, the intent is clearly to match a full, well-known error phrase and the typo could mislead future readers.
```suggestion
(trimmed.includes('Load key "') || trimmed.includes("Permission denied (publickey)"))
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: src/agents/sandbox/ssh.ts
Line: 44-50
Comment:
**Mixed real-newline and escaped-newline keys are silently left malformed**
The `shouldExpandEscapedNewlines` guard bails out when the string already contains at least one real newline (`!normalizedEscapedNewlines.includes("\n")`). This means a key that contains **both** actual newlines and literal `\n` sequences (e.g. a key copied from a JSON field that was partially decoded) will have its escaped sequences left as the two-character literal `\n` in the temp file, which OpenSSH will reject.
This is arguably an edge case, but it is inconsistent: the function is called specifically to harden against malformed input, yet this exact mix will silently produce a corrupt file. At minimum, a comment explaining why the guard is intentionally conservative would prevent future confusion. A more robust approach would be to apply the expansion regardless and only suppress it when `filename` is not a key file.
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: bf57cea |
| @@ -202,7 +229,9 @@ export async function runSshSandboxCommand( | |||
| if (exitCode !== 0 && !params.allowFailure) { | |||
| reject( | |||
| Object.assign( | |||
| new Error(stderr.toString("utf8").trim() || `ssh exited with code ${exitCode}`), | |||
| new Error( | |||
| buildSshFailureMessage(stderr.toString("utf8")) || `ssh exited with code ${exitCode}`, | |||
Contributor
There was a problem hiding this comment.
The || \ssh exited with code ${exitCode}`fallback is now unreachable dead code becausebuildSshFailureMessagealways returns a non-empty string (it falls back to"ssh exited with a non-zero status"when stderr is empty). This is a behavioural regression: in the original code, an empty-stderr failure reported"ssh exited with code 1"` (with the actual code); now it reports the generic string with no exit code.
Fix buildSshFailureMessage to take the exit code into account when stderr is empty, or thread the exit code through the fallback properly:
Suggested change
| buildSshFailureMessage(stderr.toString("utf8")) || `ssh exited with code ${exitCode}`, | |
| buildSshFailureMessage(stderr.toString("utf8"), exitCode) || `ssh exited with code ${exitCode}`, |
And update buildSshFailureMessage accordingly:
function buildSshFailureMessage(stderr: string, exitCode?: number): string {
const trimmed = stderr.trim();
if (
trimmed.includes("error in libcrypto") &&
(trimmed.includes('Load key "') || trimmed.includes("Permission denied (publickey)"))
) {
return `${trimmed}\nSSH sandbox failed to load the configured identity. The private key contents may be malformed (for example CRLF or escaped newlines). Prefer identityFile when possible.`;
}
return trimmed || (exitCode !== undefined ? `ssh exited with code ${exitCode}` : "ssh exited with a non-zero status");
}Prompt To Fix With AI
This is a comment left during a code review.
Path: src/agents/sandbox/ssh.ts
Line: 233
Comment:
**Fallback error message loses exit code**
The `|| \`ssh exited with code ${exitCode}\`` fallback is now unreachable dead code because `buildSshFailureMessage` always returns a non-empty string (it falls back to `"ssh exited with a non-zero status"` when stderr is empty). This is a behavioural regression: in the original code, an empty-stderr failure reported `"ssh exited with code 1"` (with the actual code); now it reports the generic string with no exit code.
Fix `buildSshFailureMessage` to take the exit code into account when stderr is empty, or thread the exit code through the fallback properly:
```suggestion
buildSshFailureMessage(stderr.toString("utf8"), exitCode) || `ssh exited with code ${exitCode}`,
```
And update `buildSshFailureMessage` accordingly:
```typescript
function buildSshFailureMessage(stderr: string, exitCode?: number): string {
const trimmed = stderr.trim();
if (
trimmed.includes("error in libcrypto") &&
(trimmed.includes('Load key "') || trimmed.includes("Permission denied (publickey)"))
) {
return `${trimmed}\nSSH sandbox failed to load the configured identity. The private key contents may be malformed (for example CRLF or escaped newlines). Prefer identityFile when possible.`;
}
return trimmed || (exitCode !== undefined ? `ssh exited with code ${exitCode}` : "ssh exited with a non-zero status");
}
```
How can I resolve this? If you propose a fix, please make it concise.| const trimmed = stderr.trim(); | ||
| if ( | ||
| trimmed.includes("error in libcrypto") && | ||
| (trimmed.includes('Load key "') || trimmed.includes("Permission denied (publickey")) |
Contributor
There was a problem hiding this comment.
The substring "Permission denied (publickey" is missing the closing ). While SSH's real message (Permission denied (publickey).) is still matched because the incomplete literal is a valid prefix, the intent is clearly to match a full, well-known error phrase and the typo could mislead future readers.
Suggested change
| (trimmed.includes('Load key "') || trimmed.includes("Permission denied (publickey")) | |
| (trimmed.includes('Load key "') || trimmed.includes("Permission denied (publickey)")) |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/agents/sandbox/ssh.ts
Line: 58
Comment:
**Incomplete string in SSH error pattern match**
The substring `"Permission denied (publickey"` is missing the closing `)`. While SSH's real message (`Permission denied (publickey).`) is still matched because the incomplete literal is a valid prefix, the intent is clearly to match a full, well-known error phrase and the typo could mislead future readers.
```suggestion
(trimmed.includes('Load key "') || trimmed.includes("Permission denied (publickey)"))
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+44
to
+50
| const shouldExpandEscapedNewlines = | ||
| normalizedEscapedNewlines.includes("\\n") && | ||
| !normalizedEscapedNewlines.includes("\n") && | ||
| (filename === "identity" || filename === "certificate.pub"); | ||
| const expanded = shouldExpandEscapedNewlines | ||
| ? normalizedEscapedNewlines.replace(/\\n/g, "\n") | ||
| : normalizedEscapedNewlines; |
Contributor
There was a problem hiding this comment.
The shouldExpandEscapedNewlines guard bails out when the string already contains at least one real newline (!normalizedEscapedNewlines.includes("\n")). This means a key that contains both actual newlines and literal \n sequences (e.g. a key copied from a JSON field that was partially decoded) will have its escaped sequences left as the two-character literal \n in the temp file, which OpenSSH will reject.
This is arguably an edge case, but it is inconsistent: the function is called specifically to harden against malformed input, yet this exact mix will silently produce a corrupt file. At minimum, a comment explaining why the guard is intentionally conservative would prevent future confusion. A more robust approach would be to apply the expansion regardless and only suppress it when filename is not a key file.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/agents/sandbox/ssh.ts
Line: 44-50
Comment:
**Mixed real-newline and escaped-newline keys are silently left malformed**
The `shouldExpandEscapedNewlines` guard bails out when the string already contains at least one real newline (`!normalizedEscapedNewlines.includes("\n")`). This means a key that contains **both** actual newlines and literal `\n` sequences (e.g. a key copied from a JSON field that was partially decoded) will have its escaped sequences left as the two-character literal `\n` in the temp file, which OpenSSH will reject.
This is arguably an edge case, but it is inconsistent: the function is called specifically to harden against malformed input, yet this exact mix will silently produce a corrupt file. At minimum, a comment explaining why the guard is intentionally conservative would prevent future confusion. A more robust approach would be to apply the expansion regardless and only suppress it when `filename` is not a key file.
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf57cea5a9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ) { | ||
| return `${trimmed}\nSSH sandbox failed to load the configured identity. The private key contents may be malformed (for example CRLF or escaped newlines). Prefer identityFile when possible.`; | ||
| } | ||
| return trimmed || "ssh exited with a non-zero status"; |
There was a problem hiding this comment.
Include SSH exit code in default failure message
buildSshFailureMessage now returns a non-empty default string ("ssh exited with a non-zero status"), which makes the runSshSandboxCommand fallback ssh exited with code ${exitCode} unreachable. In failures where ssh produces no stderr (for example abrupt disconnects or some transport-level exits), the surfaced error message loses the numeric exit code, reducing diagnosability for callers that log/display only error.message.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8abfcad264
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ) { | ||
| return `${trimmed}\nSSH sandbox failed to load the configured identity. The private key contents may be malformed (for example CRLF or escaped newlines). Prefer identityFile when possible.`; | ||
| } | ||
| return trimmed || "ssh exited with a non-zero status"; |
There was a problem hiding this comment.
Preserve SSH exit code in fallback errors
buildSshFailureMessage now always returns a non-empty string ("ssh exited with a non-zero status") when stderr is empty, so the runSshSandboxCommand fallback ssh exited with code ${exitCode} is never used. In non-interactive failures where OpenSSH emits no stderr (for example abrupt transport exits), callers lose the numeric exit code in error.message, which makes diagnosing production failures materially harder.
Useful? React with 👍 / 👎.
Signed-off-by: sallyom <somalley@redhat.com>
kimptoc
pushed a commit
to kimptoc/openclaw
that referenced
this pull request
Mar 17, 2026
Signed-off-by: sallyom <somalley@redhat.com>
nikolaisid
pushed a commit
to nikolaisid/openclaw
that referenced
this pull request
Mar 18, 2026
Signed-off-by: sallyom <somalley@redhat.com>
sbezludny
pushed a commit
to sbezludny/openclaw
that referenced
this pull request
Mar 27, 2026
Signed-off-by: sallyom <somalley@redhat.com>
juancatorr
added a commit
to juancatorr/openclaw
that referenced
this pull request
Apr 8, 2026
* refactor(slack): share setup wizard base * refactor(discord): share setup wizard base * refactor(signal): reuse shared setup security * refactor(imessage): reuse shared setup security * refactor(setup): reuse patched adapters across channels * refactor(imessage): share setup status base * refactor(slack): share token credential setup * refactor(setup): share env-aware patched adapters * refactor(discord): use shared plugin base * refactor(outbound): share base session helpers * refactor(whatsapp): reuse login tool implementation * refactor(providers): reuse simple api-key catalog helper * refactor(plugins): share bundle path list helpers * refactor(slack): reuse shared action adapter * refactor(tts): share provider readiness checks * refactor(plugins): share claiming hook loop * refactor(plugins): share install target flow * refactor(status): share scan helper state * refactor(usage): share legacy pi auth token lookup * refactor(device): share missing-scope helper * refactor(config): share schema lookup helpers * fix(plugin-sdk): restore core export boundary * build: tighten lazy runtime boundaries * fix(gateway): surface env override keys in exec approvals * Agents: move bootstrap warnings out of system prompt (openclaw#48753) Merged via squash. Prepared head SHA: dc1d4d0 Co-authored-by: scoootscooob <167050519+scoootscooob@users.noreply.github.com> Reviewed-by: @scoootscooob * refactor: dedupe channel entrypoints and test bridges * style: fix rebase formatting drift * fix: resolve rebase type fallout in channel setup seams * fix(macos): block canvas symlink escapes * refactor: bundle lazy runtime surfaces * fix: remove discord setup rebase marker * docs(gateway): clarify URL allowlist semantics * docs(changelog): restore 2026.2.27 heading * fix: unblock full gate * fix: stabilize full gate * test: cover invalid main job store load * build(test): ignore vitest scratch root * refactor: dedupe bundled plugin entrypoints * docs: add context engine documentation Add dedicated docs page for the pluggable context engine system: - Full lifecycle explanation (ingest, assemble, compact, afterTurn) - Legacy engine behavior documentation - Plugin engine authoring guide with code examples - ContextEngine interface reference table - ownsCompaction semantics - Subagent lifecycle hooks (prepareSubagentSpawn, onSubagentEnded) - systemPromptAddition mechanism - Relationship to compaction, memory plugins, and session pruning - Configuration reference and tips Also: - Add context-engine to docs nav (Agents > Fundamentals, after Context) - Add /context-engine redirect - Cross-link from context.md and compaction.md * docs: add plugin installation steps to context engine page Show the full workflow: install via openclaw plugins install, enable in plugins.entries, then select in plugins.slots.contextEngine. Uses lossless-claw as the concrete example. * docs: address review feedback on context-engine page - Rename 'Method' column to 'Member' with explicit Kind column since info is a property, not a callable method - Document AssembleResult fields (estimatedTokens, systemPromptAddition) with types and optionality - Add lifecycle timing notes for bootstrap, ingestBatch, and dispose so plugin authors know when each is invoked * docs: fix context engine review notes * fix: harden telegram and loader contracts * refactor(tests): share setup wizard prompter * refactor(telegram-tests): share native command helpers * fix(telegram-tests): load plugin mocks before commands * refactor(telegram-tests): share webhook settlement helper * refactor(nextcloud-tests): share inbound authz setup * refactor(feishu-tests): share card action event builders * refactor(runtime-tests): share typing lease assertions * refactor(hook-tests): share subagent hook helpers * refactor(provider-tests): share discovery catalog helpers * refactor(command-tests): share workspace harness * refactor(contracts): share session binding assertions * refactor(plugin-tests): share interactive dispatch assertions * refactor(plugin-tests): share binding approval resolution * refactor(usage-tests): share provider usage loader harness * refactor(bundle-tests): share bundle mcp fixtures * refactor(provider-tests): share codex catalog assertions * refactor(apns-tests): share relay push params * refactor(media-tests): share telegram redaction assertion * refactor(heartbeat-tests): share seeded heartbeat run * refactor(kilocode-tests): share reasoning payload capture * refactor(kilocode-tests): share extra-params harness * refactor(kilocode-tests): share cache retention wrapper * refactor(attempt-tests): share wrapped stream helper * refactor(payload-tests): share empty payload assertion * Telegram: fix named-account DM topic session keys (openclaw#48773) * refactor(compaction-tests): share aggregate timeout params * refactor(compaction-tests): share snapshot assertions * refactor(truncation-tests): share first tool result text helper * refactor(system-prompt-tests): share session setup helper * refactor(lanes-tests): share table-driven assertions * refactor(google-tests): share schema tool fixture * refactor(extension-tests): share safeguard factory setup * refactor(openrouter-tests): share state dir helper * refactor(thinking-tests): share assistant drop helper * refactor(kilocode-tests): share eligibility assertions * refactor(payload-tests): share empty payload helper * refactor(model-tests): share template model mock helper * refactor(image-tests): share empty prompt image assertions * fix: restore full gate * refactor: consolidate lazy runtime surfaces * refactor: remove remaining extension core imports * refactor(payload-tests): reuse empty payload helper * refactor(image-tests): share empty ref assertions * refactor(image-tests): share single-ref detection helper * refactor(image-tests): share ref count assertions * refactor(history-tests): share array content assertion * refactor(runs-tests): share run handle factory * refactor(skills-tests): share bundled diffs setup * refactor(payload-tests): share single payload summary assertion * refactor(payload-tests): table-drive recoverable tool suppressions * refactor(payload-tests): table-drive sessions send suppressions * refactor(history-tests): share pruned image assertions * refactor(failover-tests): share observation base * refactor(extension-tests): share safeguard runtime assertions * fix(ci): quote changed extension matrix input * refactor: split plugin testing seam from bundled extension helpers * test: fix discord provider helper import * Changelog: add Telegram DM topic session-key fix * fix(ci): harden zizmor workflow diffing * feat(image-generation): add image_generate tool * test(image-generation): add live variant coverage * docs(image-generation): remove nano banana stock docs * fix(ci): restore local check suite * chore: sync pnpm lockfile importers * fix(ui): restore control-ui query token compatibility (openclaw#43979) * fix(ui): restore control-ui query token imports * chore(changelog): add entry for openclaw#43979 thanks @stim64045-spec --------- Co-authored-by: 大禹 <dayu@dayudeMac-mini.local> Co-authored-by: Val Alexander <bunsthedev@gmail.com> Co-authored-by: Val Alexander <68980965+BunsDev@users.noreply.github.com> * fix: update macOS node service to use current CLI command shape (closes openclaw#43171) (openclaw#46843) Merged via squash. Prepared head SHA: dbf2edd Co-authored-by: Br1an67 <29810238+Br1an67@users.noreply.github.com> Co-authored-by: ImLukeF <92253590+ImLukeF@users.noreply.github.com> Reviewed-by: @ImLukeF * fix(macos): stop relaunching the app after quit when launch-at-login is enabled (openclaw#40213) Merged via squash. Prepared head SHA: c702d98 Co-authored-by: stablegenius49 <259448942+stablegenius49@users.noreply.github.com> Co-authored-by: ImLukeF <92253590+ImLukeF@users.noreply.github.com> Reviewed-by: @ImLukeF * tests: add missing useNoBundledPlugins() to bundle MCP loader test The "treats bundle MCP as a supported bundle surface" test was missing the useNoBundledPlugins() call present in all surrounding bundle plugin tests. Without it, loadOpenClawPlugins() scanned and loaded the full real bundled plugins directory on every call (with cache:false), causing excessive memory pressure and an OOM crash on Linux CI, which manifested as the test timing out at 120s. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix ssh sandbox key cp (openclaw#48924) Signed-off-by: sallyom <somalley@redhat.com> * tests: fix googlechat outbound partial mock * tests(google): inject oauth credential fs stubs * tests(feishu): mock conversation runtime seam * tests(feishu): inject client runtime seam * tests(contracts): fix provider catalog runtime wiring (openclaw#49040) * fix(plugins): forward plugin subagent overrides (openclaw#48277) Merged via squash. Prepared head SHA: ffa4589 Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Reviewed-by: @jalehman * fix(security): block JVM, Python, and .NET env injection vectors in host exec sandbox (openclaw#49025) Add JAVA_TOOL_OPTIONS, _JAVA_OPTIONS, JDK_JAVA_OPTIONS, PYTHONBREAKPOINT, and DOTNET_STARTUP_HOOKS to blockedKeys in the host exec security policy. Closes openclaw#22681 * CI: rename startup memory smoke (openclaw#49041) * CI: guard gateway watch against duplicate runtime regressions (openclaw#49048) * fix(hooks): pass sessionFile and sessionKey in after_compaction hook (openclaw#40781) Merged via squash. Prepared head SHA: 11e85f8 Co-authored-by: jarimustonen <1272053+jarimustonen@users.noreply.github.com> Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Reviewed-by: @jalehman * refactor: expose lazy runtime helper to plugins * refactor: align telegram test support with plugin runtime seam * fix(tlon): defer DM cite expansion until after auth * fix(context-engine): preserve legacy plugin sessionKey interop (openclaw#44779) Merged via squash. Prepared head SHA: e04c6fb Co-authored-by: hhhhao28 <112874572+hhhhao28@users.noreply.github.com> Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Reviewed-by: @jalehman * test: harden CI-sensitive test suites * test: remove repeated update module imports * test: inline bluebubbles action mocks * test: reuse subagent orphan recovery imports * test: flatten twitch send mocks * test: stabilize pdf tool runtime mocks * test: reuse run-node module imports * test: reuse git commit module exports * test: trim redundant context engine assertions * test: merge duplicate update cli scenarios * test: preload plugin sdk subpath imports * test: cache provider discovery fixtures * test: merge context lookup warmup cases * test: trim lightweight status and capability suites * test: merge telegram action matrix cases * test: merge embeddings provider selection cases * test: preload inbound contract fixtures * test: merge message action media sandbox cases * test: merge pid alive linux stat cases * test: merge tts config gating cases * test: trim signal and slack action cases * test: harden commands test module seams * test: merge bundle loader fixture cases * test: merge loader cache partition cases * test: merge loader setup entry matrix * test: merge discord audit allowlist cases * test: merge zalouser audit group cases * test: merge audit auth precedence cases * test: merge channel command audit cases * test: merge browser control audit cases * test: merge control ui audit cases * test: merge feishu audit doc cases * test: merge hooks audit risk cases * test: merge gateway http audit cases * test: share audit exposure severity helper * test: merge loader provenance path cases * test: merge loader escape path cases * test: merge loader alias resolution cases * test: merge install metadata audit cases * test: merge loader duplicate registration cases * test: merge loader http route cases * test: merge audit extension and workspace cases * test: merge loader single-plugin registration cases * test: merge loader precedence cases * test: merge audit exposure heuristic cases * test: merge loader workspace warning cases * test: merge audit hooks ingress cases * test: merge audit extension allowlist severity cases * test: merge loader provenance warning cases * test: merge loader bundled telegram cases * test: merge loader memory slot cases * test: merge loader scoped load cases * test: merge audit gateway auth presence cases * test: merge audit browser container cases * test: merge audit windows acl cases * test: merge audit deny command cases * test: merge audit code safety failure cases * test: merge loader cache miss cases * test: merge update cli service refresh cases * test: merge slack action mapping cases * test: merge command owner gating cases * test: merge update status output cases * test: merge command gateway config permission cases * test: merge command approval scope cases * test: merge command hook cases * test: merge command config write denial cases * test: merge command allowlist add cases * test: merge update cli service refresh behavior * test: merge command owner show gating cases * test: merge discord action listing cases * test: merge signal reaction mapping cases * test: merge discord reaction id resolution cases * test: merge telegram reaction id cases * test: merge audit resolved inspection cases * test: merge audit gateway auth guardrail cases * test: merge audit sandbox docker danger cases * test: merge audit discord allowlist cases * test: merge audit sandbox docker config cases * test: merge audit browser sandbox cases * test: merge audit allowCommands cases * test: merge audit install metadata cases * test: merge audit code safety cases * test: merge audit dangerous flag cases * test: merge audit trust exposure cases * test: merge audit channel command hygiene cases * test: merge slack validation cases * test: merge update cli dry run cases * test: merge update cli outcome cases * test: merge update cli validation cases * test: merge action media root cases * test: merge update cli restart behavior cases * test: merge update cli channel cases * test: stabilize full gate * feat(agents): infer image generation defaults * docs(image-generation): document implicit tool enablement * refactor: dedupe plugin lazy runtime helpers * fix(telegram): persist sticky IPv4 fallback across polling restarts (fixes openclaw#48177) (openclaw#48282) * fix(telegram): persist sticky IPv4 fallback across polling restarts (fixes openclaw#48177) Hoist resolveTelegramTransport() out of createTelegramBot() so the transport (and its sticky IPv4 fallback state) persists across polling restarts. Previously, each polling restart created a new transport with stickyIpv4FallbackEnabled=false, causing repeated IPv6 timeouts on hosts with unstable IPv6 connectivity. Changes: - bot.ts: accept optional telegramTransport in TelegramBotOptions - monitor.ts: resolve transport once before polling loop - polling-session.ts: pass transport through to bot creation AI-assisted (Claude Sonnet 4). Tested: tsc --noEmit clean. * Update extensions/telegram/src/polling-session.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * style: fix oxfmt formatting in bot.ts * test: cover telegram transport reuse across restarts * fix: preserve telegram sticky IPv4 fallback across polling restarts (openclaw#48282) (thanks @yassinebkr) --------- Co-authored-by: Yassine <yassinebkr@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Ayaan Zaidi <hi@obviy.us> * ACP: harden startup and move configured routing behind plugin seams (openclaw#48197) * ACPX: keep plugin-local runtime installs out of dist * Gateway: harden ACP startup and service PATH * ACP: reinitialize error-state configured bindings * ACP: classify pre-turn runtime failures as session init failures * Plugins: move configured ACP routing behind channel seams * Telegram tests: align startup probe assertions after rebase * Discord: harden ACP configured binding recovery * ACP: recover Discord bindings after stale runtime exits * ACPX: replace dead sessions during ensure * Discord: harden ACP binding recovery * Discord: fix review follow-ups * ACP bindings: load channel snapshots across workspaces * ACP bindings: cache snapshot channel plugin resolution * Experiments: add ACP pluginification holy grail plan * Experiments: rename ACP pluginification plan doc * Experiments: drop old ACP pluginification doc path * ACP: move configured bindings behind plugin services * Experiments: update bindings capability architecture plan * Bindings: isolate configured binding routing and targets * Discord tests: fix runtime env helper path * Tests: fix channel binding CI regressions * Tests: normalize ACP workspace assertion on Windows * Bindings: isolate configured binding registry * Bindings: finish configured binding cleanup * Bindings: finish generic cleanup * Bindings: align runtime approval callbacks * ACP: delete residual bindings barrel * Bindings: restore legacy compatibility * Revert "Bindings: restore legacy compatibility" This reverts commit ac2ed68fa2426ecc874d68278c71c71ad363fcfe. * Tests: drop ACP route legacy helper names * Discord/ACP: fix binding regressions --------- Co-authored-by: Onur <2453968+osolmaz@users.noreply.github.com> * feat: add bundled Chutes extension (openclaw#49136) * refactor: generalize bundled provider discovery seams * feat: land chutes extension via plugin-owned auth (openclaw#41416) (thanks @Veightor) * docs(security): clarify wildcard Control UI origins * refactor: clean extension api boundaries * fix: remove duplicate setup helper imports * fix(compaction): break safeguard cancel loop for sessions with no summarizable messages (openclaw#41981) (openclaw#42215) Merged via squash. Prepared head SHA: 7ce6bd8 Co-authored-by: lml2468 <39320777+lml2468@users.noreply.github.com> Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Reviewed-by: @jalehman * feat(mattermost): add retry logic and timeout handling for DM channel creation (openclaw#42398) Merged via squash. Prepared head SHA: 3db47be Co-authored-by: JonathanJing <17068507+JonathanJing@users.noreply.github.com> Co-authored-by: mukhtharcm <56378562+mukhtharcm@users.noreply.github.com> Reviewed-by: @mukhtharcm * docs(hooks): clarify trust model and audit guidance * test: stabilize memory async search close * refactor: narrow extension public seams * chore: add gog CLI support via custom Docker image Add Dockerfile.gog to extend openclaw:local with the gog binary (Google Workspace CLI). Also forward OPENAI_API_KEY and GEMINI_API_KEY env vars in docker-compose.yml for both services. Made-with: Cursor * chore: inject GOG_KEYRING_PASSWORD for non-interactive gog auth The gog CLI uses a file-based keyring to store Google OAuth tokens. In Docker/headless environments, the keyring prompts for a passphrase interactively, which blocks the agent from running gog autonomously. Setting GOG_KEYRING_PASSWORD as an environment variable allows gog to unlock the keyring without user interaction, enabling the agent to execute Gmail, Calendar, Drive, and other Google Workspace commands directly via the gog skill. Setup steps to enable the gog skill in Docker: 1. Build the custom image: docker build -f Dockerfile.gog -t openclaw:gog . 2. Set OPENCLAW_IMAGE=openclaw:gog in .env 3. Set GOG_KEYRING_PASSWORD= in .env (empty = no passphrase) 4. Run: gog auth keyring file (inside container) 5. Run: gog auth credentials /path/to/client_secret.json 6. Run: gog auth add you@gmail.com --manual 7. Add to openclaw.json: tools.alsoAllow = ["exec", "process"] Made-with: Cursor * docs: add Docker commands reference and Mac migration plan * docs: add docker save/load alternative to migration plan * docs: add Docker+gog env example file * config: clear unused OPENAI_API_KEY and document LLM auth in migration guide * chore: remove .env from git tracking (contains secrets) Made-with: Cursor * docs: add openai-codex auth commands to migration guide * docs: add gog token persistence, exec tool fix, and image migration cases - docker-compose.yml: mount ~/.openclaw/gogcli as volume so gog tokens survive container restarts - docs/docker-commands.html: add case 10 (gog token loss diagnosis + re-auth + volume persistence) - docs/docker-commands.html: add case 11 (exec tool not enabled — tools.alsoAllow fix + persistence explanation) - docs/docker-commands.html: add case 08 (migrate Docker Desktop images to Colima via docker save/load) + TOC entry * docs: add Colima disk lock fix to docker-commands * feat(docker): add local Whisper audio transcription to gog image * docs: update docker-commands with TTS and contact number fixes * docs: add gog token expiry troubleshooting and publish-app fix (caso 12) * docs: add OpenAI Codex rate limit troubleshooting (caso 13) * docs: add model set/status commands to caso 13 * docs: add provider/model switching guide (caso 14) * docs: replace placeholder email with herbert.cadbury.bot@gmail.com --------- Signed-off-by: sallyom <somalley@redhat.com> Co-authored-by: Peter Steinberger <steipete@gmail.com> Co-authored-by: scoootscooob <zhentongfan@gmail.com> Co-authored-by: scoootscooob <167050519+scoootscooob@users.noreply.github.com> Co-authored-by: Josh Lehman <josh@martian.engineering> Co-authored-by: Vincent Koc <vincentkoc@ieee.org> Co-authored-by: Frank Yang <frank.ekn@gmail.com> Co-authored-by: stim64045-spec <stim64045@gmail.com> Co-authored-by: 大禹 <dayu@dayudeMac-mini.local> Co-authored-by: Val Alexander <bunsthedev@gmail.com> Co-authored-by: Val Alexander <68980965+BunsDev@users.noreply.github.com> Co-authored-by: Br1an <932039080@qq.com> Co-authored-by: Br1an67 <29810238+Br1an67@users.noreply.github.com> Co-authored-by: ImLukeF <92253590+ImLukeF@users.noreply.github.com> Co-authored-by: Stable Genius <stablegenius043@gmail.com> Co-authored-by: stablegenius49 <259448942+stablegenius49@users.noreply.github.com> Co-authored-by: Chris Kimpton <chris@kimptoc.net> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Sally O'Malley <somalley@redhat.com> Co-authored-by: huntharo <harold@pwrdrvr.com> Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com> Co-authored-by: Andrew Demczuk <andrew.demczuk@gmail.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> Co-authored-by: Jari Mustonen <jari.mustonen@iki.fi> Co-authored-by: jarimustonen <1272053+jarimustonen@users.noreply.github.com> Co-authored-by: F_ool <112874572+hhhhao28@users.noreply.github.com> Co-authored-by: Kwest OG <50209930+yassinebkr@users.noreply.github.com> Co-authored-by: Yassine <yassinebkr@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Ayaan Zaidi <hi@obviy.us> Co-authored-by: Bob <dutifulbob@gmail.com> Co-authored-by: Onur <2453968+osolmaz@users.noreply.github.com> Co-authored-by: Peter Steinberger <peter@steipete.me> Co-authored-by: Menglin Li <limenglin5911@gmail.com> Co-authored-by: lml2468 <39320777+lml2468@users.noreply.github.com> Co-authored-by: Jonathan Jing <JonathanJing@users.noreply.github.com> Co-authored-by: JonathanJing <17068507+JonathanJing@users.noreply.github.com> Co-authored-by: mukhtharcm <56378562+mukhtharcm@users.noreply.github.com>
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
Signed-off-by: sallyom <somalley@redhat.com>
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
Signed-off-by: sallyom <somalley@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR hardens the SSH sandbox path by normalizing inline SSH material before it is written to disk and by surfacing clearer diagnostics when key loading
fails.
The main issue was malformed inline identity content making it through to the temp identity file in a form that OpenSSH/OpenSSL rejected with error in libcrypto. In practice this showed up when private keys or certs contained CRLF line endings, a BOM, or escaped newline sequences.
What changed
Why
SSH sandbox setup could succeed far enough to create a remote workspace, but later exec calls would fail because the generated identity file was not
usable by ssh. This change makes inline key handling much more tolerant of common formatting issues and makes failures easier to diagnose.
Testing