fix(ui): avoid toSorted in cron suggestions by liuxiaopai-ai · Pull Request #31775 · openclaw/openclaw

liuxiaopai-ai · 2026-03-02T14:29:37Z

Summary

Describe the problem and fix in 2–5 bullets:

Problem: Control UI used Array.prototype.toSorted while computing cron suggestion lists in app-render.
Why it matters: Older browsers without toSorted throw a runtime TypeError, causing Control UI to white-screen.
What changed: Replaced toSorted usage in cron suggestion rendering with a shared compatibility sorter (sortLocaleStrings) and added regression coverage.
What did NOT change (scope boundary): No changes to cron business logic, filtering semantics, or suggestion data sources.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Control UI no longer crashes on cron suggestion rendering in browsers that do not implement Array.prototype.toSorted.

Security Impact (required)

New permissions/capabilities? (No)
Secrets/tokens handling changed? (No)
New/changed network calls? (No)
Command/tool execution surface changed? (No)
Data access scope changed? (No)
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: macOS (dev)
Runtime/container: local Node/pnpm test runtime
Model/provider: N/A
Integration/channel (if any): Control UI
Relevant config (redacted): gateway.controlUi.enabled: true

Steps

Open Control UI with cron section/suggestions active.
Execute render path for cron agent/model suggestion list.
Confirm sorting path does not rely on toSorted.

Expected

UI renders successfully and suggestion lists remain sorted.

Actual

After this change, sorting is performed with Array.from(...).sort(...), avoiding toSorted runtime dependency.

Evidence

Attach at least one:

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Passing tests/checks run locally:

pnpm test ui/src/ui/views/agents-utils.test.ts
pnpm exec oxfmt --check ui/src/ui/app-render.ts ui/src/ui/views/agents-utils.ts ui/src/ui/views/agents-utils.test.ts CHANGELOG.md

Note on repo baseline:

pnpm check fails on pre-existing unrelated TypeScript errors in src/process/exec.windows.test.ts.

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios:
- Cron suggestion sorting in app-render uses compatibility helper.
- Helper sorting behavior is covered by unit tests.
- Existing resolveConfiguredCronModelSuggestions behavior remains sorted.
Edge cases checked:
- Helper accepts iterable inputs (Set, string[]).
What you did not verify:
- Manual runtime test in a real legacy browser (Windows 7 host) during this run.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly:
- Revert this PR commit.
Files/config to restore:
- ui/src/ui/app-render.ts
- ui/src/ui/views/agents-utils.ts
Known bad symptoms reviewers should watch for:
- Cron suggestion lists not sorted or duplicated unexpectedly.

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

Risk: Shared helper reuse could subtly change locale sort behavior versus previous code paths.
- Mitigation: Helper still uses the same localeCompare comparator and regression tests cover expected ordering.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1450bd9da3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ui/src/ui/views/agents-utils.ts

greptile-apps · 2026-03-02T14:34:22Z

Greptile Summary

This PR attempts to fix browser compatibility issues by replacing Array.prototype.toSorted with a custom sortLocaleStrings helper. While the render path (app-render.ts) and config resolution path (agents-utils.ts) have been successfully updated, a critical instance in the controller layer was missed.

Key changes:

Added sortLocaleStrings merge-sort implementation for browser compatibility
Fixed cron suggestion sorting in app-render.ts (2 instances)
Fixed resolveConfiguredCronModelSuggestions in agents-utils.ts (1 instance)
Added basic test coverage for the new helper

Critical issue:

ui/src/ui/controllers/cron.ts:210 still uses toSorted in loadCronModelSuggestions, which will cause the same TypeError in older browsers that this PR aims to fix

Confidence Score: 1/5

This PR is NOT safe to merge - it leaves a critical browser compatibility bug unfixed
The PR has a critical logical error: ui/src/ui/controllers/cron.ts:210 still uses toSorted, which defeats the entire purpose of this browser compatibility fix. The controller will still crash in older browsers when loading model suggestions, making the fix incomplete.
Pay close attention to ui/src/ui/controllers/cron.ts - it contains unfixed toSorted usage that will cause runtime errors

_{Last reviewed commit: 91af29e}

greptile-apps

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

ui/src/ui/views/agents-utils.ts

liuxiaopai-ai · 2026-03-02T15:13:44Z

Addressed. sortLocaleStrings now uses Array.from(values).sort(...) instead of toSorted, so the compatibility helper no longer depends on newer Array APIs.

Validation run:

pnpm test ui/src/ui/views/agents-utils.test.ts

liuxiaopai-ai · 2026-03-02T15:18:20Z

Follow-up pushed in commit 024b3ff to ensure the helper itself no longer uses toSorted.

Current implementation:

sortLocaleStrings(values) -> Array.from(values).sort((a, b) => a.localeCompare(b))

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8145c66e79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ui/src/ui/views/agents-utils.ts

vincentkoc · 2026-03-02T15:34:45Z

Addressed the review items on this branch:

sortLocaleStrings no longer depends on Array.prototype.toSorted.
Removed the unnecessary as string assertions that were triggering lint (typescript-eslint/no-unnecessary-type-assertion) in that helper.
Updated CHANGELOG.md entry for this fix with #31775 and Thanks @liuxiaopai-ai.

Current CI is still blocked by an existing unrelated Bun lane test failure in src/cron/isolated-agent.uses-last-non-empty-agent-text-as.test.ts (expected openai vs anthropic, plus downstream EPIPE), which does not touch the Control UI cron-suggestion sort path.

vincentkoc · 2026-03-02T15:36:15Z

Implemented both remaining review items on the canonical branch:

removed toSorted from sortLocaleStrings
replaced insertion sort with Array.from(values).sort((a, b) => a.localeCompare(b)) for legacy-safe + O(n log n)

This also resolves the earlier performance comment in the helper path. Current head commit: c72b855c5.

There are still 2 unresolved review threads in the PR UI (legacy bot comments), but they are now addressed by this commit; please mark those as resolved if you want.

vincentkoc · 2026-03-02T15:38:09Z

Updated sortLocaleStrings again to satisfy both compatibility and lint constraints: replaced Array.sort with an in-file merge-sort implementation (O(n log n)) that uses only localeCompare.

No toSorted dependency remains.
No Array#sort dependency remains.
Merge-sort path avoids the insertion-sort O(n²) perf regression flagged on the PR.

Latest commit on this branch: 7168d511f.

vincentkoc · 2026-03-02T15:41:03Z

@greptileai review

vincentkoc · 2026-03-02T15:42:19Z

Addressed the format check failure in ui/src/ui/views/agents-utils.ts by running oxfmt on the file via bunx oxfmt --write.
Commit: 1c87cdb80 (format-only).

The only changed file is:

ui/src/ui/views/agents-utils.ts

Checks should re-run now from this head.

vincentkoc · 2026-03-02T15:45:00Z

I fixed the remaining oxfmt check issue by formatting with the repo's pinned formatter version:

Ran bunx oxfmt@0.0.0 ???? Wait version is actually 0.35.0.
ui/src/ui/views/agents-utils.ts now passes oxfmt --check locally with bunx oxfmt@0.35.0 --check.
Head commit: 91af29ed4.

Please re-run the CI check; it should clear the format failure if this head is being evaluated.

greptile-apps · 2026-03-02T15:48:16Z

Additional Comments (1)

ui/src/ui/controllers/cron.ts, line 210
still uses toSorted which doesn't exist in older browsers and will cause the same TypeError this PR is meant to fix

    state.cronModelSuggestions = sortLocaleStrings(new Set(ids));

also need to import sortLocaleStrings from ../views/agents-utils.ts at the top of the file

* Control UI: avoid toSorted in cron suggestions * Control UI: make sortLocaleStrings legacy-safe * fix(ui): use sort fallback in locale string helper * fix(ui): remove toSorted from locale helper * fix(ui): remove toSorted from locale helper * fix(ui): remove toSorted from locale helper * fix(ui): remove toSorted from locale helper * fix(ui): remove toSorted from locale helper * fix(ui): avoid sort in locale helper for browser compatibility * ui: avoid unnecessary assertions in locale sort * changelog: credit browser-compat cron fix PR * fix(ui): use native locale sort in compatibility helper * ui: use compat merge-sort for locale strings * style: format locale sort helper * style: fix oxfmt ordering in agents utils --------- Co-authored-by: Vincent Koc <vincentkoc@ieee.org>

openclaw-barnacle bot added app: web-ui App: web-ui size: XS experienced-contributor labels Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

ui/src/ui/views/agents-utils.ts Outdated Show resolved Hide resolved

greptile-apps bot reviewed Mar 2, 2026

View reviewed changes

ui/src/ui/views/agents-utils.ts Outdated Show resolved Hide resolved

vincentkoc added the dedupe:parent Primary canonical item in dedupe cluster label Mar 2, 2026

liuxiaopai-ai and others added 10 commits March 2, 2026 07:27

Control UI: avoid toSorted in cron suggestions

e500ac3

Control UI: make sortLocaleStrings legacy-safe

e19933b

fix(ui): use sort fallback in locale string helper

60769d2

fix(ui): remove toSorted from locale helper

a668eef

fix(ui): remove toSorted from locale helper

7d1a48d

fix(ui): remove toSorted from locale helper

8e50c75

fix(ui): remove toSorted from locale helper

8f1b5c0

fix(ui): remove toSorted from locale helper

b22cfa4

fix(ui): avoid sort in locale helper for browser compatibility

8e2944d

ui: avoid unnecessary assertions in locale sort

748f6ee

vincentkoc added 2 commits March 2, 2026 07:27

ui: avoid unnecessary assertions in locale sort

748f6ee

changelog: credit browser-compat cron fix PR

8145c66

vincentkoc force-pushed the codex/control-ui-no-tosorted-30467 branch from 72ec607 to 8145c66 Compare March 2, 2026 15:27

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

ui/src/ui/views/agents-utils.ts Outdated Show resolved Hide resolved

fix(ui): use native locale sort in compatibility helper

c72b855

vincentkoc force-pushed the codex/control-ui-no-tosorted-30467 branch from 816d1ae to c72b855 Compare March 2, 2026 15:36

ui: use compat merge-sort for locale strings

7168d51

openclaw-barnacle bot added size: S and removed size: XS labels Mar 2, 2026

style: format locale sort helper

1c87cdb

vincentkoc force-pushed the codex/control-ui-no-tosorted-30467 branch from ea44306 to 1c87cdb Compare March 2, 2026 15:42

style: fix oxfmt ordering in agents utils

91af29e

steipete mentioned this pull request Mar 2, 2026

fix(ui): replace Array.prototype.toSorted with sort for browser compatibility #31849

Closed

2 tasks

Merge branch 'main' into codex/control-ui-no-tosorted-30467

9a93765

vincentkoc merged commit 5b5ccb0 into openclaw:main Mar 2, 2026
8 of 9 checks passed

Uh oh!

Conversation

liuxiaopai-ai commented Mar 2, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

greptile-apps bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 1/5

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

liuxiaopai-ai commented Mar 2, 2026

Uh oh!

liuxiaopai-ai commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

vincentkoc commented Mar 2, 2026

Uh oh!

vincentkoc commented Mar 2, 2026

Uh oh!

vincentkoc commented Mar 2, 2026

Uh oh!

vincentkoc commented Mar 2, 2026

Uh oh!

vincentkoc commented Mar 2, 2026

Uh oh!

vincentkoc commented Mar 2, 2026

Uh oh!

greptile-apps bot commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps bot commented Mar 2, 2026 •

edited

Loading

greptile-apps bot left a comment •

edited

Loading