fix(nextcloud-talk): use plugin-sdk abort helper export#31769
Closed
liuxiaopai-ai wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(nextcloud-talk): use plugin-sdk abort helper export#31769liuxiaopai-ai wants to merge 1 commit intoopenclaw:mainfrom
liuxiaopai-ai wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryFixed module resolution issue where the
Confidence Score: 5/5
Last reviewed commit: 7d00d0f |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
nextcloud-talkextension importedwaitForAbortSignalvia a repo-relative../../../src/infra/abort-signal.jspath.waitForAbortSignalfromopenclaw/plugin-sdk, switched Nextcloud Talk to consume the public SDK export, and added a regression test for plugin-sdk export availability.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
openclaw/plugin-sdkentrypoint.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
channels.nextcloud-talkenabledSteps
openclaw/plugin-sdkonly.Expected
Actual
src/infra/abort-signalresolution path is required.Evidence
Attach at least one:
Passing tests/checks run locally:
pnpm test src/plugin-sdk/index.test.ts extensions/nextcloud-talk/src/channel.startup.test.tspnpm exec oxfmt --check src/plugin-sdk/index.test.ts src/plugin-sdk/index.ts extensions/nextcloud-talk/src/channel.ts CHANGELOG.mdNote on repo baseline:
pnpm checkstill fails on pre-existing unrelated TypeScript errors in:src/process/exec.windows.test.tssrc/slack/monitor/events/messages.tsHuman Verification (required)
What you personally verified (not just CI), and how:
waitForAbortSignalis exported from plugin-sdk.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
src/plugin-sdk/index.tsextensions/nextcloud-talk/src/channel.tswaitForAbortSignalfrom plugin-sdk.Risks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.