Skip to content

fix(slack): type message.channels/group handlers#31758

Merged
Takhoffman merged 1 commit intomainfrom
fix/slack-message-event-typing-gate
Mar 2, 2026
Merged

fix(slack): type message.channels/group handlers#31758
Takhoffman merged 1 commit intomainfrom
fix/slack-message-event-typing-gate

Conversation

@Takhoffman
Copy link
Contributor

@Takhoffman Takhoffman commented Mar 2, 2026

Summary

  • Fixes a global TypeScript gate failure in Slack monitor event registration.
  • Type message.channels and message.groups handlers with explicit SlackEventMiddlewareArgs<...> generics.
  • Keeps runtime behavior unchanged; this is compile-time typing correctness only.

Change Type

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

User-visible / Behavior Changes

None (typing-only fix for build gate).

Security Impact

  • New permissions/capabilities? No
  • Secrets/tokens handling changed? No
  • New/changed network calls? No
  • Command/tool execution surface changed? No
  • Data access scope changed? No

Repro + Verification

Environment

  • OS: macOS
  • Runtime/container: Node 22 + pnpm

Steps

  1. Build current branch.
  2. Confirm no TS2769 in src/slack/monitor/events/messages.ts.

Evidence

  • pnpm build passes.
  • pnpm check passes.
  • pnpm test:macmini passes.

Compatibility / Migration

  • Backward compatible? Yes
  • Config/env changes? No
  • Migration needed? No

Failure Recovery

  • Revert this single commit.

@openclaw-barnacle openclaw-barnacle bot added channel: slack Channel integration: slack size: XS maintainer Maintainer-authored PR labels Mar 2, 2026
@Takhoffman Takhoffman merged commit 1fe0f84 into main Mar 2, 2026
11 checks passed
@Takhoffman Takhoffman deleted the fix/slack-message-event-typing-gate branch March 2, 2026 14:09
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Adds explicit type parameters to message.channels and message.groups event handlers, fixing a TypeScript compilation error (TS2769).

  • Types both handlers with SlackEventMiddlewareArgs<"message.channels"> and SlackEventMiddlewareArgs<"message.groups"> respectively
  • Brings consistency with other event handlers in the same file (message and app_mention already use typed generics)
  • Reformats the handler declarations for improved readability
  • No runtime behavior changes; this is purely a compile-time type safety improvement

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Compile-time only TypeScript typing fix with no runtime changes. The change follows established patterns in the codebase, has existing test coverage, and resolves a build gate failure.
  • No files require special attention

Last reviewed commit: f24ca6d

@github-actions github-actions bot mentioned this pull request Mar 2, 2026
Open
hanqizheng pushed a commit to hanqizheng/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman
fix(slack): type message.channels/group handlers (openclaw#31758)
36dea9e
obviyus pushed a commit that referenced this pull request Mar 2, 2026
@Takhoffman @obviyus
fix(slack): type message.channels/group handlers (#31758)
922d8f5
Linux2010 pushed a commit to Linux2010/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @Linux2010
fix(slack): type message.channels/group handlers (openclaw#31758)
c7ca5c8
This was referenced Mar 2, 2026
Closed
Merged
@sourman sourman mentioned this pull request Mar 2, 2026
Closed
execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @execute008
fix(slack): type message.channels/group handlers (openclaw#31758)
0d3f3bd
dawi369 pushed a commit to dawi369/davis that referenced this pull request Mar 3, 2026
@Takhoffman @dawi369
fix(slack): type message.channels/group handlers (openclaw#31758)
b1c5f18
OWALabuy pushed a commit to kcinzgg/openclaw that referenced this pull request Mar 4, 2026
@Takhoffman @OWALabuy
fix(slack): type message.channels/group handlers (openclaw#31758)
b8fddc0
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
@Takhoffman
fix(slack): type message.channels/group handlers (openclaw#31758)
3f0dbed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

channel: slack Channel integration: slack maintainer Maintainer-authored PR size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Takhoffman