fix(exec): resolve PATH key case-insensitively for Windows pathPrepend#28821
Closed
Glucksberg wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(exec): resolve PATH key case-insensitively for Windows pathPrepend#28821Glucksberg wants to merge 1 commit intoopenclaw:mainfrom
Glucksberg wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
You have reached your Codex rate limits. Please try again later. |
Contributor
Greptile SummaryFixed Windows-specific bug where PATH environment variable prepending would create a duplicate uppercase
Confidence Score: 5/5
Last reviewed commit: a2ea6bc |
nikolasdehor
approved these changes
Feb 27, 2026
nikolasdehor
left a comment
There was a problem hiding this comment.
Clean fix for Windows PATH case sensitivity. The findPathKey helper with uppercase-first preference is correct. Good test coverage for all case combinations.
This was referenced Mar 2, 2026
Contributor
|
Thanks again for the original patch and investigation here. I’m closing this PR as superseded by #31879, which carries the same fix and was merged after this PR became blocked by a persistent GitHub head-ref sync issue. Credit for the original fix remains with @Glucksberg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code