Slack onboarding: improve token help note with manifest option#30846
Slack onboarding: improve token help note with manifest option#30846Takhoffman merged 2 commits intomainfrom
Conversation
🔒 Aisle Security Analysis✅ We scanned this PR and did not find any security vulnerabilities. Aisle supplements but does not replace security review. Analyzed PR: #30846 at commit Last updated on: 2026-03-01T18:00:45Z |
Greptile SummaryThis PR is a copy-only UX improvement to the Slack onboarding wizard's token-help note ( Key observations:
Confidence Score: 5/5
Last reviewed commit: 8b993d1 |
| "1) Slack API → Create App → From scratch or From manifest (with the JSON below)", | ||
| "2) Add Socket Mode + enable it to get the app-level token (xapp-...)", | ||
| "3) OAuth & Permissions → install app to workspace (xoxb- bot token)", | ||
| "3) Install App to workspace to get the xoxb- bot token", |
There was a problem hiding this comment.
Lost navigation hint for "From scratch" flow
The old wording "OAuth & Permissions → install app to workspace (xoxb- bot token)" included a navigational path that guided users who chose "From scratch" — they need to first go to OAuth & Permissions to add scopes before they can install the app. The updated line drops that hint.
For the "From manifest" flow this is a non-issue (scopes are pre-configured in the manifest JSON), but "From scratch" users may attempt to install without having added scopes first, leading to a confusing failure.
Consider preserving the guidance, for example:
| "3) Install App to workspace to get the xoxb- bot token", | |
| "3) Install App to workspace to get the xoxb- bot token (From scratch: add OAuth scopes under OAuth & Permissions first)", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/channels/plugins/onboarding/slack.ts
Line: 104
Comment:
**Lost navigation hint for "From scratch" flow**
The old wording `"OAuth & Permissions → install app to workspace (xoxb- bot token)"` included a navigational path that guided users who chose "From scratch" — they need to first go to **OAuth & Permissions** to add scopes before they can install the app. The updated line drops that hint.
For the "From manifest" flow this is a non-issue (scopes are pre-configured in the manifest JSON), but "From scratch" users may attempt to install without having added scopes first, leading to a confusing failure.
Consider preserving the guidance, for example:
```suggestion
"3) Install App to workspace to get the xoxb- bot token (From scratch: add OAuth scopes under OAuth & Permissions first)",
```
How can I resolve this? If you propose a fix, please make it concise.8b993d1 to
11ed2fe
Compare
|
PR #30846 - Slack onboarding: improve token help note with manifest option (#30846) Merged via squash.
Thanks @yzhong52! |
…law#30846) thanks @yzhong52 Cherry-pick of upstream a179a0d.
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Verified: - pnpm install --frozen-lockfile - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
…law#30846) thanks @yzhong52 Cherry-pick of upstream a179a0d.
Summary
Changes
1) Slack API → Create App → From scratch or From manifest (with the JSON below)3) Install App to workspace to get the xoxb- bot tokenScope
src/channels/plugins/onboarding/slack.tsCredit
Supersedes