Skip to content

Slack onboarding: improve token help note with manifest option#30846

Merged
Takhoffman merged 2 commits intomainfrom
salvage/slack-onboarding-manifest-copy-28110
Mar 1, 2026
Merged

Slack onboarding: improve token help note with manifest option#30846
Takhoffman merged 2 commits intomainfrom
salvage/slack-onboarding-manifest-copy-28110

Conversation

@Takhoffman
Copy link
Contributor

Summary

Changes

  • 1) Slack API → Create App → From scratch or From manifest (with the JSON below)
  • 3) Install App to workspace to get the xoxb- bot token

Scope

  • Single file change: src/channels/plugins/onboarding/slack.ts
  • No logic/runtime behavior changes; copy-only UX improvement.

Credit

Supersedes

@aisle-research-bot
Copy link

aisle-research-bot bot commented Mar 1, 2026

🔒 Aisle Security Analysis

✅ We scanned this PR and did not find any security vulnerabilities.

Aisle supplements but does not replace security review.


Analyzed PR: #30846 at commit 11ed2fe

Last updated on: 2026-03-01T18:00:45Z

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 1, 2026

Greptile Summary

This PR is a copy-only UX improvement to the Slack onboarding wizard's token-help note (noteSlackTokenHelp). It updates two string literals: step 1 now advertises the "From manifest" option alongside "From scratch" (the manifest JSON was already rendered below the note), and step 3 is reworded to more plainly describe installing the app to get the bot token.

Key observations:

  • No logic, runtime, or behavioral changes — purely display text.
  • The addition of "From manifest" in step 1 is a valuable improvement: it makes the already-present manifest JSON block discoverable upfront.
  • Step 3 loses the "OAuth & Permissions →" navigation hint that was useful for users taking the "From scratch" path, who still need to configure OAuth scopes before installing. Consider retaining that guidance for the scratch flow.

Confidence Score: 5/5

  • This PR is safe to merge — it contains only two string literal changes with no logic or runtime impact.
  • The change is confined to display copy inside a single prompter.note(...) call. There are no algorithmic, API, or configuration changes, making regressions essentially impossible.
  • No files require special attention beyond the minor style note on step 3 in src/channels/plugins/onboarding/slack.ts.

Last reviewed commit: 8b993d1

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

"1) Slack API → Create App → From scratch or From manifest (with the JSON below)",
"2) Add Socket Mode + enable it to get the app-level token (xapp-...)",
"3) OAuth & Permissions → install app to workspace (xoxb- bot token)",
"3) Install App to workspace to get the xoxb- bot token",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost navigation hint for "From scratch" flow

The old wording "OAuth & Permissions → install app to workspace (xoxb- bot token)" included a navigational path that guided users who chose "From scratch" — they need to first go to OAuth & Permissions to add scopes before they can install the app. The updated line drops that hint.

For the "From manifest" flow this is a non-issue (scopes are pre-configured in the manifest JSON), but "From scratch" users may attempt to install without having added scopes first, leading to a confusing failure.

Consider preserving the guidance, for example:

Suggested change
"3) Install App to workspace to get the xoxb- bot token",
"3) Install App to workspace to get the xoxb- bot token (From scratch: add OAuth scopes under OAuth & Permissions first)",
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/channels/plugins/onboarding/slack.ts
Line: 104

Comment:
**Lost navigation hint for "From scratch" flow**

The old wording `"OAuth & Permissions → install app to workspace (xoxb- bot token)"` included a navigational path that guided users who chose "From scratch" — they need to first go to **OAuth & Permissions** to add scopes before they can install the app. The updated line drops that hint.

For the "From manifest" flow this is a non-issue (scopes are pre-configured in the manifest JSON), but "From scratch" users may attempt to install without having added scopes first, leading to a confusing failure.

Consider preserving the guidance, for example:

```suggestion
      "3) Install App to workspace to get the xoxb- bot token (From scratch: add OAuth scopes under OAuth & Permissions first)",
```

How can I resolve this? If you propose a fix, please make it concise.

@Takhoffman Takhoffman force-pushed the salvage/slack-onboarding-manifest-copy-28110 branch from 8b993d1 to 11ed2fe Compare March 1, 2026 17:57
@Takhoffman Takhoffman merged commit a179a0d into main Mar 1, 2026
10 checks passed
@Takhoffman Takhoffman deleted the salvage/slack-onboarding-manifest-copy-28110 branch March 1, 2026 17:57
@Takhoffman
Copy link
Contributor Author

PR #30846 - Slack onboarding: improve token help note with manifest option (#30846)

Merged via squash.

  • Merge commit: a179a0d
  • Verified: pnpm install --frozen-lockfile, pnpm build, pnpm check, pnpm test:macmini
  • Changes made:
    M CHANGELOG.md
    M src/channels/plugins/onboarding/slack.ts
  • Why these changes were made:
    Preserved the original Slack onboarding: improve token help note with manifest option #28110 onboarding wording improvement on a safe feature branch and added required changelog coverage for autoland policy.
  • Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @yzhong52!

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 1, 2026
ansh pushed a commit to vibecode/openclaw that referenced this pull request Mar 2, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request Mar 2, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
amitmiran137 pushed a commit to amitmiran137/openclaw that referenced this pull request Mar 2, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request Mar 2, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
hanqizheng pushed a commit to hanqizheng/openclaw that referenced this pull request Mar 2, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request Mar 3, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request Mar 6, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
…law#30846) thanks @yzhong52

Verified:
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: yzhong52 <3712071+yzhong52@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant