Skip to content

Slack onboarding: improve token help note with manifest option#28110

Closed
yzhong52 wants to merge 2 commits intoopenclaw:mainfrom
yzhong52:main
Closed

Slack onboarding: improve token help note with manifest option#28110
yzhong52 wants to merge 2 commits intoopenclaw:mainfrom
yzhong52:main

Conversation

@yzhong52
Copy link
Contributor

Summary

  • Problem: The Slack onboarding wizard's token-help note gave only a "From scratch" path and used a slightly ambiguous label for step 3.
  • Why it matters: Users setting up Slack via the manifest path had no guidance in the wizard; they had to discover the "From manifest" option on their own.
  • What changed: Updated two instruction strings in noteSlackTokenHelp — step 1 now mentions the "From manifest" option, and step 3 clarifies the install-to-workspace wording.
  • What did NOT change: No logic, config schema, token handling, or runtime behavior was modified.

See this screenshot, there is a from manifest option which is much better than from scratch:

Screenshot 2026-02-26 at 5 18 05 PM

See this screenshot, install app is no longer under Auth & Permission session:

Screenshot 2026-02-26 at 5 18 52 PM

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

  • Closes #
  • Related #

User-visible / Behavior Changes

The Slack onboarding wizard now shows "From scratch or From manifest (with the JSON below)" for step 1, and "Installed App to workspace to get the xoxb- bot token" for step 3.

Security Impact (required)

  • New permissions/capabilities? No
  • Secrets/tokens handling changed? No
  • New/changed network calls? No
  • Command/tool execution surface changed? No
  • Data access scope changed? No

Repro + Verification

Environment

  • OS: macOS
  • Runtime/container: Node 22+
  • Model/provider: N/A
  • Integration/channel (if any): Slack
  • Relevant config (redacted): N/A

Steps

  1. Run openclaw onboard (or openclaw channels configure --channel slack)
  2. Reach the token-setup step for a new Slack account
  3. Observe the printed help note

Expected

  • Step 1 mentions both "From scratch" and "From manifest" options
  • Step 3 reads "Installed App to workspace to get the xoxb- bot token"

Actual

  • (Before) Step 1 only mentioned "From scratch"; step 3 referenced "OAuth & Permissions" tab

Evidence

  • Failing test/log before + passing after
  • Trace/log snippets
  • Screenshot/recording
  • Perf numbers (if relevant)

(String-only change; no test change required.)

Human Verification (required)

  • Verified scenarios: Diff reviewed; strings match intended wording.
  • Edge cases checked: No logic paths affected — text is inside a prompter.note() call only.
  • What you did not verify: Full end-to-end Slack onboarding wizard run.

Compatibility / Migration

  • Backward compatible? Yes
  • Config/env changes? No
  • Migration needed? No

Failure Recovery (if this breaks)

  • How to disable/revert: git revert 250218bbc
  • Files/config to restore: src/channels/plugins/onboarding/slack.ts
  • Known bad symptoms: None expected; change is display-text only.

Risks and Mitigations

None.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Improves Slack onboarding help text by mentioning the "From manifest" option (alongside "From scratch") and updating the install instruction to reflect Slack's UI changes.

  • Step 1 now mentions both setup paths: "From scratch or From manifest (with the JSON below)"
  • Step 3 updated to reflect that app installation is no longer under OAuth & Permissions
  • Text-only change with no logic, config, or runtime modifications
  • One minor grammatical issue: step 3 uses "Installed" (past tense) instead of "Install" (imperative) which is inconsistent with other steps

Confidence Score: 4/5

  • Safe to merge with one minor grammatical fix needed
  • Text-only documentation change with no logic modifications. The one grammatical issue (using "Installed" instead of "Install") is easily fixable and doesn't affect functionality.
  • No files require special attention - single documentation string update

Last reviewed commit: 250218b

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@Takhoffman
Copy link
Contributor

Closing as superseded by #30846. Credit for the original idea and wording direction goes to @yzhong52.

@Takhoffman Takhoffman closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants