Skip to content

fix(feishu): honor wildcard group config for reply policy#29456

Merged
Takhoffman merged 2 commits intomainfrom
fix/feishu-wildcard-group-config-v2
Feb 28, 2026
Merged

fix(feishu): honor wildcard group config for reply policy#29456
Takhoffman merged 2 commits intomainfrom
fix/feishu-wildcard-group-config-v2

Conversation

@Takhoffman
Copy link
Contributor

@Takhoffman Takhoffman commented Feb 28, 2026

Summary

  • Apply groups["*"] fallback in resolveFeishuGroupConfig when no exact/case-insensitive group match exists.
  • Preserve precedence order: exact match > case-insensitive explicit match > wildcard fallback.
  • Add focused tests covering wildcard fallback and precedence behavior.

Why

This keeps Feishu group reply policy consistent with configured wildcard behavior instead of falling back to global defaults for unmatched groups.

Verification

  • pnpm exec oxfmt --check extensions/feishu/src/policy.ts extensions/feishu/src/policy.test.ts
  • pnpm exec vitest run --config vitest.extensions.config.ts extensions/feishu/src/policy.test.ts

Supersedes the stale/conflicted implementation in #19254 with a minimal current-main patch.

@openclaw-barnacle openclaw-barnacle bot added channel: feishu Channel integration: feishu size: S maintainer Maintainer-authored PR labels Feb 28, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Adds wildcard group config fallback to resolveFeishuGroupConfig in extensions/feishu/src/policy.ts. When a group ID doesn't match any explicit configuration (exact or case-insensitive), the function now falls back to groups["*"] wildcard config instead of returning undefined.

Key Changes:

  • Modified resolveFeishuGroupConfig to store and return wildcard config as final fallback
  • Maintains correct precedence: exact match → case-insensitive match → wildcard fallback
  • Added three focused unit tests verifying the new behavior and precedence order

Impact:
This ensures unmatched Feishu groups honor the configured wildcard policy (e.g., requireMention, allowFrom, replyInThread) instead of falling back to global defaults. The change is backward compatible—if no wildcard is configured, behavior remains unchanged.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Clean, focused implementation with only 3 lines changed in production code. The logic correctly implements the stated precedence order, maintains type safety with existing schemas, and includes comprehensive test coverage. No breaking changes—backward compatible when wildcard is not configured.
  • No files require special attention

Last reviewed commit: e328aa5

@Takhoffman Takhoffman merged commit 60bf565 into main Feb 28, 2026
10 checks passed
@Takhoffman Takhoffman deleted the fix/feishu-wildcard-group-config-v2 branch February 28, 2026 05:22
@Takhoffman
Copy link
Contributor Author

Takhoffman commented Feb 28, 2026

Merged via squash in #29456.

Thanks @WaynePika for the original fix direction and follow-through here; carried that forward into the landed patch.

Merged commit: 60bf565

Verified before merge:

  • pnpm install --frozen-lockfile
  • pnpm build
  • pnpm check
  • pnpm test:macmini

@Takhoffman Takhoffman mentioned this pull request Feb 28, 2026
Closed
@github-actions github-actions bot mentioned this pull request Feb 28, 2026
Open
r4jiv007 pushed a commit to r4jiv007/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika @r4jiv007
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
4542fc1 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
mylukin pushed a commit to mylukin/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika @mylukin
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
3a956db 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika @wanjizheng
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
fd292a2 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika @wanjizheng
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
2fda76a 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
(cherry picked from commit fd292a2)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika @wanjizheng
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
7dc7f5f 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
(cherry picked from commit fd292a2)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika @wanjizheng
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
33e1066 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
(cherry picked from commit fd292a2)
vincentkoc pushed a commit to Sid-Qin/openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika @vincentkoc
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
cbb8d51 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
vincentkoc pushed a commit to rylena/rylen-openclaw that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika @vincentkoc
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
6aa96d7 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
newtontech pushed a commit to newtontech/openclaw-fork that referenced this pull request Feb 28, 2026
@Takhoffman @WaynePika
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
85b18b9 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
@Takhoffman @WaynePika @wanjizheng
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
c6842c5 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
@Takhoffman @WaynePika @wanjizheng
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
5535e73 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Mar 1, 2026
Closed
6 tasks
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026
@Takhoffman @WaynePika @github-actions
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
b72dd00 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
(cherry picked from commit 60bf565)
@gemini-code-assist gemini-code-assist bot mentioned this pull request Mar 1, 2026
Merged
zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 1, 2026
@zooqueen
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
42b1040 
…9456)

Cherry-pick of upstream 60bf565.
ansh pushed a commit to vibecode/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @WaynePika @ansh
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
8861a5f 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @WaynePika @steipete
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
8ee71e8 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
This was referenced Mar 2, 2026
Closed
Closed
safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request Mar 2, 2026
@Takhoffman @WaynePika @safzanpirani
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
78a2d55 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @WaynePika @steipete
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
381580d 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
venjiang pushed a commit to venjiang/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @WaynePika @venjiang
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
0a47922 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @WaynePika
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
742f879 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026
@Takhoffman @WaynePika @execute008
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
15b10af 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026
@Takhoffman @WaynePika @github-actions
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
216f625 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
(cherry picked from commit 60bf565)
dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request Mar 3, 2026
@Takhoffman @WaynePika @dorgonman
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
a75fc92 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request Mar 6, 2026
@Takhoffman @WaynePika
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
6966b4d 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
@zooqueen
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
2cfb3f0 
…9456)

Cherry-pick of upstream 60bf565.
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
@Takhoffman @WaynePika
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
af95f5a 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
Mateljan1 pushed a commit to Mateljan1/openclaw that referenced this pull request Mar 7, 2026
@Takhoffman @WaynePika @Mateljan1
fix(feishu): honor wildcard group config for reply policy (openclaw#2…
05e83af 
…9456)

## Summary
- honor Feishu wildcard group policy fallback via `channels.feishu.groups["*"]` when no explicit group entry matches
- keep exact and case-insensitive explicit group matches higher precedence than wildcard fallback
- add changelog credit and TypeScript-safe test assertions

## Verification
- pnpm install --frozen-lockfile
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: Wayne Pika <262095977+WaynePika@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

channel: feishu Channel integration: feishu maintainer Maintainer-authored PR size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Takhoffman