fix(feishu): honor wildcard group config for reply policy#19254
Closed
WaynePika wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(feishu): honor wildcard group config for reply policy#19254WaynePika wants to merge 1 commit intoopenclaw:mainfrom
WaynePika wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
This pull request has been automatically marked as stale due to inactivity. |
Contributor
|
Thanks again for this work and for surfacing the fix. Closing this PR as superseded by #29456, which lands the same behavior on current main with full verification and preserved credit. Really appreciate the contribution. |
Contributor
Author
|
My honor and appreciation as well Tak.
…On Sat, Feb 28, 2026 at 1:24 PM Tak Hoffman ***@***.***> wrote:
*Takhoffman* left a comment (openclaw/openclaw#19254)
<#19254 (comment)>
Thanks again for this work and for surfacing the fix.
Closing this PR as superseded by #29456
<#29456>, which lands the same
behavior on current main with full verification and preserved credit.
Really appreciate the contribution.
—
Reply to this email directly, view it on GitHub
<#19254 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B6PUI2PNFD2YWUMEDDC5MCL4OERALAVCNFSM6AAAAACVNOR6DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNZWGQZDGOBQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Feishu group wildcard policy handling so
channels.feishu.groups["*"]is applied when a specific group ID entry is missing.Without this fallback, wildcard group settings (for example
requireMention: false) are ignored for unmatched groups, causing group behavior to unexpectedly fall back to global defaults.Changes
extensions/feishu/src/policy.tsresolveFeishuGroupConfig, return the wildcard group config (groups["*"]) when no exact/case-insensitive match exists.extensions/feishu/src/policy.test.ts(new)Repro
channels.feishu.groups["*"].requireMention = falseBefore
The wildcard was not applied; message could still be treated as mention-gated.
After
The wildcard config is applied; behavior follows
groups["*"]as expected.Validation
pnpm exec vitest run --config vitest.extensions.config.ts extensions/feishu/src/policy.test.ts1 passed,3 passedGreptile Summary
Adds wildcard fallback logic to
resolveFeishuGroupConfigso thatchannels.feishu.groups["*"]configuration is properly applied when no explicit group ID match exists. This fixes unintended fallback to global defaults for unconfigured groups.groups["*"]) after exhausting exact and case-insensitive matchingConfidence Score: 5/5
Last reviewed commit: 2e8ec64
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!