fix(voice-call): play inbound greeting for Twilio answered calls by xinhuagu · Pull Request #29121 · openclaw/openclaw

xinhuagu · 2026-02-27T20:36:53Z

Summary

remove the Twilio early-return in CallManager.maybeSpeakInitialMessageOnAnswered
let Twilio follow the same initial-message path as other providers when calls are answered
expand manager tests to assert notify-mode initial greeting is spoken for both Plivo and Twilio

Why

Inbound Twilio calls were creating metadata.initialMessage but never speaking it, because answered-call handling explicitly skipped Twilio.

Fixes #29101

Testing

pnpm -C openclaw-repo test extensions/voice-call/src/manager.test.ts

greptile-apps · 2026-02-27T20:39:57Z

Greptile Summary

Removes Twilio-specific early-return in maybeSpeakInitialMessageOnAnswered that was preventing inbound Twilio calls from speaking the initial greeting. The Twilio provider has built-in fallback handling for TTS failures, so this special case is no longer needed.

Key changes:

Removed 6 lines from extensions/voice-call/src/manager.ts:157 that skipped Twilio in the answered-call handler
Updated test to verify both Plivo and Twilio providers speak initial message in notify mode using it.each

Testing:

All 13 tests pass including the new parameterized test that validates both providers
Fixes [Bug]: voice-call plugin: inboundGreeting not used for Twilio inbound calls #29101 where Twilio inbound calls were not speaking the configured greeting

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The change is a straightforward bug fix that removes an overly cautious early-return. The Twilio provider already has robust fallback handling for TTS failures (extensions/voice-call/src/providers/twilio.ts:563-599), so the removed special case is unnecessary. Tests now explicitly verify both providers work correctly, and all 13 tests pass.
No files require special attention

_{Last reviewed commit: 39f45e3}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39f45e38f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T20:40:09Z

extensions/voice-call/src/manager.ts

-      return;
-    }
-
    void this.speakInitialMessage(call.providerCallId);


Reintroduce Twilio skip for answered-message playback

Calling speakInitialMessage unconditionally on call.answered now affects Twilio notify calls, but Twilio notify mode already injects a one-shot <Say><Hangup/> TwiML in initiateCall. This means answered callbacks can trigger a second playTts update that overwrites the notify flow (potentially replacing immediate hangup with <Gather>) or fails after the call has already ended, and either way initialMessage gets cleared so it cannot be retried on stream connect. This regression is specific to Twilio answered events and changes notify-call behavior from single-play/auto-end to duplicate or inconsistent playback.

Useful? React with 👍 / 👎.

xinhuagu · 2026-02-28T08:54:35Z

@chatgpt-codex-connector Good catch on Twilio notify-mode behavior. I rebased this PR and will validate answered-event playback against the existing Twilio Say+Hangup flow to avoid duplicate/overwriting playback. If conflict is confirmed, I will restore the Twilio guard (or narrow the condition) and update tests accordingly.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71a11386cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T08:54:57Z

extensions/voice-call/src/manager.ts

-      return;
-    }
-
    void this.speakInitialMessage(call.providerCallId);


Restore Twilio notify guard on answered callbacks

For Twilio outbound calls in notify mode, initiateCall already provisions a one-shot <Say>...<Hangup/> TwiML, but this answered-path now always triggers speakInitialMessage again. That second path calls playTts (which updates the live call to TwiML with <Gather>) and clears metadata.initialMessage before success is confirmed, so answered status callbacks can overwrite the notify flow, cause duplicate playback, or drop the message if the call already ended.

Useful? React with 👍 / 👎.

xinhuagu · 2026-02-28T17:18:39Z

Validation update: I re-ran after rebase and it passes (12/12), including the Twilio/Plivo initial-notify greeting path. Current remaining red CI is the known Windows Feishu proxy test, unrelated to this voice-call change.

xinhuagu · 2026-02-28T17:18:48Z

Clean follow-up: validated after rebase; voice-call manager test suite passes (12/12), including Twilio/Plivo initial-notify greeting behavior. Remaining red CI is the known Windows Feishu proxy test and appears unrelated to this voice-call change.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9cfed53b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T21:05:09Z

extensions/voice-call/src/manager.ts

-      return;
-    }
-
    void this.speakInitialMessage(call.providerCallId);


Skip Twilio notify replay on answered callbacks

Fresh evidence in this revision: Twilio notify calls still deliver a one-shot <Say><Hangup/> via stored TwiML and separate status callbacks (extensions/voice-call/src/providers/twilio.ts), but this new unconditional call to speakInitialMessage on call.answered makes those status callbacks invoke playTts again for notify mode. That can replace the notify hangup flow with <Gather>/second playback (or fail if the call already ended), and speakInitialMessage clears metadata.initialMessage before confirming playback, so the greeting is lost on failure (extensions/voice-call/src/manager/outbound.ts).

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b87505993

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T21:24:14Z

extensions/voice-call/src/manager.ts

-      return;
-    }
-
    void this.speakInitialMessage(call.providerCallId);


Keep Twilio notify calls out of answered greeting replay

For Twilio outbound notify calls, the provider already serves one-shot notify TwiML (<Say>...<Hangup/>) from initiateCall, so replaying speakInitialMessage on every call.answered introduces a second playback path that can overwrite the notify flow with playTts call updates (or fail after hangup). In this path speakInitialMessage clears metadata.initialMessage before confirming playback, so a failed replay also drops the greeting entirely; this regression is introduced by removing the Twilio skip and affects answered status-callback handling for Twilio notify mode.

Useful? React with 👍 / 👎.

@xinhuagu

… (thanks @xinhuagu)

steipete · 2026-03-02T23:55:03Z

Landed via temp rebase onto main.

Gate: pnpm lint && pnpm build && pnpm test
Land commit: b8f32ce
Merge commit: dba47f3

Thanks @xinhuagu!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8f32cea65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T23:57:47Z

extensions/voice-call/src/manager.ts

-      return;
-    }
-
    void this.speakInitialMessage(call.providerCallId);


Skip manager TTS for Twilio notify answered events

maybeSpeakInitialMessageOnAnswered now unconditionally calls speakInitialMessage for Twilio, but outbound Twilio notify calls already deliver metadata.initialMessage through provider-side notify TwiML (generateNotifyTwiml served from TwilioProvider.initiateCall/generateTwimlResponse). Because Twilio status callbacks explicitly include answered, this path now runs on every notify call and can replay the greeting (or override the original <Hangup/> flow with a second TTS update), which changes call behavior and duration for existing Twilio notify users.

Useful? React with 👍 / 👎.

@xinhuagu

… (thanks @xinhuagu)

@xinhuagu

… (thanks @xinhuagu)

@xinhuagu

… (thanks @xinhuagu)

openclaw-barnacle bot added channel: voice-call Channel integration: voice-call size: XS trusted-contributor labels Feb 27, 2026

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

xinhuagu mentioned this pull request Feb 28, 2026

fix(browser): accept url alias for open/navigate tool actions #29184

Closed

xinhuagu force-pushed the fix-29101-twilio-inbound-greeting branch from 39f45e3 to 71a1138 Compare February 28, 2026 08:51

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

xinhuagu force-pushed the fix-29101-twilio-inbound-greeting branch from 41d6cdf to a9cfed5 Compare February 28, 2026 21:02

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

xinhuagu force-pushed the fix-29101-twilio-inbound-greeting branch from a9cfed5 to 9b87505 Compare February 28, 2026 21:22

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

xinhuagu and others added 3 commits March 2, 2026 23:52

fix(voice-call): speak inbound greeting for twilio answered calls

38fb37e

chore(ci): retrigger windows checks

e614e41

fix: land Twilio inbound greeting for answered calls (openclaw#29121)…

b8f32ce

… (thanks @xinhuagu)

steipete force-pushed the fix-29101-twilio-inbound-greeting branch from 9b87505 to b8f32ce Compare March 2, 2026 23:54

steipete merged commit dba47f3 into openclaw:main Mar 2, 2026
10 checks passed

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

dawi369 pushed a commit to dawi369/davis that referenced this pull request Mar 3, 2026

fix: land Twilio inbound greeting for answered calls (openclaw#29121)…

1a318f2

… (thanks @xinhuagu)

OWALabuy pushed a commit to kcinzgg/openclaw that referenced this pull request Mar 4, 2026

fix: land Twilio inbound greeting for answered calls (openclaw#29121)…

91ff85f

… (thanks @xinhuagu)

zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

fix: land Twilio inbound greeting for answered calls (openclaw#29121)…

835d512

… (thanks @xinhuagu)

Takhoffman mentioned this pull request Mar 7, 2026

fix: play inboundGreeting for Twilio inbound calls via TwiML <Say> #29280

Closed

Uh oh!

Conversation

xinhuagu commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Testing

Uh oh!

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

xinhuagu commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

xinhuagu commented Feb 28, 2026

Uh oh!

xinhuagu commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

steipete commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xinhuagu commented Feb 27, 2026 •

edited

Loading