fix(discord): prevent stuck typing indicator by ngutman · Pull Request #26295 · openclaw/openclaw

ngutman · 2026-02-25T08:16:25Z

Summary

prevent channel typing keepalive from restarting after idle or cleanup by sealing typing callbacks once stopped
ensure Discord dispatch always marks typing idle even when draft stream shutdown throws
add regression coverage for post-cleanup typing restart behavior

Root Cause

Typing keepalive introduced in createTypingCallbacks could be re-armed by a late onReplyStart after idle cleanup, and Discord could skip markDispatchIdle() if draft cleanup threw. Either path could leave the typing indicator active indefinitely.

Testing

pnpm vitest run src/channels/typing.test.ts
pnpm vitest run src/discord/monitor/message-handler.process.test.ts

Greptile Summary

Fixes Discord typing indicator getting stuck by preventing keepalive restart after cleanup and ensuring cleanup errors don't skip idle marking.

Added closed flag in src/channels/typing.ts:20 to seal typing callbacks once stopped, preventing late onReplyStart from restarting keepalive after onIdle/onCleanup
Wrapped Discord draft cleanup in try-finally at src/discord/monitor/message-handler.process.ts:726-737 to ensure markDispatchIdle() always executes even if draft stream throws
Added regression test coverage for post-cleanup typing restart behavior

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The fix is surgical and well-tested. The closed flag pattern is a clean way to prevent state machine re-entry after cleanup. The nested try-finally in Discord ensures typing cleanup always completes. Regression test coverage validates the fix. No side effects or breaking changes detected.
No files require special attention

_{Last reviewed commit: 3f37a5e}

ngutman · 2026-02-25T08:23:09Z

Landed via temp rebase onto main.

Gate: pnpm lint && pnpm build && pnpm test (ran; failed in unrelated extension suites and hit Node OOM during full test run)
Land commit: d1de9d5
Merge commit: 56b8c69

Thanks @ngutman!

…@ngutman

…@ngutman)

…@ngutman

…@ngutman)

…k indicator (#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements #26295 which addressed the channel-level callback layer. Fixes #26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

…@ngutman

…@ngutman)

…k indicator (openclaw#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements openclaw#26295 which addressed the channel-level callback layer. Fixes openclaw#26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

…@ngutman

…@ngutman)

…k indicator (openclaw#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements openclaw#26295 which addressed the channel-level callback layer. Fixes openclaw#26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

…@ngutman

…@ngutman)

…k indicator (openclaw#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements openclaw#26295 which addressed the channel-level callback layer. Fixes openclaw#26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

…@ngutman

…@ngutman)

…k indicator (openclaw#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements openclaw#26295 which addressed the channel-level callback layer. Fixes openclaw#26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

…@ngutman

…@ngutman) (cherry picked from commit 56b8c69) # Conflicts: # CHANGELOG.md

…@ngutman

…@ngutman)

…k indicator (openclaw#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements openclaw#26295 which addressed the channel-level callback layer. Fixes openclaw#26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

…@ngutman

…@ngutman) (cherry picked from commit 56b8c69) # Conflicts: # CHANGELOG.md

…k indicator (openclaw#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements openclaw#26295 which addressed the channel-level callback layer. Fixes openclaw#26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

…@ngutman

…@ngutman)

…k indicator (openclaw#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements openclaw#26295 which addressed the channel-level callback layer. Fixes openclaw#26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

…@ngutman

…@ngutman)

…k indicator (openclaw#26881) The followup runner (used for queued messages, inter-agent sends, heartbeat followups, etc.) only called typing.markRunComplete() in its finally block. The typing controller requires BOTH markRunComplete AND markDispatchIdle to trigger cleanup — but markDispatchIdle was only wired through the buffered dispatcher path, which followup turns bypass entirely. This caused the typing indicator to persist indefinitely on channels like Telegram when the agent replied with NO_REPLY or produced empty payloads, because the keepalive loop was never stopped. Adds markDispatchIdle() alongside markRunComplete() in the followup runner's finally block, and four test cases covering NO_REPLY, empty payloads, agent errors, and successful delivery. Complements openclaw#26295 which addressed the channel-level callback layer. Fixes openclaw#26595 Co-authored-by: Samantha <samantha@Samanthas-Mac-mini.local>

fix(discord): prevent stuck typing indicator

3f37a5e

openclaw-barnacle bot added channel: discord Channel integration: discord size: XS maintainer Maintainer-authored PR labels Feb 25, 2026

docs(changelog): add discord typing fix entry (#26295) (thanks @ngutman)

d1de9d5

ngutman merged commit 56b8c69 into main Feb 25, 2026
7 checks passed

ngutman deleted the fix/discord-typing-stuck branch February 25, 2026 08:21

github-actions bot mentioned this pull request Feb 25, 2026

📡 Upstream Digest — 2026-02-25 08:38 UTC curtismercier/openclaw-mods#123

Open

This was referenced Feb 25, 2026

[Bug]: Discord typing indicator persists indefinitely after agent run completes in thread #26640

Closed

[Bug]: Telegram typing indicator keepalive never stops after reply completes (2026.2.24) #26621

Closed

akropp pushed a commit to akropp/openclaw that referenced this pull request Feb 25, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

f1123df

…@ngutman)

Jackson3195 pushed a commit to Jackson3195/openclaw-with-a-personal-touch that referenced this pull request Feb 25, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

47cb17f

…@ngutman)

This was referenced Feb 25, 2026

[Bug] Discord typing indicator stuck permanently after first reply (2026.2.24) #26419

Closed

[Bug]: Telegram typing indicator stuck indefinitely when elevated tools are involved #26416

Closed

hajekt2 mentioned this pull request Feb 25, 2026

fix(discord): prevent stuck typing indicator after response delivery #26510

Closed

codexGW mentioned this pull request Feb 25, 2026

fix(typing): call markDispatchIdle in followup runner to prevent stuck indicator #26881

Merged

clawrl3000 mentioned this pull request Feb 26, 2026

bug(telegram): typing indicator stuck after 2026.2.24 update (regression from #26295/#26325) #26993

Closed

openperf mentioned this pull request Feb 26, 2026

fix(typing): cancel in-flight typing HTTP requests on stop for Telegram and Discord #26201

Closed

brianleach pushed a commit to brianleach/openclaw that referenced this pull request Feb 26, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

3719fef

…@ngutman)

haoyan-yam mentioned this pull request Feb 26, 2026

[Feature]: web_fetch: add ssrfPolicy.dangerouslyAllowPrivateNetwork option (like browser tool) #27223

Closed

arjunaskykok mentioned this pull request Feb 26, 2026

fix/test a2ui bundle preflight #27345

Open

2 tasks

steubens mentioned this pull request Feb 26, 2026

Telegram typing indicator keepalive loop leaks after reply completes #27493

Closed

BooRy95 mentioned this pull request Feb 26, 2026

[Bug] Discord typing indicator persists indefinitely after message delivery #27033

Closed

execute008 pushed a commit to execute008/openclaw that referenced this pull request Feb 27, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

35764e0

…@ngutman)

r4jiv007 pushed a commit to r4jiv007/openclaw that referenced this pull request Feb 28, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

bab15de

…@ngutman)

vincentkoc pushed a commit to rylena/rylen-openclaw that referenced this pull request Feb 28, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

8061dc8

…@ngutman)

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

55f042a

…@ngutman) (cherry picked from commit 56b8c69) # Conflicts: # CHANGELOG.md

steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

163841b

…@ngutman)

hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

ac92851

…@ngutman) (cherry picked from commit 56b8c69) # Conflicts: # CHANGELOG.md

zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

f02a84c

…@ngutman)

thebenjaminlee pushed a commit to escape-velocity-ventures/openclaw that referenced this pull request Mar 7, 2026

docs(changelog): add discord typing fix entry (openclaw#26295) (thanks …

8862056

…@ngutman)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(discord): prevent stuck typing indicator#26295

fix(discord): prevent stuck typing indicator#26295
ngutman merged 2 commits intomainfrom
fix/discord-typing-stuck

ngutman commented Feb 25, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

Uh oh!

ngutman commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ngutman commented Feb 25, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root Cause

Testing

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

ngutman commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ngutman commented Feb 25, 2026 •

edited by greptile-apps bot

Loading