fix(matrix): per-room send queue and immediate read receipts by joshjhall · Pull Request #25841 · openclaw/openclaw

joshjhall · 2026-02-24T21:54:15Z

Summary

Two contained fixes for the Matrix channel plugin addressing message ordering and read receipt UX.

1. Per-room send queue — fixes #11614

Matrix orders messages by origin_server_ts. When multiple code paths (auto-reply, message tool, media sends) fire concurrently, they race and messages appear out of order.

Fix: New send-queue.ts module that serializes all sends per room through enqueueSend(). Each send waits for the previous one to complete, with a 150ms inter-send gap to ensure distinct server timestamps.

Changed files:

extensions/matrix/src/matrix/send-queue.ts (new) — the queue implementation
extensions/matrix/src/matrix/send.ts — wraps the send body in enqueueSend()

2. Immediate read receipts — fixes #25840

Read receipts were sent deep inside the handler pipeline (handler.ts line ~606), after access control, room config resolution, and auto-reply generation. This meant messages appeared "unread" in Element while the agent was processing.

Fix: Move sendReadReceiptMatrix to fire immediately on message arrival in events.ts, before any processing. Self-messages are filtered via lazy getUserId() resolution.

Changed files:

extensions/matrix/src/matrix/monitor/events.ts — fires receipt on SDK message event
extensions/matrix/src/matrix/monitor/handler.ts — removes redundant receipt call (replaced with comment)

Testing

Both fixes have been running in production for ~2 weeks via a local plugin fork against a live Matrix homeserver (Tuwunel/Conduit fork)
Message ordering verified with concurrent message tool + auto-reply sends
Read receipts appear immediately in Element after fix
No regressions observed in DM, group, or threaded message flows
CI: awaiting upstream CI run (no local pnpm build && pnpm check && pnpm test run against the monorepo — changes are plugin-scoped and don't touch core)

AI Disclosure

AI-assisted (Claude via OpenClaw)
Lightly tested in local fork; production-validated for ~2 weeks
I understand what the code does

Notes

Both changes are fully contained within extensions/matrix/ and have no effect on other channels or core behavior. The send queue could potentially be generalized to the core outbound layer to benefit other timestamp-ordered channels (as noted in #11614), but this PR keeps the scope minimal.

Greptile Summary

Two targeted fixes for the Matrix channel plugin: (1) a per-room send queue that serializes outbound messages through promise chaining with a 150ms inter-send gap to ensure distinct origin_server_ts ordering, and (2) moving read receipt emission to fire immediately on message arrival rather than after the full handler pipeline.

The send queue in send-queue.ts correctly serializes sendMessageMatrix calls, but its isSettled cleanup helper has a bug — .then() callbacks are microtasks that never execute synchronously, so the function always returns false and queue entries are never cleaned up (slow memory leak).
Only sendMessageMatrix is wrapped in enqueueSend; sendPollMatrix and reactMatrixMessage bypass the queue, which is a minor coverage gap if polls/reactions need to be ordered relative to text messages.
The read receipt change in events.ts is clean — fire-and-forget with lazy self-user filtering, and the redundant call in handler.ts is properly removed.
Changes are fully scoped to extensions/matrix/ with no impact on other channels or core.

Confidence Score: 3/5

Functionally sound with one bug (memory leak from isSettled) that should be fixed before merge
The core send queue serialization and read receipt changes work correctly and are well-scoped. However, the isSettled function in send-queue.ts has a logic bug that prevents queue cleanup, causing a slow memory leak. The indentation in send.ts is also inconsistent. Neither issue causes incorrect message ordering or delivery failures, but the memory leak should be addressed.
Pay close attention to extensions/matrix/src/matrix/send-queue.ts — the isSettled function needs to be fixed to actually detect settled promises

_{Last reviewed commit: 4b29e19}

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

Two fixes for the Matrix channel plugin: 1. Per-room send queue (fixes openclaw#11614): Introduce send-queue.ts that serializes all sends to the same Matrix room through enqueueSend(), with a 150ms inter-send gap to ensure distinct origin_server_ts values. This prevents message ordering races when auto-reply and message tool sends fire concurrently. 2. Immediate read receipts (fixes openclaw#25840): Move sendReadReceiptMatrix from handler.ts (deep in the processing pipeline) to events.ts (on message arrival from SDK). Read receipts now fire before any processing, so Element shows 'read' immediately even when the agent is busy. Self-messages are filtered via lazy getUserId resolution. Both changes are contained within the Matrix extension and have no effect on other channels. AI-assisted: This PR was developed with AI assistance (Claude/OpenClaw). Tested against a live Matrix homeserver (Tuwunel/Conduit fork) with both fixes running in production for ~2 weeks via a local plugin fork.

greptile-apps

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-24T21:56:50Z

extensions/matrix/src/matrix/send-queue.ts

+function isSettled(p: Promise<unknown>): boolean {
+  let settled = false;
+  p.then(
+    () => {
+      settled = true;
+    },
+    () => {
+      settled = true;
+    },
+  );
+  return settled;
+}


isSettled always returns false

.then() callbacks are microtasks and always run asynchronously — even if the promise is already resolved, the settled = true assignment won't execute until after isSettled returns. This means the cleanup setTimeout at line 41 will never delete entries from the queues map, causing a slow memory leak (one settled Promise<void> per room that was ever messaged).

A simple fix is to use Promise.race:

Suggested change

function isSettled(p: Promise<unknown>): boolean {

let settled = false;

p.then(

() => {

settled = true;

},

() => {

settled = true;

},

);

return settled;

}

function isSettled(p: Promise<unknown>): boolean {

const pending = Symbol();

let result: unknown = pending;

Promise.race([p, Promise.resolve(pending)]).then(

(v) => {

result = v;

},

() => {

result = undefined;

},

);

// microtask from an already-settled promise resolves synchronously in race

return result !== pending;

}

Alternatively, since the cleanup fires 1 second after next.finally(), the simplest approach is to just always delete the entry (the queue will be recreated on next enqueueSend call):

next.finally(() => { setTimeout(() => { const current = queues.get(roomId); if (current === next.then(() => {}, () => {})) { queues.delete(roomId); } }, 1000); });

Or store a reference to compare against instead of checking settledness.

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/matrix/src/matrix/send-queue.ts Line: 54-65 Comment: **`isSettled` always returns `false`** `.then()` callbacks are microtasks and always run asynchronously — even if the promise is already resolved, the `settled = true` assignment won't execute until after `isSettled` returns. This means the cleanup `setTimeout` at line 41 will never delete entries from the `queues` map, causing a slow memory leak (one settled `Promise<void>` per room that was ever messaged). A simple fix is to use `Promise.race`: ```suggestion function isSettled(p: Promise<unknown>): boolean { const pending = Symbol(); let result: unknown = pending; Promise.race([p, Promise.resolve(pending)]).then( (v) => { result = v; }, () => { result = undefined; }, ); // microtask from an already-settled promise resolves synchronously in race return result !== pending; } ``` Alternatively, since the cleanup fires 1 second after `next.finally()`, the simplest approach is to just always delete the entry (the queue will be recreated on next `enqueueSend` call): ``` next.finally(() => { setTimeout(() => { const current = queues.get(roomId); if (current === next.then(() => {}, () => {})) { queues.delete(roomId); } }, 1000); }); ``` Or store a reference to compare against instead of checking settledness. How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-24T21:56:51Z

extensions/matrix/src/matrix/send.ts

+    return await enqueueSend(roomId, async () => {
    const cfg = getCore().config.loadConfig();


Callback body not indented

The code inside the enqueueSend callback is at the same indentation level as the return await enqueueSend(...) line. The body should be indented one level deeper for readability. This likely won't pass pnpm check (oxfmt).

Suggested change

return await enqueueSend(roomId, async () => {

const cfg = getCore().config.loadConfig();

return await enqueueSend(roomId, async () => {

const cfg = getCore().config.loadConfig();

(and similarly for all lines through the closing }); at line 151)

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/matrix/src/matrix/send.ts Line: 53-54 Comment: **Callback body not indented** The code inside the `enqueueSend` callback is at the same indentation level as the `return await enqueueSend(...)` line. The body should be indented one level deeper for readability. This likely won't pass `pnpm check` (oxfmt). ```suggestion return await enqueueSend(roomId, async () => { const cfg = getCore().config.loadConfig(); ``` (and similarly for all lines through the closing `});` at line 151) How can I resolve this? If you propose a fix, please make it concise.

@pewallin

Lands reviewed fixes based on #25839 (@pewallin), #25841 (@joshjhall), and #25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes #25836 Fixes #25840 Fixes #25824 Fixes #25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

steipete · 2026-02-24T23:28:34Z

Superseded by main commit e7a5f9f4d.

What landed from this PR:

immediate Matrix read receipts on room.message in extensions/matrix/src/matrix/monitor/events.ts
removal of delayed read-receipt dispatch from extensions/matrix/src/matrix/monitor/handler.ts
per-room send serialization wiring in extensions/matrix/src/matrix/send.ts

Deep-review fixup applied before landing:

reimplemented queue cleanup in extensions/matrix/src/matrix/send-queue.ts to clean by queue-marker identity (roomQueues.get(roomId) === queueMarker), avoiding stale map entry leaks/races

Test coverage added/kept in landed commit:

extensions/matrix/src/matrix/monitor/events.test.ts for immediate non-self receipts
extensions/matrix/src/matrix/send-queue.test.ts for per-room serialization, cross-room parallelism, and post-failure continuity

Linked issue status:

#25840 is now closed by the landed commit

Thanks for the solid base PR.

@shakkernerd

* ui: block svg data image opens and harden tests * changelog: credit both chat-image fix contributors * test(ui): reject base64 SVG data URLs * changelog: include openclaw#25847 in chat image safety entry (openclaw#25847) (thanks @shakkernerd) * refactor(ios): drop legacy talk payload and keychain fallbacks * chore: sync plugin versions to 2026.2.24 * chore: refresh lockfile after plugin devDependency cleanup * fix(config): soften antigravity removal fallout (openclaw#25538) Land openclaw#25538 by @chilu18 to keep legacy google-antigravity-auth config entries non-fatal after removal (see openclaw#25862). Co-authored-by: chilu18 <chilu.machona@icloud.com> * fix(security): lock sandbox tmp media paths to openclaw roots * docs(security): document openclaw temp-folder boundary * fix(security): restrict default safe-bin trusted dirs * fix: enforce local media root checks for attachment hydration * fix(synology-chat): fail closed empty allowlist * docs(changelog): add synology-chat allowlist fail-closed note * fix: harden routing/session isolation for followups and heartbeat * feat(sandbox): block container namespace joins by default * refactor(sandbox): centralize network mode policy helpers * fix(channels,sandbox): land hard breakage cluster from reviewed PR bases Lands reviewed fixes based on openclaw#25839 (@pewallin), openclaw#25841 (@joshjhall), and openclaw#25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes openclaw#25836 Fixes openclaw#25840 Fixes openclaw#25824 Fixes openclaw#25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com> * refactor(synology-chat): centralize DM auth and fail fast startup * test: add routing/session isolation edge-case regressions * refactor: centralize followup origin routing helpers * refactor(outbound): centralize attachment media policy * refactor: harden safe-bin trusted dir diagnostics * fix(zalo): enforce group sender policy in groups * docs: update changelog for safe-bin hardening * test(line): align tmp-root expectation after sandbox hardening * fix(web-search): reduce provider auto-detect log noise * test(matrix,discord,sandbox): expand breakage regression coverage * refactor(matrix,tests): extract helpers and inject send-queue timing * refactor(zalo): split monitor access and webhook logic * Gateway/Security: protect /api/channels plugin root * fix(telegram): block unauthorized DM media downloads * Security: sanitize inherited host exec env * Changelog: add entry for exec env sanitization * fix(security): classify hook sessions case-insensitively * refactor(outbound): unify attachment hydration flow * refactor(telegram): simplify DM media auth precheck flow * fix(automation): harden announce delivery + cron coding profile (openclaw#25813 openclaw#25821 openclaw#25822) Co-authored-by: Shawn <shenghuikevin@shenghuideMac-mini.local> Co-authored-by: 不做了睡大觉 <user@example.com> Co-authored-by: Marcus Widing <widing.marcus@gmail.com> * security(voice-call): detect Telnyx webhook replay * Auto-reply: add exact stop trigger for do not do that * Auto-reply tests: assert exact do not do that behavior * Gateway tests: cover exact do not do that stop matching * Telegram tests: route exact do not do that to control lane * Changelog: note exact do not do that stop trigger * refactor(tmp): harden temp boundary guardrails * fix(whatsapp): stop retry loop on non-retryable 440 close * test(types): fix ts narrowing regressions in followup and matrix queue tests * fix(onboard): avoid false 'telegram plugin not available' block * fix: normalize "bedrock" provider ID to "amazon-bedrock" Add "bedrock" and "aws-bedrock" as aliases for the canonical "amazon-bedrock" provider ID in normalizeProviderId(). Without this mapping, configuring a model as "bedrock/..." causes the auth resolution fallback to miss the Bedrock-specific AWS SDK path, since the fallback check requires normalized === "amazon-bedrock". This primarily affects the main agent when the explicit auth override is not preserved through config merging. Fixes openclaw#15716 * docs(changelog): backfill landed fix PR entries * fix(security): harden system.run companion command binding * fix(discord): land proxy/media/reaction/model-picker regressions Reimplements core Discord fixes from openclaw#25277 openclaw#25523 openclaw#25575 openclaw#25588 openclaw#25731 with expanded tests. - thread proxy-aware fetch into inbound attachment/sticker downloads - fetch /gateway/bot via proxy dispatcher before ws connect - wire statusReactions emojis/timing overrides into controller - compact model-picker custom_id keys with backward-compatible parsing Co-authored-by: openperf <openperf@users.noreply.github.com> Co-authored-by: chilu18 <chilu18@users.noreply.github.com> Co-authored-by: Yipsh <Yipsh@users.noreply.github.com> Co-authored-by: lbo728 <lbo728@users.noreply.github.com> Co-authored-by: s1korrrr <s1korrrr@users.noreply.github.com> * docs(changelog): add reporter credit for exec companion hardening * fix(macos): guard voice audio paths with no input device (openclaw#25817) Co-authored-by: Stefan Förster <103369858+sfo2001@users.noreply.github.com> * fix(macos): prefer openclaw binary while keeping pnpm fallback (openclaw#25512) Co-authored-by: Peter Machona <7957943+chilu18@users.noreply.github.com> * Auth: bypass cooldown tracking for OpenRouter * Auth: use cooldown helper in explicit profile order * Tests: cover OpenRouter cooldown display bypass * Tests: skip OpenRouter failure cooldown persistence * Tests: keep OpenRouter runnable with legacy cooldown markers * Tests: preserve OpenRouter explicit auth order under cooldown fields * Changelog: note OpenRouter cooldown bypass * Changelog: remove unrelated session entries from PR * Update CHANGELOG.md * fix(macos): default voice wake forwarding to webchat (openclaw#25440) Co-authored-by: Peter Machona <7957943+chilu18@users.noreply.github.com> * fix(macos): keep Return for IME marked text commit (openclaw#25178) Co-authored-by: jft0m <9837901+bottotl@users.noreply.github.com> * fix(security): block env depth-overflow approval bypass * fix(macos): resolve webchat panel corner clipping (openclaw#22458) Co-authored-by: apethree <3081182+apethree@users.noreply.github.com> Co-authored-by: agisilaos <3073709+agisilaos@users.noreply.github.com> * Agents: trust explicit allowlist refs beyond catalog * Tests: cover allowlist refs missing from catalog * Gateway tests: accept allowlisted refs absent from catalog * Gateway tests: include synthetic allowlist models in models.list * Changelog: note allowlist stale-catalog model selection fix * fix(discord): harden voice DAVE receive reliability (openclaw#25861) Reimplements and consolidates related work: - openclaw#24339 stale disconnect/destroyed session guards - openclaw#25312 voice listener cleanup on stop - openclaw#23036 restore @snazzah/davey runtime dependency Adds Discord voice DAVE config passthrough, repeated decrypt failure rejoin recovery, regression tests, docs, and changelog updates. Co-authored-by: Frank Yang <frank.ekn@gmail.com> Co-authored-by: Do Cao Hieu <admin@docaohieu.com> * fix(macos): clean warnings and harden gateway/talk config parsing * docs(discord): document DAVE defaults and decrypt recovery * test: bridge discord voice private casts via unknown * docs(changelog): remove next-release shipping sentence * refactor(exec): split system.run phases and align ts/swift validator contracts * fix(windows): skip unreliable dev comparison in fs-safe openVerifiedLocalFile On Windows, device IDs (dev) returned by handle.stat() and fs.lstat() may differ even for the same file, causing false-positive 'path-mismatch' errors when reading local media files. This fix introduces a statsMatch() helper that: - Always compares inode (ino) values - Skips device ID (dev) comparison on Windows where it's unreliable - Maintains full comparison on Unix platforms Fixes openclaw#25699 * fix: align windows safe-open file identity checks * refactor: dedupe exec wrapper denial plan and test setup * fix: harden iMessage echo dedupe and reasoning suppression (openclaw#25897) * test(media): add win32 dev=0 local media regression * refactor: extract iMessage echo cache and unify suppression guards * test: normalize tmp media path assertion for windows * fix(render): seed Control UI origin config on first boot The gateway requires controlUi.allowedOrigins when binding to LAN. On Render, the persistent disk starts empty with no openclaw.json. Seed a minimal config with dangerouslyAllowHostHeaderOriginFallback on first boot (safe behind Render's HTTPS reverse proxy). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore(deps): update dependencies except carbon * fix(agents): normalize SiliconFlow Pro thinking=off payload (openclaw#25435) Land PR openclaw#25435 from @Zjianru. Changelog: add 2026.2.24 fix entry with contributor credit. Co-authored-by: codez <codezhujr@gmail.com> * fix(telegram): refresh global undici dispatcher for autoSelectFamily (openclaw#25682) Land PR openclaw#25682 from @lairtonlelis after maintainer rework: track dispatcher updates when network decision changes to avoid stale global fetch behavior. Co-authored-by: Ailton <lairton@telnyx.com> * fix(synology-chat): land @bmendonca3 fail-closed allowlist follow-up (openclaw#25827) Carry fail-closed empty-allowlist guard clarity and changelog attribution for PR openclaw#25827. Co-authored-by: Brian Mendonca <brianmendonca@Brians-MacBook-Air.local> * fix(agents): reduce billing false positives on long text (openclaw#25680) Land PR openclaw#25680 from @lairtonlelis. Retain explicit status/code/http 402 detection for oversized structured payloads. Co-authored-by: Ailton <lairton@telnyx.com> * fix(render): add docker entrypoint script for config seeding The inline shell command in render.yaml's dockerCommand wasn't reliably creating the seed config. Replace with a proper entrypoint script that creates a minimal openclaw.json with dangerouslyAllowHostHeaderOriginFallback on first boot, then starts the gateway bound to LAN on the PORT env var. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(ui): inherit default model fallbacks in agents overview (openclaw#25729) Land PR openclaw#25729 from @Suko. Use shared fallback-resolution helper and add regression coverage for default, override, and explicit-empty cases. Co-authored-by: suko <miha.sukic@gmail.com> * fix(heartbeat): default target none and internalize relay prompts * test(windows): normalize risky-path assertions --------- Co-authored-by: Shakker <shakkerdroid@gmail.com> Co-authored-by: Peter Steinberger <steipete@gmail.com> Co-authored-by: chilu18 <chilu.machona@icloud.com> Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com> Co-authored-by: Brian Mendonca <brianmendonca@Brians-MacBook-Air.local> Co-authored-by: Shawn <shenghuikevin@shenghuideMac-mini.local> Co-authored-by: 不做了睡大觉 <user@example.com> Co-authored-by: Marcus Widing <widing.marcus@gmail.com> Co-authored-by: Vincent Koc <vincentkoc@ieee.org> Co-authored-by: Mark Musson <mark@musson.co.za> Co-authored-by: suko <miha.sukic@gmail.com> Co-authored-by: Fred White <fwhite13@users.noreply.github.com> Co-authored-by: openperf <openperf@users.noreply.github.com> Co-authored-by: chilu18 <chilu18@users.noreply.github.com> Co-authored-by: Yipsh <Yipsh@users.noreply.github.com> Co-authored-by: lbo728 <lbo728@users.noreply.github.com> Co-authored-by: s1korrrr <s1korrrr@users.noreply.github.com> Co-authored-by: Stefan Förster <103369858+sfo2001@users.noreply.github.com> Co-authored-by: Peter Machona <7957943+chilu18@users.noreply.github.com> Co-authored-by: jft0m <9837901+bottotl@users.noreply.github.com> Co-authored-by: apethree <3081182+apethree@users.noreply.github.com> Co-authored-by: agisilaos <3073709+agisilaos@users.noreply.github.com> Co-authored-by: Frank Yang <frank.ekn@gmail.com> Co-authored-by: Do Cao Hieu <admin@docaohieu.com> Co-authored-by: Gavin X. Wang <gavinvybers@Gavins-MacBook-Pro.local> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: codez <codezhujr@gmail.com> Co-authored-by: Ailton <lairton@telnyx.com>

@pewallin

Lands reviewed fixes based on #25839 (@pewallin), #25841 (@joshjhall), and #25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes #25836 Fixes #25840 Fixes #25824 Fixes #25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

@pewallin

Lands reviewed fixes based on openclaw#25839 (@pewallin), openclaw#25841 (@joshjhall), and openclaw#25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes openclaw#25836 Fixes openclaw#25840 Fixes openclaw#25824 Fixes openclaw#25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

@pewallin

Lands reviewed fixes based on openclaw#25839 (@pewallin), openclaw#25841 (@joshjhall), and openclaw#25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes openclaw#25836 Fixes openclaw#25840 Fixes openclaw#25824 Fixes openclaw#25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

@pewallin

Lands reviewed fixes based on openclaw#25839 (@pewallin), openclaw#25841 (@joshjhall), and openclaw#25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes openclaw#25836 Fixes openclaw#25840 Fixes openclaw#25824 Fixes openclaw#25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

@pewallin

Lands reviewed fixes based on openclaw#25839 (@pewallin), openclaw#25841 (@joshjhall), and openclaw#25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes openclaw#25836 Fixes openclaw#25840 Fixes openclaw#25824 Fixes openclaw#25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

@pewallin

Lands reviewed fixes based on openclaw#25839 (@pewallin), openclaw#25841 (@joshjhall), and openclaw#25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes openclaw#25836 Fixes openclaw#25840 Fixes openclaw#25824 Fixes openclaw#25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

@pewallin

Lands reviewed fixes based on openclaw#25839 (@pewallin), openclaw#25841 (@joshjhall), and openclaw#25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes openclaw#25836 Fixes openclaw#25840 Fixes openclaw#25824 Fixes openclaw#25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

@pewallin

Lands reviewed fixes based on openclaw#25839 (@pewallin), openclaw#25841 (@joshjhall), and openclaw#25737/@25713 (@DennisGoldfinger/@peteragility), with additional hardening + regression tests for queue cleanup and shell script safety. Fixes openclaw#25836 Fixes openclaw#25840 Fixes openclaw#25824 Fixes openclaw#25868 Co-authored-by: Peter Wallin <pwallin@gmail.com> Co-authored-by: Joshua Hall <josh@yaplabs.com> Co-authored-by: Dennis Goldfinger <dennisgoldfinger@gmail.com> Co-authored-by: peteragility <peteragility@users.noreply.github.com>

greptile-apps bot reviewed Feb 24, 2026

View reviewed changes

openclaw-barnacle bot added channel: matrix Channel integration: matrix size: S labels Feb 24, 2026

style: apply oxfmt formatting

aa8ebba

openclaw-barnacle bot added size: M and removed size: S labels Feb 24, 2026

steipete closed this Feb 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(matrix): per-room send queue and immediate read receipts#25841

fix(matrix): per-room send queue and immediate read receipts#25841
joshjhall wants to merge 2 commits intoopenclaw:mainfrom
joshjhall:fix/matrix-send-queue-and-read-receipts

joshjhall commented Feb 24, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 24, 2026

Uh oh!

greptile-apps bot Feb 24, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-function isSettled(p: Promise<unknown>): boolean {
-  let settled = false;
-  p.then(
-    () => {
-      settled = true;
-    },
-    () => {
-      settled = true;
-    },
-  );
-  return settled;
-}
+function isSettled(p: Promise<unknown>): boolean {
+  const pending = Symbol();
+  let result: unknown = pending;
+  Promise.race([p, Promise.resolve(pending)]).then(
+    (v) => {
+      result = v;
+    },
+    () => {
+      result = undefined;
+    },
+  );
+  // microtask from an already-settled promise resolves synchronously in race
+  return result !== pending;
+}

		return await enqueueSend(roomId, async () => {
		const cfg = getCore().config.loadConfig();

Uh oh!

Conversation

joshjhall commented Feb 24, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

1. Per-room send queue — fixes #11614

2. Immediate read receipts — fixes #25840

Testing

AI Disclosure

Notes

Greptile Summary

Confidence Score: 3/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joshjhall commented Feb 24, 2026 •

edited by greptile-apps bot

Loading