fix(cli): replace stale doctor/restart command hints by chilu18 · Pull Request #24485 · openclaw/openclaw

chilu18 · 2026-02-23T12:50:25Z

Summary

replace stale restart hint openclaw gateway status --probe --deep with valid openclaw gateway status --deep
replace nonexistent openclaw auth add --provider ... doctor guidance with valid interactive command openclaw configure --section auth
add regression tests for both hint paths

Why

fixes invalid guidance reported in [Bug] update error hint suggests removed --probe option for gateway status #24351 and Doctor suggests nonexistent openclaw auth add command #24220
ensures users get runnable commands during failure recovery and doctor output

Validation

corepack pnpm exec vitest run src/commands/doctor-memory-search.test.ts src/cli/daemon-cli/lifecycle.test.ts
corepack pnpm exec oxfmt --check src/commands/doctor-memory-search.ts src/commands/doctor-memory-search.test.ts src/cli/daemon-cli/lifecycle.ts src/cli/daemon-cli/lifecycle.test.ts src/cli/update-cli/update-command.ts

Greptile Summary

This PR fixes stale command hints by replacing the invalid openclaw gateway status --probe --deep with the correct openclaw gateway status --deep (the --probe flag doesn't exist; probing is enabled by default via --no-probe opt-out). It also replaces the nonexistent openclaw auth add --provider command with an interactive configuration command.

Issues Found

Critical: The PR uses openclaw configure --section auth, but this section doesn't exist. The valid section for configuring provider credentials is model (see src/commands/configure.shared.ts:54 and src/commands/configure.wizard.ts:387,440). This will cause runtime errors when users try the suggested command.

What Works Well

Correctly removes the invalid --probe flag from openclaw gateway status --deep
Correctly suggests openclaw doctor as a valid troubleshooting command
Adds proper test coverage for the hint paths
The lifecycle test correctly validates the hints array

Confidence Score: 1/5

This PR introduces a critical bug that will provide users with invalid command suggestions
The PR correctly fixes the --probe flag issue but introduces a new bug by referencing a non-existent --section auth configuration section. Users following the suggested command will encounter errors. The correct section name is model.
Pay close attention to src/commands/doctor-memory-search.ts and its test file - they both reference an invalid configuration section

_{Last reviewed commit: 526ca18}

greptile-apps

_{5 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-23T12:54:09Z

src/commands/doctor-memory-search.ts

        "Fix (pick one):",
        `- Set ${envVar} in your environment`,
-        `- Add credentials: ${formatCliCommand(`openclaw auth add --provider ${resolved.provider}`)}`,
+        `- Configure credentials: ${formatCliCommand("openclaw configure --section auth")}`,


--section auth is not a valid section. Should be --section model (which handles "Pick provider + credentials" per src/commands/configure.shared.ts:54)

Suggested change

`- Configure credentials: ${formatCliCommand("openclaw configure --section auth")}`,

`- Configure credentials: ${formatCliCommand("openclaw configure --section model")}`,

Prompt To Fix With AI

This is a comment left during a code review. Path: src/commands/doctor-memory-search.ts Line: 65 Comment: `--section auth` is not a valid section. Should be `--section model` (which handles "Pick provider + credentials" per `src/commands/configure.shared.ts:54`) ```suggestion `- Configure credentials: ${formatCliCommand("openclaw configure --section model")}`, ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-23T12:54:10Z

src/commands/doctor-memory-search.ts

      "Fix (pick one):",
      "- Set OPENAI_API_KEY, GEMINI_API_KEY, VOYAGE_API_KEY, or MISTRAL_API_KEY in your environment",
-      `- Add credentials: ${formatCliCommand("openclaw auth add --provider openai")}`,
+      `- Configure credentials: ${formatCliCommand("openclaw configure --section auth")}`,


same issue - --section auth should be --section model

Suggested change

`- Configure credentials: ${formatCliCommand("openclaw configure --section auth")}`,

`- Configure credentials: ${formatCliCommand("openclaw configure --section model")}`,

Prompt To Fix With AI

This is a comment left during a code review. Path: src/commands/doctor-memory-search.ts Line: 92 Comment: same issue - `--section auth` should be `--section model` ```suggestion `- Configure credentials: ${formatCliCommand("openclaw configure --section model")}`, ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-23T12:54:11Z

src/commands/doctor-memory-search.test.ts

+
+    expect(note).toHaveBeenCalledTimes(1);
+    const message = String(note.mock.calls[0]?.[0] ?? "");
+    expect(message).toContain("openclaw configure --section auth");


test expects wrong section name - should check for model not auth

Suggested change

expect(message).toContain("openclaw configure --section auth");

expect(message).toContain("openclaw configure --section model");

Prompt To Fix With AI

This is a comment left during a code review. Path: src/commands/doctor-memory-search.test.ts Line: 142 Comment: test expects wrong section name - should check for `model` not `auth` ```suggestion expect(message).toContain("openclaw configure --section model"); ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-23T12:54:12Z

src/commands/doctor-memory-search.test.ts

+
+    expect(note).toHaveBeenCalledTimes(1);
+    const message = String(note.mock.calls[0]?.[0] ?? "");
+    expect(message).toContain("openclaw configure --section auth");


test expects wrong section name - should check for model not auth

Suggested change

expect(message).toContain("openclaw configure --section auth");

expect(message).toContain("openclaw configure --section model");

Prompt To Fix With AI

This is a comment left during a code review. Path: src/commands/doctor-memory-search.test.ts Line: 158 Comment: test expects wrong section name - should check for `model` not `auth` ```suggestion expect(message).toContain("openclaw configure --section model"); ``` How can I resolve this? If you propose a fix, please make it concise.

chilu18 · 2026-02-23T13:26:58Z

All required checks are green and merge state is CLEAN. This is ready for maintainer merge when convenient.

…lu18

…lu18)

…lu18

…lu18)

@chilu18