fix(ui): prevent tabnabbing in chat images#18685
Merged
shakkernerd merged 4 commits intoopenclaw:mainfrom Feb 24, 2026
Merged
Conversation
…images UI: prevent tabnabbing in chat images
Member
|
Landed iin main:
Merge commit: Thanks @Mariana-Codebase! |
plgs2005
pushed a commit
to plgs2005/openclaw
that referenced
this pull request
Feb 24, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com>
18 tasks
xianfeng92
pushed a commit
to xianfeng92/openclaw
that referenced
this pull request
Feb 24, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com> (cherry picked from commit 649d141)
abdelkadermeflahi6-web
referenced
this pull request
Feb 24, 2026
abdelkadermeflahi6-web
referenced
this pull request
Feb 24, 2026
obviyus
pushed a commit
to Glucksberg/OpenClaw
that referenced
this pull request
Feb 24, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com>
18 tasks
margulans
pushed a commit
to margulans/Neiron-AI-assistant
that referenced
this pull request
Feb 25, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com>
brianleach
pushed a commit
to brianleach/openclaw
that referenced
this pull request
Feb 26, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com>
2 tasks
execute008
pushed a commit
to execute008/openclaw
that referenced
this pull request
Feb 27, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com>
Get-windy
pushed a commit
to Get-windy/JieZi-ai-PS
that referenced
this pull request
Feb 28, 2026
更新内容: - fix(ui): prevent tabnabbing in chat images (openclaw#18685) - fix(cli): replace stale doctor/restart command hints (openclaw#24485) - Auto-reply: normalize stop matching + multilingual triggers (openclaw#25103) - docs: fix broken links, add maintainer
r4jiv007
pushed a commit
to r4jiv007/openclaw
that referenced
this pull request
Feb 28, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com>
joelnishanth
pushed a commit
to joelnishanth/openclaw
that referenced
this pull request
Mar 3, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com>
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
* UI: prevent tabnabbing in chat images * ui: remove comment from image open helper --------- Co-authored-by: Shakker <shakkerdroid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.openallows tabnabbing viawindow.opener.noopener,noreferrerand forceopener = null.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
window.opener.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
window.opener.Expected
window.openerisnullin the opened tab.Actual
window.openerisnullin the opened tab.Evidence
Attach at least one:
Human Verification (required)
opener.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
ui/src/ui/chat/grouped-render.tsRisks and Mitigations
Greptile Summary
Adds tabnabbing protection to the chat image click handler in
grouped-render.ts. The previouswindow.open(url, "_blank")call gave the opened tab access towindow.opener, which could be exploited for phishing by redirecting or manipulating the original app tab. The fix passesnoopener,noreferreras window features and adds a fallbackopener = nullassignment for defense-in-depth in older browsers.openImagehelper with security hardeningConfidence Score: 5/5
noopener,noreferrerto awindow.opencall. It introduces no new logic, no new dependencies, and no behavioral changes beyond removing the opener reference. The pattern is standard and widely recommended by OWASP and browser security guidelines.Last reviewed commit: 4ee26ff
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!